Decrease attachment size limit #12497

Tushu17 · 2022-11-05T20:03:47Z

Details

Fixed Issues

$ #8235
PROPOSAL: #8235 (comment)

Tests

Go to chat
Select Actions -> Add attachment
Share any attachment of size greater than 24 mb
Check if error message popup is showing up correctly

Verify that no errors appear in the JS console

QA Steps

Go to chat
Select Actions -> Add attachment
Share any attachment of size greater than 24 mb
Check if error message popup is showing up correctly

Verify that no errors appear in the JS console

PR Author Checklist

PR Reviewer Checklist

The reviewer will copy/paste it into a new comment and complete it after the author checklist is completed

Screenshots

Web

Screen.Recording.2022-11-05.at.1.21.57.AM.mov

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

I'm Unable to run android app in my setup for now.

mountiny

LGTM!

@Santhosh-Sellavel could you please test this out especially on Android as that is what @Tushu17 could not run. Thank you!

Santhosh-Sellavel · 2022-11-07T00:08:47Z

src/languages/en.js

@@ -119,7 +119,7 @@ export default {
        chooseFromGallery: 'Choose from gallery',
        chooseDocument: 'Choose document',
        attachmentTooLarge: 'Attachment too large',
-        sizeExceeded: 'Attachment size is larger than 50 MB limit.',
+        sizeExceeded: 'Attachment size is larger than 24 MB limit.',


Please update the same in es.js too!

@Santhosh-Sellavel Okay done.

Santhosh-Sellavel · 2022-11-07T00:20:34Z

Screenshots

Desktop

Web

Mobile Web Android - Chrome & Mobile Web - Safari

iOS & Android

Santhosh-Sellavel · 2022-11-07T00:21:20Z

PR Reviewer Checklist

The reviewer will copy/paste it into a new comment and complete it after the author checklist is completed

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- iOS / native
- Android / native
- iOS / Safari
- Android / Chrome
- MacOS / Chrome
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product was added in all src/languages/* files
- I verified any copy / text that was added to the app is correct English and approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

mountiny

Thank you guys!

melvin-bot · 2022-11-07T14:29:18Z

@mountiny looks like this was merged without the checklist test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

OSBotify · 2022-11-07T14:34:42Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

mountiny · 2022-11-07T14:57:36Z

Not an emergency, removing the label.

OSBotify · 2022-11-08T19:39:00Z

🚀 Deployed to staging by @mountiny in version: 1.2.25-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2022-11-09T21:14:02Z

🚀 Deployed to production by @yuwenmemon in version: 1.2.25-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

Tushu17 added 2 commits November 5, 2022 01:01

decrease attachment MAX_SIZE

c3b6794

fix attachment error message

0dacefe

Tushu17 requested a review from a team as a code owner November 5, 2022 20:03

melvin-bot bot requested review from mountiny and Santhosh-Sellavel and removed request for a team November 5, 2022 20:03

mountiny reviewed Nov 6, 2022

View reviewed changes

Santhosh-Sellavel suggested changes Nov 7, 2022

View reviewed changes

fix attchment error message

cf26861

mountiny approved these changes Nov 7, 2022

View reviewed changes

mountiny merged commit c020314 into Expensify:main Nov 7, 2022

melvin-bot bot added the Emergency label Nov 7, 2022

mountiny removed the Emergency label Nov 7, 2022

OSBotify mentioned this pull request Nov 8, 2022

Deploy Checklist: New Expensify 2022-11-08 #12563

Closed

34 tasks

melvin-bot bot mentioned this pull request Nov 9, 2022

[HOLD for payment 2022-11-16] [$250] [Image] Cant Share attachments between 40-49 mb - reported by @Tushu17 #8235

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Decrease attachment size limit #12497

Decrease attachment size limit #12497

Tushu17 commented Nov 5, 2022

mountiny left a comment

Santhosh-Sellavel Nov 7, 2022

Tushu17 Nov 7, 2022

Santhosh-Sellavel commented Nov 7, 2022

Desktop

Web

Mobile Web Android - Chrome & Mobile Web - Safari

iOS & Android

Santhosh-Sellavel commented Nov 7, 2022 •

edited

Loading

PR Reviewer Checklist

mountiny left a comment

melvin-bot bot commented Nov 7, 2022

OSBotify commented Nov 7, 2022

mountiny commented Nov 7, 2022

OSBotify commented Nov 8, 2022

OSBotify commented Nov 9, 2022

Decrease attachment size limit #12497

Decrease attachment size limit #12497

Conversation

Tushu17 commented Nov 5, 2022

Details

Fixed Issues

Tests

QA Steps

PR Author Checklist

PR Reviewer Checklist

Screenshots

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

mountiny left a comment

Choose a reason for hiding this comment

Santhosh-Sellavel Nov 7, 2022

Choose a reason for hiding this comment

Tushu17 Nov 7, 2022

Choose a reason for hiding this comment

Santhosh-Sellavel commented Nov 7, 2022

Screenshots

Desktop

Web

Mobile Web Android - Chrome & Mobile Web - Safari

iOS & Android

Santhosh-Sellavel commented Nov 7, 2022 • edited Loading

PR Reviewer Checklist

mountiny left a comment

Choose a reason for hiding this comment

melvin-bot bot commented Nov 7, 2022

OSBotify commented Nov 7, 2022

mountiny commented Nov 7, 2022

OSBotify commented Nov 8, 2022

OSBotify commented Nov 9, 2022

Santhosh-Sellavel commented Nov 7, 2022 •

edited

Loading