Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pasting in link to report navigates to the LHN on small screen mobile-web devices #12597

Closed
kavimuru opened this issue Nov 9, 2022 · 9 comments
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering

Comments

@kavimuru
Copy link

kavimuru commented Nov 9, 2022

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Open the app on mobile web on a device with a small screen.
  2. Paste in the URL to any report.
  3. It navigates you to the LHN instead.

Expected Result:

The system should redirected you to the chat

Actual Result:

System redirected you to LHN

Workaround:

unknown

Platform:

Where is this issue occurring?

  • iOS
  • Android
  • Mobile Web

Version Number: 1.2.25-0
Reproducible in staging?: y
Reproducible in production?: y
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:

RPReplay_Final1669221625.MP4

Expensify/Expensify Issue URL:
Issue reported by: Applause internal team
Slack conversation:

View all open jobs on GitHub

@kavimuru kavimuru added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Nov 9, 2022
@melvin-bot
Copy link

melvin-bot bot commented Nov 9, 2022

Triggered auto assignment to @zanyrenney (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@zanyrenney
Copy link
Contributor

Will check this out tomorrow.

@melvin-bot melvin-bot bot removed the Overdue label Nov 14, 2022
@zanyrenney
Copy link
Contributor

I don't understand this bug or the reproduction steps, please can you rephrase them or explain in more detail? To me, this looks like it is working as expected. @kavimuru

@melvin-bot melvin-bot bot added the Overdue label Nov 18, 2022
@zanyrenney
Copy link
Contributor

bump @kavimuru

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Nov 18, 2022
@zanyrenney
Copy link
Contributor

bumping @kavimuru

@melvin-bot melvin-bot bot removed the Overdue label Nov 21, 2022
@kavimuru
Copy link
Author

kavimuru commented Nov 22, 2022

@zanyrenney Sorry for the late reply. This is failure of the PR #12169

New message marker set correctly when navigating to directly to unread chat

  1. Open two sessions one as User A and one as User B
  2. Make sure User B is navigate to the chat with User A and save the URL
  3. Close User B tab (or kill app)
  4. Create message as User A on chat with User B and wait 10 seconds
  5. Open tab (or app) as User B using the URL saved from the second step (on native use a deep link)
  6. See that new marker is set correctly
  7. Verify that the chat in the LHN is marked as read

Step 5 is failing in this part

@zanyrenney
Copy link
Contributor

No worriesm, thanks for letting me know! I'll try to reproduce tomorrow.

@jasperhuangg
Copy link
Contributor

jasperhuangg commented Nov 23, 2022

Hey hey happy to help out here, I was able to reproduce. You actually don't need to do all those steps:

  1. Open the app on mobile web on a device with a small screen.
  2. Paste in the URL to any report.
  3. It navigates you to the LHN instead.
RPReplay_Final1669221625.MP4

@jasperhuangg jasperhuangg changed the title Chat - System redirected you to LHN, NOT to the chat [M-Web] Pasting in link to report navigates to the LHN on small screens Nov 23, 2022
@jasperhuangg jasperhuangg changed the title [M-Web] Pasting in link to report navigates to the LHN on small screens Pasting in link to report navigates to the LHN on small screen mobile-web Nov 23, 2022
@jasperhuangg jasperhuangg changed the title Pasting in link to report navigates to the LHN on small screen mobile-web Pasting in link to report navigates to the LHN on small screen mobile-web devices Nov 23, 2022
@marcaaron
Copy link
Contributor

This is a functional dupe of #8126 so gonna close it out.

@marcaaron marcaaron closed this as not planned Won't fix, can't repro, duplicate, stale Nov 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering
Projects
None yet
Development

No branches or pull requests

4 participants