[$250] Android narrow/low pixel tablets - Chat - The FAB button disappears or is covered by the keyboard in horizontal

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Issue found when executing PR #12345

Action Performed:

1. Open the App
2. Login with any account
3. Go to any chat room
4. Go to horizontal mode
5. Focus on composer input to show keyboard

Expected Result:

The FAB button shouldn't floats to the top and sticks above the keyboard

Actual Result:

The FAB button disappears or is covered by the keyboard

Workaround:

Unknown

Platform:

Where is this issue occurring?

• Android -model Xiaomi Mi Pad - Android 8.1

Version Number: 1.2.25.0

Reproducible in staging?: Yes

Reproducible in production?: Yes

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug5813586_12345_Android.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal team

Slack conversation:

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @jliexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[jliexpensify]

Reassigning to Kadie as I'm about to head OOO

[kadiealexander]

Asking for someone with an iPad to reproduce - https://expensify.slack.com/archives/C01GTK53T8Q/p1668402566426039

[kadiealexander]

Reproduced here: https://expensify.slack.com/archives/C01GTK53T8Q/p1668409849644459?thread_ts=1668402566.426039&cid=C01GTK53T8Q

[melvin-bot]

Current assignee @kadiealexander is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @mananjadhav (External)

[melvin-bot]

Triggered auto assignment to @iwiznia (External), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[kadiealexander]

https://www.upwork.com/ab/applicants/1592776010907643904/job-details
https://www.upwork.com/jobs/~015b48fd1ba383cdca

[puneetlath]

@iwiznia this is one of the oldest issues in the /App repo. To help us clear out the large backlog of bugs, can you:

• Decide whether any proposals currently meet our guidelines and can be approved as-is
• For any that can't, please take this issue internal and treat it as one of your highest priorities
• If you have any questions, don't hesitate to start a discussion in #bug-zero

[Julesssss]

I think this is a good example of why we should simply block rotation on native and review once we've actually reached reunification.

[iwiznia]

I agree.

[JmillsExpensify]

@Julesssss @iwiznia Do we want to disable rotation on native in this issue? I was going to close based on our discussion in the community, but we can also use this issue to prevent rotation bugs by disabling this action.

[iwiznia]

Yeah, I think that makes sense.

[Julesssss]

Do we want to disable rotation on native in this issue?

We disabled rotation years ago. I don't think we need to make any changes

[iwiznia]

I am confused, then how did @kbecciv reproduced this if rotation is disabled?

[Julesssss]

Ah, this is how. We lock rotation for small devices and unlock it for tablets:

[Julesssss]

So I take that back, we unlocked rotation for tablets at some point.

[iwiznia]

I have a PR here #13043
But while testing, I realized that I can't really reproduce this issue on neither of the 2 ipad emulators I tried (ipad mini and ipad pro) and neither on the android emulator tablet (Pixel C).
The reason is that all of them seem to always show the big screen view (ie the one with LHN and main pane), so while my PR could make it that they don't rotate, that would mean a worse UX for the user.
My guess is this is only reproducible on tablets with a narrow form factor or less pixel density.
So the question is: do we still want to lock tablets to portrait mode? I think the answer is no and we rather have this small bug on old tablets than preventing users from rotating their tablets (which for lots of users will work fine).

If you agree, let's close this.

[JmillsExpensify]

Assigning myself as well since we lost the BZ assignment somehow. Also chiming in on @iwiznia's question above.

My guess is this is only reproducible on tablets with a narrow form factor or less pixel density.
So the question is: do we still want to lock tablets to portrait mode? I think the answer is no and we rather have this small bug on old tablets than preventing users from rotating their tablets (which for lots of users will work fine).

Hmm, yeah I'm with you. I tried to reproduce this on my iPad mini and I wasn't able to. So I think I'm with you, we should close this. In fact, I'll do that but ahead of doing so I will update the title to remove iPad for clarity.

[iwiznia]

To clarify, it's reproducible on older/smaller ipads.

[0xmiros]

This is still reproducible in latest version of android. So I suggest to reopen this issue and put on hold until #13106 is merged

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[JmillsExpensify]

@0xmiroslav for clarity, is it reproducible on non-tablets or just tablets? Reason being, we don't officially support tablets, though I'm more than happy to re-open if you think it's going to be fixed anyway.

[0xmiros]

This happens on android tablets with small size as explained in issue title

[JmillsExpensify]

Ok yeah, so all those are unsupported devices. In the interest of focus, let's just keep this closed. We need to tackle tablet support one day, but now isn't the time.

[mananjadhav]

I agree with @JmillsExpensify. We're focused on items such as BugZero, WAQ, and Dark theme, etc. Tablets isn't the focus right now, and I think we should tackle tablets sometime in future.