remove extra spaces on attachment modal #12130

aimane-chnaif · 2022-10-25T20:38:36Z

Details

After final design agreement here, we need to apply conditional marginTop, marginBottom in modal per devices, along with paddings.

Platform	isSmallScreenWidth	margin:20	topSafeAreaMargin	bottomSafeAreaMargin	topSafeAreaPadding	bottomSafeAreaPadding
iPhone	Yes	❌	❌	❌	✅	❌
Android	Yes	❌	❌	❌	❌	❌
iPad	No	✅	✅	✅	❌	❌
Tablet	No	✅	❌	❌	❌	❌
Web/Desktop	No	✅	❌	❌	❌	❌

Fixed Issues

$ #10352
PROPOSAL: #10352 (comment)

Tests

Login with any account
Send or receive any attachment in any chat
View attachment detail
Verify that no extra space is added above and below attachment

Verify that no errors appear in the JS console

QA Steps

Login with any account
Send or receive any attachment in any chat
View attachment detail
Verify that no extra space is added above and below attachment

Verify that no errors appear in the JS console

PR Review Checklist

PR Author Checklist

PR Reviewer Checklist

The reviewer will copy/paste it into a new comment and complete it after the author checklist is completed

Screenshots

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

mananjadhav · 2022-10-27T23:43:58Z

@shawnborton Can you help here verify the screenshots and the table for the expected behavior (in the PR body)?

shawnborton · 2022-10-27T23:52:49Z

This looks good to me!

Minor thing - I noticed on mobile web Safari that the top area above the modal header isn't white... I don't think that's related to anything we're doing here but probably something we should fix at some point, if possible?

aimane-chnaif · 2022-10-28T03:18:13Z

Minor thing - I noticed on mobile web Safari that the top area above the modal header isn't white... I don't think that's related to anything we're doing here but probably something we should fix at some point, if possible?

I think that top safearea background is handled in safari browser so it's out of our app scope

mananjadhav · 2022-10-31T03:12:09Z

@aimane-chnaif the changes look fine, can you resolve the conflicts and update? So that I can start with the testing?

Also one more thing, it'll be great to add iPad screenshots for this one.

…o fix-10352

aimane-chnaif · 2022-10-31T05:58:55Z

@mananjadhav fixed conflicts

Also one more thing, it'll be great to add iPad screenshots for this one.

You mean login page on which conflict happened?

mananjadhav · 2022-10-31T13:10:17Z

No. I mean iPad screenshot for attachment padding. If you've already uploaded then can you tag them accordingly?

aimane-chnaif · 2022-10-31T15:24:18Z

No. I mean iPad screenshot for attachment padding. If you've already uploaded then can you tag them accordingly?

I already uploaded in iOS section. I attached both iPhone and iPad screenshots, also both android phone and tablet

mananjadhav · 2022-11-07T04:39:08Z

Changes look fine and I was able to test different (small/high, wide/long images), etc. on different platforms.

@Gonals @shawnborton All yours.

🎀 👀 🎀
C+ reviewed

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- iOS / native
- Android / native
- iOS / Safari
- Android / Chrome
- MacOS / Chrome
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product was added in all src/languages/* files
- I verified any copy / text that was added to the app is correct English and approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.