Fix: On add Paypal page, the add Paypal button isn't working correctly #12197

Puneet-here · 2022-10-27T16:41:57Z

Details

#12049 (comment)

Fixed Issues

$ #12049
PROPOSAL: #12049 (comment)

Tests

Go to settings > payments
Click on add payment method button
Choose paypal.me
Focus at paypal.me input and add a space
Verify the button doesn't get enabled

Verify that no errors appear in the JS console

QA Steps

Go to settings > payments
Click on add payment method button
Choose paypal.me
Focus at paypal.me input and add a space
Verify the button doesn't get enabled

Verify that no errors appear in the JS console

PR Review Checklist

PR Author Checklist

PR Reviewer Checklist

The reviewer will copy/paste it into a new comment and complete it after the author checklist is completed

Screenshots

Web

Screen.Recording.2022-10-27.at.9.30.01.PM.mov

Mobile Web - Chrome

Screen.Recording.2022-10-27.at.10.09.36.PM.mov

Mobile Web - Safari

Screen.Recording.2022-10-27.at.9.39.12.PM.mov

Desktop

Screen.Recording.2022-10-27.at.9.58.25.PM.mov

iOS

Screen.Recording.2022-10-27.at.9.43.13.PM.mov

Android

Screen.Recording.2022-10-27.at.9.47.28.PM.mov

Santhosh-Sellavel

Can we remove the un used code here related to editing PayPal as the flow no longer exists?

@pecanoro What do you think?

src/pages/settings/Payments/AddPayPalMePage.js

Puneet-here · 2022-11-02T19:19:11Z

Updated!

Santhosh-Sellavel · 2022-11-02T20:04:22Z

src/pages/settings/Payments/AddPayPalMePage.js

@@ -36,7 +36,7 @@ class AddPayPalMePage extends React.Component {
        super(props);

        this.state = {
-            payPalMeUsername: props.payPalMeData.description,
+            payPalMeUsername: props.payPalMeData.description || '',


Why do we need props.payPalMeData.description, please clean up other unnecessary codes.

Santhosh-Sellavel · 2022-11-04T16:40:08Z

ScreenRecordings

#### Web & Desktop https://user-images.githubusercontent.com/85645967/200027918-1b418d2a-4773-401e-a074-5fff5f4c2a01.mov

Mobile Web - Chrome && Mobile Web - Safari

Screen.Recording.2022-11-04.at.10.00.57.PM.mov

iOS &Android

Screen.Recording.2022-11-04.at.9.57.28.PM.mov

PR Reviewer Checklist

C+ Reviewed
🎀 👀 🎀
The reviewer will copy/paste it into a new comment and complete it after the author checklist is completed

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- iOS / native
- Android / native
- iOS / Safari
- Android / Chrome
- MacOS / Chrome
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product was added in all src/languages/* files
- I verified any copy / text that was added to the app is correct English and approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Santhosh-Sellavel

Looks good & tests well!

OSBotify · 2022-11-08T16:00:07Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2022-11-08T19:38:12Z

🚀 Deployed to staging by @pecanoro in version: 1.2.25-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2022-11-09T21:13:14Z

🚀 Deployed to production by @yuwenmemon in version: 1.2.25-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

parasharrajat · 2023-02-10T19:58:50Z

src/pages/settings/Payments/AddPayPalMePage.js

                    />
                </FixedFooter>
            </ScreenWrapper>
        );
    }
 }

-AddPayPalMePage.propTypes = propTypes;
-AddPayPalMePage.defaultProps = defaultProps;
+AddPayPalMePage.propTypes = {...withLocalizePropTypes};


PropTypes should be defined at the top of the file. cc: @Santhosh-Sellavel

We don't have any additional PropTypes to define, so this makes more sense.

But still, this is an object literal ( a new object is being created). Following the pattern of existing components, it is better to define these at the top.

i.e There is nothing to define. withLocalizePropTypes is already defined and imported, Defining it again is redundant so it seemed fine to me.

Also, I checked whether we had such a definition in existing components. I saw we defined it in the following way if there are no other additional props i.e in TermsAndLicenses and UnreadActionIndicator.

So I was okay with it.

@pecanoro Any thoughts though?

Ok. I still think that we should move any prop definition to the top of the file even if we are spreading properties from other objects.

But it fine too.

I don't think there are guidelines for this exactly so it's fine either way. If any of you feel passionate about it, it would be good to bring it up on Slack.

Puneet-here requested a review from a team as a code owner October 27, 2022 16:41

melvin-bot bot requested review from pecanoro and Santhosh-Sellavel and removed request for a team October 27, 2022 16:42

Puneet-here added 2 commits October 27, 2022 20:58

disable button if the paypal username is empty

81ff0de

import underscore

3f65fdb

Santhosh-Sellavel reviewed Oct 31, 2022

View reviewed changes

src/pages/settings/Payments/AddPayPalMePage.js Outdated Show resolved Hide resolved

Santhosh-Sellavel suggested changes Nov 2, 2022

View reviewed changes

Puneet-here added 3 commits November 3, 2022 00:44

remove update paypal logic

1c7761a

remove update paypal copy

0cfd2ab

remove payPalMeData

3f07a55

Santhosh-Sellavel approved these changes Nov 4, 2022

View reviewed changes

pecanoro approved these changes Nov 8, 2022

View reviewed changes

pecanoro merged commit cb93661 into Expensify:main Nov 8, 2022

OSBotify mentioned this pull request Nov 8, 2022

Deploy Checklist: New Expensify 2022-11-08 #12563

Closed

34 tasks

melvin-bot bot mentioned this pull request Nov 9, 2022

[HOLD for payment 2022-11-16] [$250] Bug: [Staging] On add Paypal page, the add Paypal button isn't working correctly reported by @Tushu17 #12049

Closed

5 tasks

parasharrajat reviewed Feb 10, 2023

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix: On add Paypal page, the add Paypal button isn't working correctly #12197

Fix: On add Paypal page, the add Paypal button isn't working correctly #12197

Puneet-here commented Oct 27, 2022

Santhosh-Sellavel left a comment

Puneet-here commented Nov 2, 2022

Santhosh-Sellavel Nov 2, 2022

Santhosh-Sellavel commented Nov 4, 2022 •

edited

Loading

ScreenRecordings

Mobile Web - Chrome && Mobile Web - Safari

iOS &Android

PR Reviewer Checklist

Santhosh-Sellavel left a comment

OSBotify commented Nov 8, 2022

OSBotify commented Nov 8, 2022

OSBotify commented Nov 9, 2022

parasharrajat Feb 10, 2023

Santhosh-Sellavel Feb 10, 2023 •

edited

Loading

parasharrajat Feb 10, 2023

Santhosh-Sellavel Feb 10, 2023

parasharrajat Feb 10, 2023

pecanoro Feb 10, 2023

Fix: On add Paypal page, the add Paypal button isn't working correctly #12197

Fix: On add Paypal page, the add Paypal button isn't working correctly #12197

Conversation

Puneet-here commented Oct 27, 2022

Details

Fixed Issues

Tests

QA Steps

PR Review Checklist

PR Author Checklist

PR Reviewer Checklist

Screenshots

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

Santhosh-Sellavel left a comment

Choose a reason for hiding this comment

Puneet-here commented Nov 2, 2022

Santhosh-Sellavel Nov 2, 2022

Choose a reason for hiding this comment

Santhosh-Sellavel commented Nov 4, 2022 • edited Loading

ScreenRecordings

Mobile Web - Chrome && Mobile Web - Safari

iOS &Android

PR Reviewer Checklist

Santhosh-Sellavel left a comment

Choose a reason for hiding this comment

OSBotify commented Nov 8, 2022

OSBotify commented Nov 8, 2022

OSBotify commented Nov 9, 2022

parasharrajat Feb 10, 2023

Choose a reason for hiding this comment

Santhosh-Sellavel Feb 10, 2023 • edited Loading

Choose a reason for hiding this comment

parasharrajat Feb 10, 2023

Choose a reason for hiding this comment

Santhosh-Sellavel Feb 10, 2023

Choose a reason for hiding this comment

parasharrajat Feb 10, 2023

Choose a reason for hiding this comment

pecanoro Feb 10, 2023

Choose a reason for hiding this comment

Santhosh-Sellavel commented Nov 4, 2022 •

edited

Loading

Santhosh-Sellavel Feb 10, 2023 •

edited

Loading