Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Connect Bank Account - Endless loading is shown when navigate to Connect Bank Account #12670

Closed
kbecciv opened this issue Nov 11, 2022 · 38 comments
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering

Comments

@kbecciv
Copy link

kbecciv commented Nov 11, 2022

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Issue was found when executing PR #12634

Action Performed:

Precondition: Add VBA in Web for your testing account

  1. Launch the app
  2. Log in with your testing account
  3. Navigate to Setting - Workspace - Workspaces
  4. Tap Connect Bank Account

Expected Result:

Able to see message "You're all set!" under Connect Bank Account Page

Actual Result:

Endless loading is shown when navigate to Connect Bank Account

Workaround:

Unknown

Platform:

Where is this issue occurring?

  • iOS
  • Android

Version Number: 1.2.27.0

Reproducible in staging?: Yes

Reproducible in production?: No

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

RPReplay_Final1668182051.MP4
Screen_Recording_20221111-102704_New.Expensify.1.1.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

@kbecciv kbecciv added the DeployBlockerCash This issue or pull request should block deployment label Nov 11, 2022
@kbecciv
Copy link
Author

kbecciv commented Nov 11, 2022

Checked in IOS production app and works fine, evidence attached

RPReplay_Final1668183030.MP4

@OSBotify
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@melvin-bot
Copy link

melvin-bot bot commented Nov 11, 2022

Triggered auto assignment to @Luke9389 (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@Luke9389
Copy link
Contributor

Investigating now.

@Luke9389
Copy link
Contributor

The main branch did not have this problem at noon yesterday. Looking at the PRs merged since then....

@ctkochan22
Copy link
Contributor

it may also be this PR? #11751

@ctkochan22
Copy link
Contributor

@kbecciv Which accounts were you using?

@Luke9389
Copy link
Contributor

I'm also unable to reproduce on iOS dev.

@Luke9389 Luke9389 removed the DeployBlockerCash This issue or pull request should block deployment label Nov 12, 2022
@Luke9389
Copy link
Contributor

Going to demote this until we can get more reliable reproduction steps.

@Luke9389 Luke9389 removed the Hourly KSv2 label Nov 12, 2022
@kbecciv
Copy link
Author

kbecciv commented Nov 12, 2022

@Luke9389
I used account: applausetester+1107abb1@applause.expensifail.com.
Reproduction steps:

  1. Go to staging.new.expensify.com on Web
  2. Go to Settings - Workspace
  3. Select Connect Bank account
  4. Select Plaid option
  5. Select Fidelity option
  6. Use credentials: user_good/pass_good
  7. Select Saving account -1111
  8. Use necessary information for Alberta Bobbeth Charleson (please ask if you don't have)
  9. Finish to sets up the VBA
  10. Go to IOS/Andriod app with the same account
  11. Go Settings - Workspace -Connect Bank Account

@iwiznia iwiznia added the DeployBlockerCash This issue or pull request should block deployment label Nov 14, 2022
@iwiznia
Copy link
Contributor

iwiznia commented Nov 14, 2022

I assume this must be broken because applause can reproduce and also is failing in another PR

@github-actions github-actions bot added the Hourly KSv2 label Nov 14, 2022
@OSBotify
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@melvin-bot melvin-bot bot added the Overdue label Nov 14, 2022
@ctkochan22
Copy link
Contributor

@kbecciv Can we get the password?

@kbecciv
Copy link
Author

kbecciv commented Nov 14, 2022

@Luke9389
Copy link
Contributor

Thanks for providing more detail on the reproduction steps @kbecciv

@melvin-bot melvin-bot bot removed the Overdue label Nov 14, 2022
@Luke9389
Copy link
Contributor

I'm blocked on this because I'm unable to skip the Onfido step on dev (not staging). @roryabraham @yuwenmemon

@Luke9389
Copy link
Contributor

Hmm, I'm now experiencing the infinite spinner just after following the SO steps here (to create an OPEN bank account).

@Luke9389
Copy link
Contributor

@kbecciv can you start with a fresh account and see if you get the same thing?

I did this:
3. To create an OPEN bank account (this state means the bank account is ready for reimbursement):

  • Add Bank Account (On new dot enable Settings > Preferences > Use Secure staging server to hit our staging secure sandbox):

    • Click "Log into your bank"

    • Plaid modal - Choose Wells Fargo (use Bank of America if Wells Fargo is not available)

    • Plaid modal - User Id: user_good

    • Plaid modal - Password: pass_good

    • Plaid modal - Submit

    • Plaid modal - If they request a verification code via mobile sms, enter: credential_good when required

    • Choose an account: Plaid Saving11122XXXXXX111

    • Save & Continue

  • Company Information (Enter anything unless specified):

    • Legal Business Name: Alberta Bobbeth Charleson

    • Company website: Enter any valid formatted website

    • Tax ID number: 123456789 (any nine digits)

    • Industry classification code: 123456 (any six digits)

    • Confirm company is not on list of restricted businesses

  • Requestor Information (Enter anything unless specified)

    • First name: Alberta

    • Second name: Charleson

    • Toggle confirmation you are authorized to use company bank account

    • Save & Continue (Note: You will receive an error asking to "Please verify you name and date of birth". Hit "Save & Continue" again without changing any inputs.)

  • Onfido (skipped)

  • Beneficial Owners

    • Toggle terms and conditions

    • Toggle confirmation that the information provided is true and accurate

Once the modal closes, you're back at New Dot with an infinite loading spinner.

If this is happening for you too, then I think we should change this to say it's effecting all platforms (not just iOS).

@Luke9389
Copy link
Contributor

Hmm, OK so it looks like the web spinner is happening when you add a VBA that you already have. This screenshot is from an earlier branch that doesn't have the spinner problem (so we can see the error). If you add a VBA successfully (say, on a totally new account, this doesn't happen).
Screen Shot 2022-11-14 at 2 45 56 PM

@Luke9389
Copy link
Contributor

@kbecciv, when you set up the bank account, are you getting this at the end?
Screen Shot 2022-11-14 at 3 32 41 PM

@Luke9389
Copy link
Contributor

I was able to use different data to get passed the above screen, but now I'm stuck on this one (I've added a validated secondary login, and this still shows up).

Screen Shot 2022-11-14 at 4 02 15 PM

@Luke9389
Copy link
Contributor

Luke9389 commented Nov 15, 2022

When I run iOS, I also get the above screen. So far, I've not been able to reproduce this locally as described in the description. I haven't seen a single infinite spinner on iOS just yet.

@ctkochan22
Copy link
Contributor

  • Logs
    • Not much in the logs - Logs of App - Logs of Auth request
    • Free plan verified bank account found -- 1781402 but nothing else to indicate an infinite spinner specific to iOS
  • Logging in and testing with applause tester's account.
    • Reproducable only on iOS

@kbecciv
Copy link
Author

kbecciv commented Nov 15, 2022

@Luke9389 Good day! What would you like me to check?

@ctkochan22
Copy link
Contributor

ctkochan22 commented Nov 15, 2022

@kbecciv Can you try again?

I was able to reproduce on your account earlier, but I am no longer able to.

@ctkochan22
Copy link
Contributor

That's so strange that its no longer reproducible. Maybe it was fixed by a recent deploy. However, I've logged into the account and was not able to reproduce.

@roryabraham
Copy link
Contributor

Since this is no longer reproducible, I'm going to demote it from deploy blocker to regular bug.

@roryabraham roryabraham added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. and removed DeployBlockerCash This issue or pull request should block deployment Hourly KSv2 labels Nov 15, 2022
@melvin-bot
Copy link

melvin-bot bot commented Nov 15, 2022

Triggered auto assignment to @JmillsExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@ctkochan22 ctkochan22 self-assigned this Nov 15, 2022
@ctkochan22
Copy link
Contributor

@kbecciv let us know if you can reproduce again. But so fart testing on that account we haven't been able to, where as a day ago we were able to. Going to close for now

@kbecciv
Copy link
Author

kbecciv commented Nov 15, 2022

@Luke9389 I don't have any loading spinner when added VBA in Web/Chrome.

Recording.1704.mp4

@JmillsExpensify
Copy link

Awesome work on this one!

@kbecciv
Copy link
Author

kbecciv commented Nov 25, 2022

Able to reproduced the issue in Android/ IOS apps with version 1.2.31.8

IMG_5343.MOV

@JmillsExpensify
Copy link

@ctkochan22 What do you think? Should we create a fresh issue for this one?

@ctkochan22
Copy link
Contributor

ctkochan22 commented Nov 29, 2022

Yeah lets create a fresh issue.

@kbecciv can you provide your username and password? Or is it the same as before?

@kbecciv
Copy link
Author

kbecciv commented Nov 29, 2022

Kbecciv+1031abb2@gmail.com/Feya86Katya

@JmillsExpensify
Copy link

Alright, new issue created and linked immediately above. I'm closing this issue out.

@ctkochan22
Copy link
Contributor

@kbecciv Can you please answer the follwoing and post in the new issue: #13166 (comment)

  1. Can you reproduce on other accounts? Or is it specific to this one?
  2. What is the username and password of this account?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering
Projects
None yet
Development

No branches or pull requests

7 participants