Deploy Checklist: New Expensify 2022-11-23

[OSBotify]

Release Version: 1.2.31-8
Compare Changes: production...staging

This release contains changes from the following pull requests:

• Workspace Editor Page Design Updates #12419
• Update Button Styles #12455
• [No QA] Update ios files #12570
• Desktop - Add "Check For Update" system menu item #12607
• Update NewDot Logos Nov 2022 #12608
• [Image][Performance] Fast Image with Auth Token Header Caching #12648
• Fix/12515: Default rooms are not grayed out when creating a new workspace while offline #12664
• Update IOU Preview Card Styles #12762
• Refactor requestor step form #12766
• Fix email keyboard type #12827
• Handle escape react native modal #12864
• Fix after requesting money badge in the DM flashes with red 0.00 #12887
• Fix: Cursor moves to end after adding space in Room Name #12899
• Fix multiple options getting selected on SearchPage, NewGroupPage #12906
• Fix flickering name when deleting first message of a group #12907
• Clean up login list migration #12919
• Update expensify-common lib #12925
• fix: #12885 - Homescreen not running at 60 FPS on mobile #12926
• Update README.md for a Internal QA (small typo) #12929
• Added onMouseDown prop to TextLink component, fixed issue of not able to open link with one click in BankAccountManualStep component #12940
• display translated error if the room name already exists #12953
• Add ROLE constants 'user' and 'auditor' #12956
• [No QA] Fix small button padding #12959
• Revert "Merge pull request #12648 from margelo/@thomas/fast-image-cac… #13010
• Revert "refactor navigation modal card styles" #13014
• Only navigate to chat reports #13028

Internal QA:

• [Internal QA] Fix the way the reviewer checklist is found #12936 - @tgolen @NikkiWines

Deploy Blockers:

• IOU - "Cancel" button is not fully visible in Detail Page/some buttons in Preferences Page is cut off #12981
• Chat - Direction icons are not in the same level  #12982
• IOU - Settled payments are showing with infinite loading, looks normal after opened. #12999
• [HOLD for payment 2022-12-05] Empty chat screen appears with welcome message after login #13000
• [$1000] [HOLD for payment 2022-12-05] Android - Attachments - PDF file is disappeared in the chat after sent it #13002
• [HOLD for payment 2022-12-05] [Performance] Mweb/safari - User can't tap participants in split bill on High Traffic Account. #13008
• [HOLD for payment 2022-12-05] mWeb- The Payment option is hidden after selecting one of the payment option #13009
• [HOLD for payment 2022-12-05] mWeb/Chrome - Split - Next button is missing when you split bill with participants #13011
• Web - Login - The empty welcome page + error in console after login #13025

Deployer verifications:

• I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
• I checked Firebase Crashlytics and verified that this release does not introduce any new crashes.

cc @Expensify/applauseleads

[OSBotify]

👏 Heads up @Expensify/applauseleads 👏
A new pull request has been 🍒 cherry-picked 🍒 to staging, and will be deployed to staging in version 1.2.31-3 🚀

[OSBotify]

🎉 All set?…You bet! @Expensify/applauseleads https://github.com/Expensify/App/releases/tag/1.2.31-3 has been deployed to staging 🎉

[OSBotify]

🚀 All staging deploys are complete, @Expensify/applauseleads please begin QA on version https://github.com/Expensify/App/releases/tag/1.2.31-3 🚀

[luacmartins]

#13011 is reproducible on prod, so I'm removing the blocker label

[aldo-expensify]

#13008 is reproducible in prod, removed the blocker label

[OSBotify]

👏 Heads up @Expensify/applauseleads 👏
A new pull request has been 🍒 cherry-picked 🍒 to staging, and will be deployed to staging in version 1.2.31-6 🚀

[OSBotify]

🎉 All set?…You bet! @Expensify/applauseleads https://github.com/Expensify/App/releases/tag/1.2.31-6 has been deployed to staging 🎉

[OSBotify]

👏 Heads up @Expensify/applauseleads 👏
A new pull request has been 🍒 cherry-picked 🍒 to staging, and will be deployed to staging in version 1.2.31-7 🚀

[OSBotify]

🎉 All set?…You bet! @Expensify/applauseleads https://github.com/Expensify/App/releases/tag/1.2.31-7 has been deployed to staging 🎉

[OSBotify]

👏 Heads up @Expensify/applauseleads 👏
A new pull request has been 🍒 cherry-picked 🍒 to staging, and will be deployed to staging in version 1.2.31-8 🚀

[luacmartins]

#12936 is a pass. Checking off.

[OSBotify]

🎉 All set?…You bet! @Expensify/applauseleads https://github.com/Expensify/App/releases/tag/1.2.31-8 has been deployed to staging 🎉

[Julesssss]

I removed #12999 as a deploy blocker as three people are unable to reproduce.

[luacmartins]

@mvtglobally what's the regression tests status?

[mvtglobally]

@luacmartins we are wrapping up. I'll should be able to share summary in the next hour or so

[mvtglobally]

@luacmartins Regression is completed

PR #12762 is failing #13017 Repro in PROD
PR #12919 is failing #13000. blocker is fixed. we are retesting
need help here #12607 (comment)
PR #12419. "Design 6 could not be tested without valid amounts when connecting VBA manually KI #12670" All buttons/links work as expected. Let me know if its ok to check it off
We are checking few last CPs. I will have update in a bit.

[luacmartins]

• Update IOU Preview Card Styles #12762 is a pass to me. I couldn't repro IOU - infinite loading is displayed when select Pay as "I'll settle up elsewhere" #13017
• Desktop - Add "Check For Update" system menu item #12607 is a pass! Checking off!
• Workspace Editor Page Design Updates #12419 I think it's safe to check this one off.

Waiting on the CP updates and the retest of #12919!

[luacmartins]

@mvtglobally any update on the CP checks?

[mvtglobally]

@luacmartins All checked off.

#12919 Steps are pass, but there is an error in the console after refresh. Can you just double check its ok.

Recording.1781.1.mp4

[luacmartins]

@mvtglobally it seems to be the same error as in #12943 and seems unrelated to the changes in that PR, so I think it's safe to check off. Thanks for checking!

[luacmartins]

I see a new crash on iOS which seems to be a memory management issue with the OS. Considering that we only had one crash, and no actionable steps to fix this, I'll go ahead with the deploy.

[luacmartins]