Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IOU - "Cancel" button is not fully visible in Detail Page/some buttons in Preferences Page is cut off #12981

Closed
kbecciv opened this issue Nov 24, 2022 · 8 comments
Assignees
Labels
DeployBlockerCash This issue or pull request should block deployment Engineering Hourly KSv2

Comments

@kbecciv
Copy link

kbecciv commented Nov 24, 2022

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Launch the app
  2. Log in with any account
  3. Tap on Fub menu
  4. Select Request Money
  5. Put amount and Select the user
  6. Tap Request the money
  7. Open Request Detail
  8. Search for the Cancel button

Expected Result:

All buttons should be fully visible

Actual Result:

"Cancel" button is not fully visible in Detail Page/some buttons in Preferences Page is cut off

Workaround:

Unknown

Platform:

Where is this issue occurring?

  • iOS
  • Android

Version Number: 1.2.31.1

Reproducible in staging?: Yes

Reproducible in production?: No

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

@kbecciv kbecciv added the DeployBlockerCash This issue or pull request should block deployment label Nov 24, 2022
@OSBotify
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@melvin-bot
Copy link

melvin-bot bot commented Nov 24, 2022

Triggered auto assignment to @robertjchen (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@0xmiros
Copy link
Contributor

0xmiros commented Nov 24, 2022

@kbecciv it's duplicated with #12958

@kbecciv
Copy link
Author

kbecciv commented Nov 24, 2022

@0xmiroslav This issue is not reproduced in Production.

IMG_5316 (1)

@0xmiros
Copy link
Contributor

0xmiros commented Nov 24, 2022

@kbecciv to be clear:
This bug was introduced in v1.2.31-0
Current staging version is v1.2.31-1
Current production version is v1.2.30-0

@grgia
Copy link
Contributor

grgia commented Nov 24, 2022

Should be fixed with #12959

@robertjchen
Copy link
Contributor

PR merged, re-testing as soon as it gets to staging

@robertjchen
Copy link
Contributor

Appears to be resolved on staging? 🤔

Screenshot 2022-11-24 at 8 35 47 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DeployBlockerCash This issue or pull request should block deployment Engineering Hourly KSv2
Projects
None yet
Development

No branches or pull requests

5 participants