Added onMouseDown prop to TextLink component, fixed issue of not able to open link with one click in BankAccountManualStep component #12940

Delgee · 2022-11-22T19:23:18Z

Details

Fixed Issues

$ #12715
PROPOSAL: #12715 (comment)

Tests

Open workspace settings page
Click on Connect Bank Account menu
Confirm input is focused (it have to be clean and no errors shown, if error text is already showing retry from step 2)
Without losing focus click on Expensify Terms of Service link
Verify link is opened

Verify that no errors appear in the JS console

Offline tests

QA Steps

Open workspace settings page
Click on Connect Bank Account menu
Confirm input is focused (it have to be clean and no errors shown, if error text is already showing retry from step 2)
Without losing focus click on Expensify Terms of Service link
Verify link is opened

Verify that no errors appear in the JS console

PR Author Checklist

PR Reviewer Checklist

The reviewer will copy/paste it into a new comment and complete it after the author checklist is completed

Screenshots

Web

mac.chrome.mov

Mobile Web - Chrome

mobile.chrome.mov

Mobile Web - Safari

mobile.safari.mov

Desktop

desktop.mov

iOS

ios.mov

Android

android.mov

melvin-bot · 2022-11-22T19:23:25Z

@Gonals @mollfpr One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

mollfpr · 2022-11-23T10:36:27Z

src/pages/ReimbursementAccount/BankAccountManualStep.js

@@ -116,7 +116,7 @@ class BankAccountManualStep extends React.Component {
                                <Text>
                                    {this.props.translate('common.iAcceptThe')}
                                </Text>
-                                <TextLink href="https://use.expensify.com/terms">
+                                <TextLink href="https://use.expensify.com/terms" onMouseDown={e => e.preventDefault()}>


Let's add a comment on why we adding this line and what the issue is.

mollfpr · 2022-11-23T10:46:43Z

src/components/TextLink.js

@@ -22,20 +22,22 @@ const propTypes = {

    /** Overwrites the default link behavior with a custom callback */
    onPress: PropTypes.func,
+    onMouseDown: PropTypes.func,


We should add comment for the onMouseDown prop like Callback that is called when mousedown is triggered.

mollfpr · 2022-11-23T10:47:28Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- iOS / native
- Android / native
- iOS / Safari
- Android / Chrome
- MacOS / Chrome
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product was added in all src/languages/* files
- I verified any copy / text that was added to the app is correct English and approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

12940.Web.mov

Mobile Web - Chrome

12940.mWeb.Chrome.mov

Mobile Web - Safari

12940.mWeb.Safari.mov

Desktop

12940.Desktop.mov

iOS

12940.iOS.mov

Android

12940.Android.mov

mollfpr · 2022-11-23T11:21:26Z

@Delgee please pull the main branch, the routing number input now is autofocus. We also need to update the test step number 3 and number 4.

mollfpr · 2022-11-23T17:12:37Z

The changes work well on all platforms! Just need to do small changes left (adding a comment) @Delgee.

Reviewer checklist #12940 (comment)

🎀 👀 🎀 C+ reviewed!

Delgee · 2022-11-24T02:47:44Z

@mollfpr Thanks for the review. I've added comments, changed test steps, and confirmed fix is working on the latest main branch code.

mollfpr · 2022-11-24T03:15:49Z

src/pages/ReimbursementAccount/BankAccountManualStep.js

+                                <TextLink
+                                    href="https://use.expensify.com/terms"
+
+                                    // to not trigger input blur event. Because form is validating on input blur event link is moving down before click event.


This is wrong, the input blur is still called. My analysis is, calling preventDefault in onMouseDown make the onPress in the TextLink call before the input blur.

How about Call the onPress in the TextLink before the input blur is fired and shift the link element.

Yeah, you are right. My wording sounds like it blocks blur event altogether.
Just to clarify what is actually happening is blur event should be called after onMouseDown event. Since we are calling preventDefault on onMouseDown event blur is not triggered so onPress can be called without issue. Since blur event has not been called after onMouseDown event it gets called after onPress event.

@mollfpr changed it.

mollfpr · 2022-11-24T03:48:45Z

LGTM 👍

All yours @Gonals!

Gonals · 2022-11-24T12:22:21Z

Great job getting your Expensify/App pull request over the finish line! I'll merge it assuming all the tests pass.

I know there's a lot of information in our contributing guidelines, so some points to take note of:

Once your PR is merged, you can be hired for another issue. Once you've completed a few issues, we may start hiring you for more than one issue at a time.

Once your PR is deployed to our staging servers, it will undergo quality assurance (QA) testing. If we find that this doesn't work as expected or causes a regression, you'll be responsible for fixing it. Typically we would revert this PR and give you another chance to create a similar PR without causing a regression. (I don't imagine this will happen with this PR, but it's something to be aware of)

Once your PR is deployed to production, we start a 7-day timer. After it has been on production for 7 days without causing any regressions, then we pay out the Upwork job.

So it might take a while before you're paid for your work, but we typically post multiple new jobs every day, so there's plenty of opportunity. I hope you've had a positive experience contributing to this repo!

OSBotify · 2022-11-24T14:24:16Z

🚀 Deployed to staging by @Gonals in version: 1.2.31-4 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

luacmartins · 2022-12-06T17:38:42Z

The production deploy comment failed for this PR, but this was deployed to production on v1.2.32-2 on Nov 28.

bank account manual step issue

e98a358

Delgee requested a review from a team as a code owner November 22, 2022 19:23

melvin-bot bot requested review from Gonals and mollfpr and removed request for a team November 22, 2022 19:23

mollfpr reviewed Nov 23, 2022

View reviewed changes

Delgee added 2 commits November 24, 2022 10:32

Merge branch 'main' into issue-12715

ae9a02f

added comments

a30cf70

mollfpr reviewed Nov 24, 2022

View reviewed changes

'BankAccountManualStep' comment edited

e54466d

Gonals approved these changes Nov 24, 2022

View reviewed changes

Gonals merged commit 2370b31 into Expensify:main Nov 24, 2022

OSBotify mentioned this pull request Nov 24, 2022

Deploy Checklist: New Expensify 2022-11-23 #12976

Closed

38 tasks

eVoloshchak mentioned this pull request May 11, 2023

Fix - i accept the expensify terms of service, checkbox is not checked when connected online with plaid #18633

Merged

57 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added onMouseDown prop to TextLink component, fixed issue of not able to open link with one click in BankAccountManualStep component #12940

Added onMouseDown prop to TextLink component, fixed issue of not able to open link with one click in BankAccountManualStep component #12940

Delgee commented Nov 22, 2022 •

edited

Loading

melvin-bot bot commented Nov 22, 2022

mollfpr Nov 23, 2022

mollfpr Nov 23, 2022

mollfpr commented Nov 23, 2022 •

edited

Loading

mollfpr commented Nov 23, 2022 •

edited

Loading

mollfpr commented Nov 23, 2022

Delgee commented Nov 24, 2022

mollfpr Nov 24, 2022

Delgee Nov 24, 2022

Delgee Nov 24, 2022

mollfpr commented Nov 24, 2022

Gonals commented Nov 24, 2022

OSBotify commented Nov 24, 2022

luacmartins commented Dec 6, 2022

Added onMouseDown prop to TextLink component, fixed issue of not able to open link with one click in BankAccountManualStep component #12940

Added onMouseDown prop to TextLink component, fixed issue of not able to open link with one click in BankAccountManualStep component #12940

Conversation

Delgee commented Nov 22, 2022 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

PR Reviewer Checklist

Screenshots

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

melvin-bot bot commented Nov 22, 2022

mollfpr Nov 23, 2022

Choose a reason for hiding this comment

mollfpr Nov 23, 2022

Choose a reason for hiding this comment

mollfpr commented Nov 23, 2022 • edited Loading

Reviewer Checklist

Screenshots/Videos

mollfpr commented Nov 23, 2022 • edited Loading

mollfpr commented Nov 23, 2022

Delgee commented Nov 24, 2022

mollfpr Nov 24, 2022

Choose a reason for hiding this comment

Delgee Nov 24, 2022

Choose a reason for hiding this comment

Delgee Nov 24, 2022

Choose a reason for hiding this comment

mollfpr commented Nov 24, 2022

Gonals commented Nov 24, 2022

OSBotify commented Nov 24, 2022

luacmartins commented Dec 6, 2022

Delgee commented Nov 22, 2022 •

edited

Loading

mollfpr commented Nov 23, 2022 •

edited

Loading

mollfpr commented Nov 23, 2022 •

edited

Loading