Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix - i accept the expensify terms of service, checkbox is not checked when connected online with plaid #18633

Conversation

HezekielT
Copy link
Contributor

@HezekielT HezekielT commented May 9, 2023

Details

Fixed Issues

$ #17877
PROPOSAL: #17877 (comment)

Tests

Verify if a checkbox is checked when the user returns to bank account step from company information step.

  1. Open the app -> Workspaces -> Connect Bank Account
  2. Click Connect Online with Plaid
  3. Enter test credentials for bank account Fidelity, UN: user_good PW: pass_good(if you're in dev, you need to turn on 'use staging server' in preference setting first before connecting)
  4. Upon returning to expensify, select a bank account from the dropdown options.
  5. I accept the Expensify terms of service should appear before proceeding to Company Information step.
  6. Click on the check box and continue to the next step.
  7. Return back to the previous step.
  8. The checkbox should remain checked.
  9. Now clear both Routing number and Account number fields and go back to the previous step.
  10. Click on Connect manually option.
  11. Click on Routing number input field.
  12. Without losing focus click on Expensify Terms of Service link.
  13. Verify link is opened.
  • Verify that no errors appear in the JS console

Offline tests

Needs an internet connection to connect bank account online. Therefore, it is not applicable.

QA Steps

Same as "Tests" Section above.

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android / native
    • Android / Chrome
    • iOS / native
    • iOS / Safari
    • MacOS / Chrome / Safari
    • MacOS / Desktop
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
      • If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
  • I verified that if a function's arguments changed that all usages have also been updated correctly
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately and each prop has a /** comment above it */
    • The file is named correctly
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
    • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
    • All JSX used for rendering exists in the render method
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web
Screencast-iAcceptTermsWeb.mov
Mobile Web - Chrome
Screencast-iAcceptTerms-mWebChrome.webm
Mobile Web - Safari
ios-safari-i-accept-terms.mov
Desktop
Screencast-iAcceptTermsDesktop.mov
iOS
ios-native-i-accept-terms.mov
Android
Screencast-iAcceptTermsAndroidNative.mov

@HezekielT HezekielT requested a review from a team as a code owner May 9, 2023 10:46
@github-actions
Copy link
Contributor

github-actions bot commented May 9, 2023

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@melvin-bot melvin-bot bot requested review from youssef-lr and removed request for a team May 9, 2023 10:46
@melvin-bot
Copy link

melvin-bot bot commented May 9, 2023

@youssef-lr Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@HezekielT
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@madmax330
Copy link
Contributor

madmax330 commented May 10, 2023

@HezekielT can you fix the GH link, it's not supposed to be GHLink highlighted as mentioned in the PR template it should be the actual link of the PR.

  1. Please replace GH_LINK with a URL link to the GitHub issue this Pull Request is fixing.
  2. Please replace PROPOSAL: GH_LINK_ISSUE(COMMENT) with a URL link to your GitHub comment, which contains the approved proposal (i.e. the proposal that was approved by Expensify).

Do NOT add the special GH keywords like fixed etc, we have our own process of managing the flow.
It MUST be an entire link to the github issue and your comment proposal ; otherwise, the linking will not work as expected.

Make sure this section looks similar to this (you can link multiple issues using the same formatting, just add a new line):

$ https://github.com/Expensify/App/issues/
$ https://github.com/Expensify/App/issues/<number-of-the-issue(comment)>

Do NOT only link the issue number like this: $ #

That is why we didn't get assigned for review

@madmax330 madmax330 assigned madmax330 and unassigned madmax330 May 10, 2023
@madmax330 madmax330 self-requested a review May 10, 2023 15:42
@HezekielT HezekielT changed the title Fix - i accept the expensify terms of service, checkbox is not checked when connected online with plaid #17877 Fix - i accept the expensify terms of service, checkbox is not checked when connected online with plaid May 10, 2023
…f-Service,-Checkbox-is-not-checked-when-connected-online-with-Plaid-Expensify#17877
@eVoloshchak
Copy link
Contributor

eVoloshchak commented May 10, 2023

Reviewer Checklist

  • I have verified the author checklist is complete (all boxes are checked off).
  • I verified the correct issue is linked in the ### Fixed Issues section above
  • I verified testing steps are clear and they cover the changes made in this PR
    • I verified the steps for local testing are in the Tests section
    • I verified the steps for Staging and/or Production testing are in the QA steps section
    • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I checked that screenshots or videos are included for tests on all platforms
  • I included screenshots or videos for tests on all platforms
  • I verified tests pass on all platforms & I tested again on:
    • Android / native
    • Android / Chrome
    • iOS / native
    • iOS / Safari
    • MacOS / Chrome / Safari
    • MacOS / Desktop
  • If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
  • I verified proper code patterns were followed (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
    • I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I verified that this PR follows the guidelines as stated in the Review Guidelines
  • I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately and each prop has a /** comment above it */
    • The file is named correctly
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
    • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
    • All JSX used for rendering exists in the render method
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web
Screen.Recording.2023-05-11.at.22.36.54.mov
Mobile Web - Chrome
Screen_Recording_20230511-225244_Chrome.mp4
Mobile Web - Safari
Screen.Recording.2023-05-11.at.22.42.41.mov
Desktop
Screen.Recording.2023-05-11.at.22.46.37.mov
iOS
Screen.Recording.2023-05-11.at.22.39.28.mov
Android
Screen_Recording_20230511-224914_New.Expensify.mp4

@eVoloshchak
Copy link
Contributor

I'm getting this error on iOS

Screen.Recording.2023-05-11.at.15.16.57.mov

But weirdly, it isn't present on android

@HezekielT
Copy link
Contributor Author

HezekielT commented May 11, 2023

@eVoloshchak This error also happens when we connect bank accounts manually.

  1. Enter valid routing number and account number
  2. without checking the checkbox click on Save and continue
  3. Now click on fix the errors.
  4. The same console error happens.

I did some research and I found another issue that reported this error a while ago( #12508 ) and the decision was to close it based on those two comments( #12508 (comment) and #12508(comment) ).

So the issue is not because of this PR and I don't think we can do anything about it. Please take a look at that issue and let me know what needs to be done.

@HezekielT
Copy link
Contributor Author

So basically the issue only occurs in ios and it doesn’t happen in staging or production(only in dev) and there is a fix but it hasn’t reached ios yet according to this comment.

@eVoloshchak
Copy link
Contributor

@HezekielT, thanks for attaching those links!
I'll finish the remaining checklist items in a couple of hours

Copy link
Contributor

@eVoloshchak eVoloshchak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

…f-Service,-Checkbox-is-not-checked-when-connected-online-with-Plaid-Expensify#17877
…f-Service,-Checkbox-is-not-checked-when-connected-online-with-Plaid-Expensify#17877
@HezekielT
Copy link
Contributor Author

@madmax330 Friendly bump ^

@madmax330 madmax330 merged commit 8e80b56 into Expensify:main May 15, 2023
@OSBotify
Copy link
Contributor

🚀 Deployed to staging by https://github.com/madmax330 in version: 1.3.14-2 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 failure ❌
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to staging by https://github.com/madmax330 in version: 1.3.14-2 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production by https://github.com/yuwenmemon in version: 1.3.14-14 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@HezekielT HezekielT deleted the fix-I-accept-the-Expensify-Terms-of-Service,-Checkbox-is-not-checked-when-connected-online-with-Plaid-#17877 branch May 17, 2023 17:06
@HezekielT HezekielT restored the fix-I-accept-the-Expensify-Terms-of-Service,-Checkbox-is-not-checked-when-connected-online-with-Plaid-#17877 branch May 17, 2023 17:06
@HezekielT HezekielT deleted the fix-I-accept-the-Expensify-Terms-of-Service,-Checkbox-is-not-checked-when-connected-online-with-Plaid-#17877 branch May 28, 2023 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants