[$1000] [HOLD for payment 2022-12-05] Android - Attachments - PDF file is disappeared in the chat after sent it

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Launch App and login
2. Navigate to any chat
3. Sent PDF attachment

Expected Result:

Attachment should be sent and appeared in the chat

Actual Result:

The attachment was sent and not appeared in the chat.

Workaround:

Unknown

Platform:

Where is this issue occurring?

• Android

Version Number: 1.2.31.1

Reproducible in staging?: Yes

Reproducible in production?: No

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug5834950_PDF.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01f9b2ebef492363fd
• Upwork Job ID: 1597630039067684864

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @mountiny (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[0xmiros]

Found root cause.
Opened discussion in slack here

[mountiny]

Thanks, from slack:

Root cause: DylanVann/react-native-fast-image#865
workaround: fix in native code (FastImageViewConverter.java)

[luacmartins]

Looks like we will revert this PR. It can't be auto reverted though, so we'll work on a manual revert.

[mountiny]

Thanks, the PR has been reverted and deployed to staging some time ago. I am going to close this issue, thanks for help

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.2.32-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Revert "Merge pull request #12648 from margelo/@thomas/fast-image-cac… #13010

If no regressions arise, payment will be issued on 2022-12-05. 🎊

After the hold period, please check if any of the following need payment for this issue, and if so check them off after paying:

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[0xmiros]

@mountiny am I eligible for compensation? I found out the root cause and proposed a solution on slack as soon as this deploy blocker created.

[melvin-bot]

Triggered auto assignment to @conorpendergrast (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[mountiny]

Found root cause.
Opened discussion in slack here

I think it would make sense to have a same compensation as for reporting $250, the offending PR has been found quickly.

[mountiny]

@conorpendergrast Could we please create Upwork job and Pay @0xmiroslav $250 bonus for helping identifying which PR caused this Deploy blocker?

Thanks for raising this @0xmiroslav

[0xmiros]

Thanks @mountiny

[melvin-bot]

Current assignee @conorpendergrast is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01f9b2ebef492363fd

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @parasharrajat (External)

[melvin-bot]

Current assignee @mountiny is eligible for the External assigner, not assigning anyone new.

[conorpendergrast]

@0xmiroslav Contract sent; please let me know when you've accepted and I'll pay it!

[conorpendergrast]

Paid! Upwork isn't showing me the option to end the contract at the moment, so I'll keep this open for myself to check back on it

[conorpendergrast]

Contract ended, all set.