[HOLD for payment 2022-11-29] [$250] The error when enter invalid debit card information still appear after reload the page reported by @hans

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Navigate to Profile > Payment, click "Add payment method", choose "Debit card"
2. Enter some random information and press "Save", you will see the error appear at the bottom, reload the page.
3. Notice that the error still appear.

Expected Result:

Error text at the bottom should disappear after reload the page

Actual Result:

Error text at the bottom still appear after reload the page

Workaround:

unknown

Platform:

Where is this issue occurring?

• Web

Version Number: 1.2.27-0

Reproducible in staging?: y

Reproducible in production?: y

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos:

Screen.Recording.2022-11-12.at.00.07.40.mov

Recording.889.mp4

Expensify/Expensify Issue URL:

Issue reported by: @hans

Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1668187065943279

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @CortneyOfstad (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[Puneet-here]

Proposal

We clear the error at componentWillUnmount but it doesn't get invoked on refresh

App/src/pages/settings/Payments/AddDebitCardPage.js

Lines 58 to 59 in 0d653ca

	componentWillUnmount() {
	PaymentMethods.clearDebitCardFormErrorAndSubmit();

we need to add PaymentMethods.clearDebitCardFormErrorAndSubmit(); at constructor to fix this

[CortneyOfstad]

Definitely appears to be an issue. Going to assign engineering to see if this needs to be Internal or External. Thinking External, but want a second pair of eyes to be sure.

[melvin-bot]

Triggered auto assignment to @NikkiWines (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[NikkiWines]

Looks like a good external issue! Applying the appropriate label

[melvin-bot]

Current assignee @CortneyOfstad is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @thesahindia (External)

[melvin-bot]

Triggered auto assignment to @luacmartins (External), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[thesahindia]

@Puneet-here's proposal looks good, but I don't have my mac right now so I haven't tested it. I will test this in the morning.

[hungvu193]

Hello there, I'm the reporter of this bug, can you assign me as well?
Seem @kavimuru tagged the wrong person. Here's the slack thread (https://expensify.slack.com/archives/C049HHMV9SM/p1668187065943279).
Should I change my slack name to the same with github name to avoid this?

[thesahindia]

@luacmartins, I like @Puneet-here's proposal.

C+ reviewed 🎀👀🎀

[melvin-bot]

📣 @Puneet-here You have been assigned to this job by @luacmartins!
Please apply to this job in Upwork and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• @CortneyOfstad A regression test has been added or updated so that the same bug will not reach production again. (asked in BugZero here) Link to the GH issue for creating the test here: No GH needed, as TestRail already has the step included
• @thesahindia @luacmartins The PR that introduced the bug has been identified. Link to the PR:
• @CortneyOfstad The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Appears the issue wasn't introduced via a PR
• @CortneyOfstad A discussion in #contributor-plus has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Not really a bug as this is more geared to a feature request.
• @CortneyOfstad Payment has been made to the issue reporter (if applicable)
• @CortneyOfstad Payment has been made to the contributor that fixed the issue (if applicable)
• @CortneyOfstad Payment has been made to the contributor+ that helped on the issue (if applicable)

[thesahindia]

The PR that introduced the bug has been identified. Link to the PR:

Not applicable ? It was an edge case ( more of a feature request ) and it was missed in the refactor

[CortneyOfstad]

Tackling my checklist today 👍

[hungvu193]

Can I have reporting bonus for this issue?

[CortneyOfstad]

Will have this paid by EOD today 👍

[CortneyOfstad]

Job posting — https://www.upwork.com/jobs/~018c9998e3f5f89303

@hungvu193 @thesahindia @Puneet-here — I've sent over the contracts. Once those are accepted, I will get that payment sent out by EOD today 👍

Thanks!

[CortneyOfstad]

Payments have been sent! Thanks!

[Puneet-here]

@CortneyOfstad, this is eligible for 50% bonus.

[CortneyOfstad]

@Puneet-here Who is it eligible for? Sorry, this is my first time doing a payment.

[Puneet-here]

For reviewer and contributor who fixed this issue.
It is written in this section

[CortneyOfstad]

Sorry about that! @Puneet-here @thesahindia — I extended another contract for the bonus amount. I'll keep an eye on my email to see when you accept and I'll get that paid ASAP 👍

[Puneet-here]

Accepted the offer, thanks!

[thesahindia]

Accepted, thanks!

[CortneyOfstad]

Thank you!! Both have been paid for the bonus 👍

[thesahindia]

Let's close the issue.