New Room- Characters appear/disappear when using a special characters (e.g.: + or &)

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Issue found when executing PR #12899

Action Performed:

1. Launch the app
2. Login with any account
3. Click green circle button
4. Create room
5. In the room name type: "test123"
6. Put the cursor just after the word "test"
7. Type a space
8. Verify that the result is "test_123" and that the cursor is right after the underscore and not in the end
9. Type a special char (e.g.: + or &)

Expected Result:

Characters are temporarily appearing and disappearing when using a special characteristics(e.g.: + or &) after space

Actual Result:

Characters are temporarily appearing and disappearing when using a special characteristics(e.g.: + or &) after space
In IOS app when typing a special characteristics its briefly visible.

Workaround:

Unknown

Platform:

Where is this issue occurring?

• iOS
• Android

Version Number: 1.2.31.7

Reproducible in staging?: Yes

Reproducible in production?: Yes

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

12899.IOS.MP4

12899.Android.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @sophiepintoraetz (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[s77rt]

I won't say this is a bug, the text input is being changed and depending on the device speed you may or may need see the change happening (refereed to shaking in the GH body)

[sophiepintoraetz]

Came in over the weekend - will look at this tomorrow.

[marcaaron]

Yeah can we maybe clarify what "shaking" means in this context? It looks like those characters are being overwritten (though I haven't confirmed this). Which is against our form guidelines as stated here:

https://github.com/Expensify/App/blob/main/contributingGuides/FORMS.md#modifying-user-input-on-change

[sophiepintoraetz]

Ack have not had time to replicate this!

[sophiepintoraetz]

@kbecciv - by shaking, do you mean that the special character temporarily appears and then disappears? If so, I think I have successfully reproduced this on iOS/Android on v1.2.36.1

RPReplay_Final1670216776.mov

[kbecciv]

@sophiepintoraetz Yes, correct - I meant that the special character temporarily appears and then disappears.

[melvin-bot]

Triggered auto assignment to @madmax330 (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[madmax330]

Will look into this tomorrow

[madmax330]

I can fix this bug, however I am OOO, so moving it to weekly

[sophiepintoraetz]

Max is OOO

[bondydaa]

I think max is coming back tomorrow from OOO but I can probably also help out if needed

I think we should solve this by heeding what Marc called out here: #13042 (comment) and completely remove the automatic editing of the user's input and have some front side validation on submit (and backend validation too in case that doesn't already exist)

[JmillsExpensify]

This issue recently hit 30 days, which is how it ended up on my radar. Here's two cents:

• I don't think this issue should hold up WAQ, as it's for a beta feature that has no set launch date
• Further, I think we should associated this with the form refactor given that it violates our stipulated behavior

As for the solution, I agree that this should instead have front-end validation so that information isn't removed after being added. But again, I don't think this is a bug that should block the roadmap, nor should any other bug related to beta features that we have no plans to introduce for months and months from now.

Feel free to fix it, but again, I'm throwing 'HOLD WAQ' in the title in the meantime.

[madmax330]

on hold

[madmax330]

on hold

[JmillsExpensify]

Removed the WAQ hold for continuity.

[madmax330]

I think for this issue we want the same solution as here: #13676 (comment)

It's the same problem of the special characters being trimmed out. So we should just leave them and show an error

[trjExpensify]

Doesn't seem like this isn't an issue anymore. I can't reproduce it on iOS v1.2.50-14 at least, we're following the correct Forms pattern.

RPReplay_Final1673524407.MP4

[sophiepintoraetz]

Yeah, I'm also not able to reproduce this so closing and adding reproduction steps needed.