Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[HOLD for payment 2022-12-20] Chat - The bold chat is hard to see in dark mode #13202

Closed
kbecciv opened this issue Nov 30, 2022 · 23 comments
Closed

[HOLD for payment 2022-12-20] Chat - The bold chat is hard to see in dark mode #13202

kbecciv opened this issue Nov 30, 2022 · 23 comments
Assignees
@shawnborton @sakluger @srikarparsi @thesahindia
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Design Internal Requires API changes or must be handled by Expensify staff Weekly KSv2

Comments

@kbecciv
Copy link

kbecciv commented Nov 30, 2022 •
edited by melvin-bot bot
Loading

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Action Performed:

  1. Go to URL https://staging.new.expensify.com/
  2. Log in with any account (account A)
  3. Log in in other device with other account (account B)
  4. Verify that account A go out of the conversation with account B
  5. Send a message to account A from account B

Expected Result:

The bold chat is not hard to see in dark mode

Actual Result:

The bold chat is hard to see in dark mode

Workaround:

Unknown

Platform:

Where is this issue occurring?

  • Web
  • iOS
  • Android
  • Desktop App
  • Mobile Web

Version Number: 1.2.34.0

Reproducible in staging?: Yes

Reproducible in production?: Yes

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug5842498_Recording__3154.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~013a926a86043b84c4
  • Upwork Job ID: 1606453248846229504
  • Last Price Increase: 2022-12-24
@kbecciv kbecciv added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Nov 30, 2022
@melvin-bot
Copy link

melvin-bot bot commented Nov 30, 2022

Triggered auto assignment to @sakluger (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@srikarparsi srikarparsi self-assigned this Nov 30, 2022
@melvin-bot
Copy link

melvin-bot bot commented Nov 30, 2022

Triggered auto assignment to @shawnborton (Design), see these Stack Overflow questions for more details.

@sakluger
Copy link
Contributor

I agree! I'm labeling with design since I think this is more of a design thing rather than a bug. @shawnborton what are your thoughts on this one?

@shawnborton
Copy link
Contributor

Yeah I don't think this is a bug... it would just be a design optimization

@rafecolton
Copy link
Member

Came here to say I experience this as well!

@JmillsExpensify
Copy link

Definitely polish. That said, this has come up a bunch of times so I think we should pursue a solution.

@srikarparsi
Copy link
Contributor

sounds good, @shawnborton will you prefer taking this one or should I stay on to implement the color changes?

@shawnborton
Copy link
Contributor

I'll take this one from a design/mockup standpoint, but you are more than welcome to be the one to implement any changes we might settle on!

@srikarparsi
Copy link
Contributor

cool thanks shawn! I'll stay on the issue in that case :)

@sakluger sakluger removed the Bug Something is broken. Auto assigns a BugZero manager. label Dec 2, 2022
@sakluger
Copy link
Contributor

sakluger commented Dec 2, 2022

Okay I've removed the Bug label, not sure if any others should be added. @shawnborton feel free to update the priority label with whatever you feel is appropriate.

@shawnborton
Copy link
Contributor

Posted an idea to Slack here

image

@melvin-bot melvin-bot bot added the Overdue label Dec 5, 2022
@srikarparsi srikarparsi mentioned this issue Dec 5, 2022
Merged
49 tasks
@srikarparsi
Copy link
Contributor

pr in review

@melvin-bot melvin-bot bot removed the Overdue label Dec 5, 2022
@srikarparsi srikarparsi added the Reviewing Has a PR in review label Dec 5, 2022
@sakluger sakluger added the Internal Requires API changes or must be handled by Expensify staff label Dec 9, 2022
@sakluger
Copy link
Contributor

sakluger commented Dec 9, 2022

Forgot to label with Internal before.

@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Daily KSv2 labels Dec 13, 2022
@melvin-bot melvin-bot bot changed the title Chat - The bold chat is hard to see in dark mode [HOLD for payment 2022-12-20] Chat - The bold chat is hard to see in dark mode Dec 13, 2022
@melvin-bot
Copy link

melvin-bot bot commented Dec 13, 2022 •
edited by sakluger
Loading

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.2.38-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2022-12-20. 🎊

After the hold period, please check if any of the following need payment for this issue, and if so check them off after paying:

  • External issue reporter
  • Contributor that fixed the issue
  • Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

  • Merged PR within 3 business days of assignment - 50% bonus
  • Merged PR more than 9 business days after assignment - 50% penalty

@sakluger
Copy link
Contributor

sakluger commented Dec 19, 2022 •
edited
Loading

No external reporters or contributors, so checking off the three checkboxes above and closing!

@thesahindia
Copy link
Member

Hey @sakluger, can we reopen? C+ review compensation is pending on this.

@thesahindia
Copy link
Member

Bump @sakluger

@JmillsExpensify
Copy link

@sakluger Don't forget the C+ compensation.

@mallenexpensify mallenexpensify added Internal Requires API changes or must be handled by Expensify staff and removed Internal Requires API changes or must be handled by Expensify staff labels Dec 24, 2022
@melvin-bot
Copy link

melvin-bot bot commented Dec 24, 2022

Job added to Upwork: https://www.upwork.com/jobs/~013a926a86043b84c4

@melvin-bot
Copy link

melvin-bot bot commented Dec 24, 2022

Current assignee @thesahindia is eligible for the Internal assigner, not assigning anyone new.

@mallenexpensify
Copy link
Contributor

@thesahindia can you please accept the job and reply here once you have?
https://www.upwork.com/jobs/~013a926a86043b84c4

@thesahindia
Copy link
Member

Accepted, thanks!

@srikarparsi srikarparsi removed the Reviewing Has a PR in review label Dec 26, 2022
@mallenexpensify
Copy link
Contributor

Paid @thesahindia $1000 for PR review. Closing cuz I'm not seeing a regression checklist that needs to be filled out

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shawnborton shawnborton

@sakluger sakluger

@srikarparsi srikarparsi

@thesahindia thesahindia

Labels
Awaiting Payment Auto-added when associated PR is deployed to production Design Internal Requires API changes or must be handled by Expensify staff Weekly KSv2
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
8 participants
@rafecolton @JmillsExpensify @shawnborton @sakluger @mallenexpensify @srikarparsi @thesahindia @kbecciv