change display name color to gray #13331

srikarparsi · 2022-12-05T17:56:21Z

Details

Fixed Issues

$ #13202
PROPOSAL: GH_LINK_ISSUE(COMMENT)

Tests

Verify that no errors appear in the JS console

If you already have unread messages on dev, ensure that the unread messages have a bolded white display name and read messages have a grey display name.
Otherwise, send a message from another account to your account and then do step 1.

Offline tests

QA Steps

Verify that no errors appear in the JS console

Same as tests

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- iOS / native
- Android / native
- iOS / Safari
- Android / Chrome
- MacOS / Chrome
- MacOS / Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product was added in all src/languages/* files
- I verified any copy / text that was added to the app is correct English and approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

melvin-bot · 2022-12-05T17:56:58Z

@thesahindia @puneetlath One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

grgia · 2022-12-05T18:21:01Z

Android:

Chrome:

srikarparsi · 2022-12-05T18:25:14Z

thanks @grgia! I added them into the checklist and this is ready for review. The variable name "textSupporting" could be a bit confusing now since it's the main color in this case but it's used in a lot of places so I don't think it makes sense changing it or creating a new variable with the same value.

grgia · 2022-12-05T18:27:36Z

IMO TextSupporting is still an accurate description since the primary text color is still used when you open chats

thesahindia · 2022-12-05T18:33:48Z

Testing...

thesahindia · 2022-12-05T18:39:28Z

src/components/DisplayNames/index.js

@@ -100,7 +100,7 @@ class DisplayNames extends PureComponent {
                            >
                                {/*  // We need to get the refs to all the names which will be used to correct
                                    the horizontal position of the tooltip */}
-                                <Text ref={el => this.childRefs[index] = el}>
+                                <Text ref={el => this.childRefs[index] = el} style={[...this.props.textStyles, styles.pRelative]}>


Do we need styles.pRelative here?

Yeah, curious what that does?

Yeah I'm not sure why we need relative positioning there since it works just fine without it. I just added it since it was supposed to affect the text but I can take it out. It doesn't affect any platform but I was just scared that there might be some edge case for the reason it was added.

Let's remove pRelative from line 103 and leave it on line 86 just to be safe.

sure, that sounds good, the text object will be positioned accordingly anyway in that case

thesahindia · 2022-12-06T18:30:47Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- iOS / native
- Android / native
- iOS / Safari
- Android / Chrome
- MacOS / Chrome
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product was added in all src/languages/* files
- I verified any copy / text that was added to the app is correct English and approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

thesahindia

Works well!

C+ reviewed 🎀👀🎀

cc: @puneetlath

puneetlath · 2022-12-06T19:01:58Z

@shawnborton do you want to review as well? If not, @srikarparsi feel free to self-merge.

shawnborton · 2022-12-06T19:07:09Z

Screenshots look good to me!

OSBotify · 2022-12-06T19:11:36Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2022-12-13T22:39:53Z

🚀 Deployed to production by @chiragsalian in version: 1.2.38-6 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

change display name color to gray

18490e5

srikarparsi requested a review from shawnborton December 5, 2022 17:56

srikarparsi requested a review from a team as a code owner December 5, 2022 17:56

melvin-bot bot requested review from puneetlath and thesahindia and removed request for a team December 5, 2022 17:56

srikarparsi changed the title ~~[WIP] change display name color to gray~~ change display name color to gray Dec 5, 2022

puneetlath previously approved these changes Dec 5, 2022

View reviewed changes

This comment was marked as duplicate.

Sign in to view

thesahindia reviewed Dec 5, 2022

View reviewed changes

srikarparsi self-assigned this Dec 5, 2022

remove pRelative from inner text

ff73711

srikarparsi dismissed puneetlath’s stale review via ff73711 December 6, 2022 18:19

srikarparsi requested review from puneetlath and thesahindia December 6, 2022 18:19

thesahindia approved these changes Dec 6, 2022

View reviewed changes

puneetlath approved these changes Dec 6, 2022

View reviewed changes

shawnborton approved these changes Dec 6, 2022

View reviewed changes

shawnborton merged commit a2c5376 into main Dec 6, 2022

shawnborton deleted the srikar-chatNameColor branch December 6, 2022 19:07

francoisl mentioned this pull request Dec 8, 2022

Deploy Checklist: New Expensify 2022-12-07 #13431

Closed

72 tasks

melvin-bot bot mentioned this pull request Dec 13, 2022

[HOLD for payment 2022-12-20] Chat - The bold chat is hard to see in dark mode #13202

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

change display name color to gray #13331

change display name color to gray #13331

srikarparsi commented Dec 5, 2022 •

edited

Loading

melvin-bot bot commented Dec 5, 2022

grgia commented Dec 5, 2022

srikarparsi commented Dec 5, 2022 •

edited

Loading

grgia commented Dec 5, 2022

thesahindia commented Dec 5, 2022

This comment was marked as duplicate.

thesahindia Dec 5, 2022

shawnborton Dec 5, 2022

srikarparsi Dec 5, 2022

thesahindia Dec 6, 2022

srikarparsi Dec 6, 2022

thesahindia commented Dec 6, 2022

thesahindia left a comment

puneetlath commented Dec 6, 2022

shawnborton commented Dec 6, 2022

OSBotify commented Dec 6, 2022

OSBotify commented Dec 13, 2022

change display name color to gray #13331

change display name color to gray #13331

Conversation

srikarparsi commented Dec 5, 2022 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Dec 5, 2022

grgia commented Dec 5, 2022

srikarparsi commented Dec 5, 2022 • edited Loading

grgia commented Dec 5, 2022

thesahindia commented Dec 5, 2022

This comment was marked as duplicate.

thesahindia Dec 5, 2022

Choose a reason for hiding this comment

shawnborton Dec 5, 2022

Choose a reason for hiding this comment

srikarparsi Dec 5, 2022

Choose a reason for hiding this comment

thesahindia Dec 6, 2022

Choose a reason for hiding this comment

srikarparsi Dec 6, 2022

Choose a reason for hiding this comment

thesahindia commented Dec 6, 2022

Reviewer Checklist

Screenshots/Videos

thesahindia left a comment

Choose a reason for hiding this comment

puneetlath commented Dec 6, 2022

shawnborton commented Dec 6, 2022

OSBotify commented Dec 6, 2022

OSBotify commented Dec 13, 2022

srikarparsi commented Dec 5, 2022 •

edited

Loading

srikarparsi commented Dec 5, 2022 •

edited

Loading