[HOLD for payment 2022-12-22][$1000] Workspace - general settings - Save Button is not at the bottom

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Open the app
2. Go to settings > Workspaces
3. Open a workspace
4. Go to workspace settings

Expected Result:

The button should be at the bottom

Actual Result :

The button is not at the bottom

Workaround:

unknown

Platform:

Where is this issue occurring?

• Web
• iOS
• Android
• Desktop App
• Mobile Web

Version Number: 1.2.37-2
Reproducible in staging?: y
Reproducible in production?: n
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:

Expensify/Expensify Issue URL:

Issue reported by: @daraksha-dk

Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1670351071306529

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~014a8b2e372f1048cf
• Upwork Job ID: 1602417572384657408
• Last Price Increase: 2022-12-12

[melvin-bot]

Triggered auto assignment to @davidcardoza (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[daraksha-dk]

Proposal

styles.flex1 was removed from below in #12848 (cc: @tgolen )

App/src/components/FormAlertWithSubmitButton.js

Line 56 in ed3e2dc

containerStyles={[styles.mh5, styles.mb5, styles.justifyContentEnd, ...props.containerStyles]}

We just have to pass styles.flex1 below so it will only affect Form

App/src/components/Form.js

Line 297 in ed3e2dc

containerStyles={[styles.mh0, styles.mt5]}

[tgolen]

OK, please make sure that you test the sign-in flows to ensure buttons are all placed properly. If I recall, the reason I removed that was because it was causing a spacing issue on the "resend validation link" form.

[daraksha-dk]

@tgolen, yeah I looked at the PR and re-adding flex1 below was causing spacing issues

App/src/components/FormAlertWithSubmitButton.js

Line 56 in ed3e2dc

containerStyles={[styles.mh5, styles.mb5, styles.justifyContentEnd, ...props.containerStyles]}

that's why I found another solution, which is to pass the flex1 to FormAlertWithSubmitButton using by using its containerStyles prop in Form so that it doesn't affect other places. We just have to pass flex1 below

App/src/components/Form.js

Line 297 in ed3e2dc

containerStyles={[styles.mh0, styles.mt5]}

[chiragsalian]

Proposal LGTM

[davidcardoza]

Applying the external label for review.

[melvin-bot]

Current assignee @davidcardoza is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~014a8b2e372f1048cf

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @mananjadhav (External)

[melvin-bot]

Triggered auto assignment to @chiragsalian (External), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[davidcardoza]

Job posted - https://www.upwork.com/jobs/~01fa021a1ff96c59c0

[lordthien]

Proposal:
In file: App/src/components/Form.js. I add styles.flex1 into containerStyles of FormAlertWithSubmitButton

diff --git a/src/components/Form.js b/src/components/Form.js
index 72ee4afc6b..3c41357161 100644
--- a/src/components/Form.js
+++ b/src/components/Form.js
@@ -294,7 +294,7 @@ class Form extends React.Component {
                                     focusInput.focus();
                                 }
                             }}
-                            containerStyles={[styles.mh0, styles.mt5]}
+                            containerStyles={[styles.mh0, styles.mt5, styles.flex1]}
                             enabledWhenOffline={this.props.enabledWhenOffline}
                             isDangerousAction={this.props.isDangerousAction}
                         />

[mananjadhav]

I just went through the proposals to review and was going to accept @daraksha-dk's proposal but then I saw the PR is already merged.

@chiragsalian do you need a second testing from my side here?

[chiragsalian]

QA tested this and its a pass, removing deploy blocker label

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.2.38-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix button position #13530

If no regressions arise, payment will be issued on 2022-12-20. 🎊

After the hold period, please check if any of the following need payment for this issue, and if so check them off after paying:

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@chiragsalian] The PR that introduced the bug has been identified. Link to the PR: Fix the keyboard overlapping buttons on the sign in form #12848
• [@chiragsalian] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: Fix the keyboard overlapping buttons on the sign in form #12848 (comment)
• [@chiragsalian] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A minor visual bug.
• [chirag] ~A regression test has been added or updated so that the same bug will not reach production again. Link to the GH issue for creating the test here: ~ Just a visual improvement. I'm not sure if this was ever associated to something else.

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.2.39-0 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix button position #13530

If no regressions arise, payment will be issued on 2022-12-22. 🎊

After the hold period, please check if any of the following need payment for this issue, and if so check them off after paying:

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@chiragsalian] The PR that introduced the bug has been identified. Link to the PR:
• [@chiragsalian] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@chiragsalian] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@davidcardoza] A regression test has been added or updated so that the same bug will not reach production again. Link to the GH issue for creating the test here:

[daraksha-dk]

@davidcardoza, I have applied to the job.
Just a note - The job price is $1000 but it's eligible for $1750 (Reporting Bonus + Fix + 50% bonus )

[davidcardoza]

Sounds good, I paid out $1750

[daraksha-dk]

@davidcardoza, I haven't received the offer. Can you check please?

[davidcardoza]

@daraksha-dk I sent the invite again. Did you receive it?

[mallenexpensify]

@daraksha-dk , I just hired you, please accept https://www.upwork.com/jobs/~014a8b2e372f1048cf
The bonus will be added, $1750 will be the total.
I've assigned to issue payment too, I think David might (or should) out of office :)

[daraksha-dk]

Thanks @mallenexpensify - I have accepted the offer on Upwork

[mallenexpensify]

Paid @daraksha-dk $1750.
@chiragsalian can you fill out the BZ checklist above plz, Doza already did the TestRail update
#13488 (comment)

[chiragsalian]

huh, i already filled it out here - #13488 (comment). The second post looks like a melvin dupe so I'm ignoring it.

[mallenexpensify]

oh... sweet. Sorry I missed that @chiragsalian , closing meow