Standardize on one method for detecting keyboard state

[tgolen]

Problem

There are two ways for components to detect the keyboard state:

1. Using the HOC withKeyboardState - this works on native devices, but doesn't have support for mobile web
2. Using VirtualKeyboard.shouldAssumeIsOpen() - this appears to work on both native devices and mobile web. Originally added in this PR.

Neither option is used consistently, leading to inconsistent behavior in the app.

Solution

• Make sure that VirtualKeyboard works for mobile web
• Move the functionality from VirtualKeyboard into withKeyboardState
• Use withKeyboardState everywhere
• Remove VirtualKeyboard

CC @jasperhuangg @parasharrajat

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01e011fc436edaf3d0
• Upwork Job ID: 1608620601075437568
• Last Price Increase: 2022-12-30

[melvin-bot]

Triggered auto assignment to @flaviadefaria (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[tgolen]

Sorry @flaviadefaria, this is not a bug, just a cleanup issue, so I am removing your assignement.

[tgolen]

All right, here is what I found out. Virtual keyboard exports two methods:

1. isOpen() - Is always the same as props.isShown on all platforms and it's only used in one place here. That can easily be replaced with props.isShown
2. shouldAssumeIsOpen() - Is always the same as props.isShown for native devices. It always returns true for mobile web platforms. It's used in 4 places and is almost always used as a proxy for "is this mobile web?" which is also the same as isSmallScreenWidth (usually)

So, I think that all of this can be refactored to just use the two HOCs we currently have for withKeyboardState and withDimensions and we can remove the VirtualKeyboard lib entirely.

[tgolen]

Hm, I'm not sure why GH didn't link the PR with this issue #13629 but this was deployed to production, so I'm going to close this.

[mallenexpensify]

@thesahindia can you please accept the job and reply here once you have?
https://www.upwork.com/jobs/~01e011fc436edaf3d0

[thesahindia]

Accepted, thanks!

[mallenexpensify]

Paid @thesahindia , closing cuz this shouldn't need regression test steps