Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide the composer when message is edited #7390

Merged
merged 6 commits into from
Feb 8, 2022

Conversation

parasharrajat
Copy link
Member

@parasharrajat parasharrajat commented Jan 25, 2022

Details

Fixed Issues

$ #7265

Tests | QA Steps

  1. Open app
  2. Navigate to any chat
  3. Send messages
  4. Hit Edit to make any changes
  • Verify that no errors appear in the JS console

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web | Desktop

screen-2022-02-08_01.38.56.mp4

Mobile Web

iOS

Android

@parasharrajat parasharrajat marked this pull request as ready for review February 4, 2022 15:17
@parasharrajat parasharrajat requested a review from a team as a code owner February 4, 2022 15:17
@MelvinBot MelvinBot removed the request for review from a team February 4, 2022 15:18
@stitesExpensify stitesExpensify merged commit cb5a30f into Expensify:main Feb 8, 2022
@OSBotify
Copy link
Contributor

OSBotify commented Feb 8, 2022

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify
Copy link
Contributor

OSBotify commented Feb 9, 2022

🚀 Deployed to staging by @stitesExpensify in version: 1.1.38-0 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production by @Julesssss in version: 1.1.38-3 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants