Deploy Checklist: New Expensify 2022-02-09

[OSBotify]

Release Version: 1.1.38-3
Compare Changes: production...staging

This release contains changes from the following pull requests:

• PR 1: Moving EmojiPicker as an Independent Component #6977

  • QA
  • Accessibility

• Handle 666 errors in Policy.removeMembers #7229

  • QA
  • Accessibility

• Changed Profile Picture save on click of Save button #7366

  • QA
  • Accessibility

• Hide the composer when message is edited #7390

  • QA
  • Accessibility

• Remove extra margin from close account button #7419

  • QA
  • Accessibility

• pointer on top within close account page #7498

  • QA
  • Accessibility

• make resend button smaller #7532

  • QA
  • Accessibility

• Delete bank account key from bankAccountList #7557

  • QA
  • Accessibility

• Add tooltip over copy icon in reimburse expenses page #7560

  • QA
  • Accessibility

• Secure our Electron implementation #7567

  • QA
  • Accessibility

• Uploaded image preview placeholder #7569

  • QA
  • Accessibility

• fix: prevent chat getting scrolled on closing image modal #7575

  • QA
  • Accessibility

• [NoQA] Update the comments for getTooltipShiftX #7593

  • QA
  • Accessibility

• fix: When typing password, view password is disabled  #7599

  • QA
  • Accessibility

• Move utils file to the test utils directory #7603

  • QA
  • Accessibility

• Dismiss keyboard when transitioning to ResendValidationForm page #7604

  • QA
  • Accessibility

• Cleanup unnecessary index.js files #7610

  • QA
  • Accessibility

• [No QA] Add guidance for boolean props and variables #7611

  • QA
  • Accessibility

• Add styles for multiline input #7612

  • QA
  • Accessibility

• [Transfer Balance] Don't force account selection when there is only one option #7615

  • QA
  • Accessibility

• Revert "Separate report name and icon configuration from personal details" #7631

  • QA
  • Accessibility

• Optimize loops in formatting personal details #7649

  • QA
  • Accessibility

• [CP Stg] Fix CORS errors in desktop application #7665

  • QA
  • Accessibility

• [CP Stg] Fix electron build #7685

  • QA
  • Accessibility

Deploy Blockers:

• Infinite Spinner displayed after Log out and log back in  #7659

cc @Expensify/applauseleads

[OSBotify]

🚀 All staging deploys are complete, @Expensify/applauseleads please begin QA on version https://github.com/Expensify/App/releases/tag/1.1.38-1 🚀

[mvtglobally]

@roryabraham This is a Major blocker preventing us from testing. #7659 It would be great if team can look at it with priority

[roryabraham]

Hi @mvtglobally I have been working on fixing the blocker, but I would expect that it's only affecting desktop. Is that correct?

[mvtglobally]

@roryabraham asking team to cross check all platforms. I was stuck on Desktop and iOS. Web is extremely slow, but we were able to log in

[roryabraham]

Thanks. We're working on it 😅

[mvtglobally]

@roryabraham we confirmed, it's only affecting Desktop app. Should we hold the testing until the fix is up?

[roryabraham]

Feel free to proceed with testing other platforms. I've got a PR to fix the desktop issue, but it's pending reviews, so won't be deployed today.

[roryabraham]

Hello, as soon as this build is done you should be able to begin testing on desktop

[roryabraham]

Testing going better now? Let me know if you're still having serious issues

[mvtglobally]

We are finishing up just few Desktop TCs and PRs. Should be done soon. The Newest build also resolved the Workspace issue we were facing, so we have additional workspace TCs team is re-testing too

[mvtglobally]

Regression is complete
#7557 is blocked by #7270
Need additional info on #7229 (comment) to finish validating this PR
Checking off #7685 & #7665 they pass
Checking #7649 & #6715 with additional info provided

Issues logged
#7675
#7678
#7679
#7686
#7687
#7688
#7712
#7715

[Julesssss]

Hi @mvtglobally, I'll be working on the deploy checklist this week.

It looks like the remaining blockers are:

• Delete bank account key from bankAccountList #7557 blocked by mWeb - VBA - Error message appears after submitting all required info in Onfido flow #7270 --> it isn't always reproducible, not sure if this should be a blocker or not
• Handle 666 errors in Policy.removeMembers #7229 awaiting information, I have commented on the issue to bump the question
• Infinite Spinner displayed after Log out and log back in  #7659 which looks like it has been fixed 🤞

Please let me know if I missed anything! Hopefully we can close these out shortly.

[mvtglobally]

@Julesssss Checked off #7659 & #7649 - it is pass
#7615 - We are struggling to test this. We are stuck at Onfido flow and unable to validate anything with "Transfer Balance" feature as such. Can this be done internally? I will share more info and screenshots in ticket directly
Checked off #7557. Its only repro on mWeb and it was there before this build too.

[Julesssss]

Can this be done internally?
Yeah possibly that is enough, but let me test this tomorrow morning and we'll revisit.

[mvtglobally]

checking of #7229

[marcaaron]

Checking off #7615

[Julesssss]

Fantastic, that was the last of the QA checks.

[Julesssss]

Just checking that we're not yet doing accessibility QA. I think not, but want to be 100% sure before running the prod deploy.

[Julesssss]