Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dismiss keyboard when transitioning to ResendValidationForm page #7604

Merged
merged 1 commit into from
Feb 7, 2022

Conversation

luacmartins
Copy link
Contributor

@luacmartins luacmartins commented Feb 7, 2022

Details

Dismisses the keyboard when transitioning to ResendValidationForm page.

Note: mobile Safari seems to behave differently as inputs are not focused on render and because of that, I did not include testing for mWeb.

Fixed Issues

$ #7199

Tests

  1. On the login page, type an existing account email and tap Continue.
  2. Verify that the keyboard is NOT dismissed and you are focused on the password input.
  3. Tap Go back
  4. Enter another email, this time for an inexistent account.
  5. Verify that the keyboard is dismissed when transitioning to the ResendValidationForm page.
  • Verify that no errors appear in the JS console

QA Steps

Steps above.

  • Verify that no errors appear in the JS console

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

Mobile Web

Desktop

iOS

ios.mov

Android

android.mov

@luacmartins luacmartins self-assigned this Feb 7, 2022
@luacmartins luacmartins marked this pull request as ready for review February 7, 2022 18:17
@luacmartins luacmartins requested a review from a team as a code owner February 7, 2022 18:17
@MelvinBot MelvinBot requested review from AndrewGable and removed request for a team February 7, 2022 18:17
@luacmartins
Copy link
Contributor Author

Self-merging with approval!

@luacmartins luacmartins merged commit 442b9fc into main Feb 7, 2022
@luacmartins luacmartins deleted the cmartins-dismissKeyboardOnLoginPage branch February 7, 2022 18:45
@OSBotify
Copy link
Contributor

OSBotify commented Feb 7, 2022

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify
Copy link
Contributor

OSBotify commented Feb 9, 2022

🚀 Deployed to staging by @luacmartins in version: 1.1.38-0 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production by @Julesssss in version: 1.1.38-3 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@rushatgabhane
Copy link
Member

rushatgabhane commented Dec 16, 2022

Hi, just dropping a note that this PR introduced a bug - #13044 (comment)

The keyboard should close only when transitioning to ResetValidationForm, and not when transitioning to PasswordPage.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants