Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add styles for multiline input #7612

Merged
merged 1 commit into from
Feb 8, 2022
Merged

Conversation

luacmartins
Copy link
Contributor

Details

Makes multiline text input expand to the container height.

Fixed Issues

$ #7589

Tests

  1. Log into the app
  2. Navigate to Settings > Workspace > Manage members > Invite
  3. Start typing in the custom message field and verify that the text is aligned to the top.
  • Verify that no errors appear in the JS console

QA Steps

Steps above.

  • Verify that no errors appear in the JS console

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

web.mov

Mobile Web

mweb.mov

Desktop

desktop.mov

iOS

ios.mov

Android

android.mov

@luacmartins luacmartins requested a review from a team as a code owner February 7, 2022 21:35
@luacmartins luacmartins self-assigned this Feb 7, 2022
@MelvinBot MelvinBot requested review from yuwenmemon and removed request for a team February 7, 2022 21:35
@luacmartins luacmartins changed the title add styles for multiline input Add styles for multiline input Feb 7, 2022
@yuwenmemon yuwenmemon merged commit 78d6e68 into main Feb 8, 2022
@yuwenmemon yuwenmemon deleted the cmartins-fixMultiLineInputStyle branch February 8, 2022 02:47
@OSBotify
Copy link
Contributor

OSBotify commented Feb 8, 2022

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify
Copy link
Contributor

OSBotify commented Feb 9, 2022

🚀 Deployed to staging by @yuwenmemon in version: 1.1.38-0 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production by @Julesssss in version: 1.1.38-3 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants