Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CP Stg] Fix electron build #7685

Merged
merged 1 commit into from
Feb 10, 2022
Merged

[CP Stg] Fix electron build #7685

merged 1 commit into from
Feb 10, 2022

Conversation

roryabraham
Copy link
Contributor

@roryabraham roryabraham commented Feb 10, 2022 •
edited
Loading

Details

Fixes the local build. I added another file during a PR review but did not retest. Shame on me!

Fixed Issues

n/a – slack: https://expensify.slack.com/archives/C01GTK53T8Q/p1644527286837309

Tests

  1. Comment out these lines
  2. Run npm run desktop-build
  3. Install the app that's now in dist/NewExpensify.dmg
  4. Verify it runs without showing a big ol JS errror.
  • Verify that no errors appear in the JS console

QA Steps

You should be able to update the desktop app without seeing this error:

image

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

Mobile Web

Desktop

image

iOS

Android

@roryabraham roryabraham self-assigned this Feb 10, 2022
@github-actions
Copy link
Contributor

⚠️ ⚠️ Heads up! This pull request has the CP Staging label. ⚠️ ⚠️
Merging it will cause it to be immediately deployed to staging, even if the open StagingDeployCash deploy checklist is locked.

@Beamanator Beamanator self-requested a review February 10, 2022 21:22
@roryabraham roryabraham marked this pull request as ready for review February 10, 2022 21:27
@roryabraham roryabraham requested a review from a team as a code owner February 10, 2022 21:27
@MelvinBot MelvinBot requested review from joelbettner and removed request for a team February 10, 2022 21:28
Beamanator
Beamanator approved these changes Feb 10, 2022
View reviewed changes
Copy link
Contributor

@Beamanator Beamanator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, tests well 👍

@roryabraham roryabraham merged commit 9be837f into main Feb 10, 2022
@roryabraham roryabraham deleted the Rory-FixDesktopBuild branch February 10, 2022 22:20
OSBotify pushed a commit that referenced this pull request Feb 10, 2022
@roryabraham @OSBotify
Merge pull request #7685 from Expensify/Rory-FixDesktopBuild
939483a 
(cherry picked from commit 9be837f)
This was referenced Feb 10, 2022
Merged
Closed
@OSBotify
Copy link
Contributor

🚀 Cherry-picked to staging by @roryabraham in version: 1.1.38-3 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

@roryabraham roryabraham mentioned this pull request Feb 11, 2022
Closed
@OSBotify
Copy link
Contributor

🚀 Deployed to production by @Julesssss in version: 1.1.38-3 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify OSBotify mentioned this pull request Feb 16, 2022
Closed
85 tasks
@OSBotify OSBotify mentioned this pull request Aug 16, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Beamanator Beamanator Beamanator approved these changes

@joelbettner joelbettner Awaiting requested review from joelbettner

Assignees

@roryabraham roryabraham

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@roryabraham @OSBotify @Beamanator