Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tooltip over copy icon in reimburse expenses page #7560

Merged
merged 2 commits into from
Feb 7, 2022

Conversation

sobitneupane
Copy link
Contributor

@sobitneupane sobitneupane commented Feb 4, 2022

Details

Added tooltip over copy icon in "Reimburse expenses" page. Issue is occurring in Web and Desktop App.

Fixed Issues

$ #7466

Tests

  • Settings > Workspace > Reimburse expenses
  • Hover over copy icon in Capture receipts section

QA Steps

  • Settings > Workspace > Reimburse expenses
  • Hover over copy icon in Capture receipts section

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

Screenshot from 2022-02-04 14-58-20

Mobile Web

Desktop

iOS

Android

@sobitneupane sobitneupane requested a review from a team as a code owner February 4, 2022 09:46
@MelvinBot MelvinBot requested review from thienlnam and removed request for a team February 4, 2022 09:46
@sobitneupane
Copy link
Contributor Author

sobitneupane commented Feb 4, 2022

There is 'MODULE_NOT_FOUND' error in E2E iOS Tests. I don't think my change in code can produce the error.
Screenshot from 2022-02-04 17-12-10

@thienlnam
Copy link
Contributor

Could you try pulling main into your branch and seeing if that fixes the tests?

@sobitneupane
Copy link
Contributor Author

Could you try pulling main into your branch and seeing if that fixes the tests?

Thank you.

@thienlnam thienlnam merged commit 6976b4a into Expensify:main Feb 7, 2022
@OSBotify
Copy link
Contributor

OSBotify commented Feb 7, 2022

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify
Copy link
Contributor

OSBotify commented Feb 9, 2022

🚀 Deployed to staging by @thienlnam in version: 1.1.38-0 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production by @Julesssss in version: 1.1.38-3 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants