Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove extra margin from close account button #7419

Merged
merged 2 commits into from
Feb 8, 2022

Conversation

parasharrajat
Copy link
Member

Details

Fixed Issues

$ #7378

Tests | QA Steps

  1. Open the app
  2. Navigate to Settings>Security>Close Account
  3. Check Close Button
  • Verify that no errors appear in the JS console

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web | Mobile Web | Desktop

image

iOS

Android

@parasharrajat parasharrajat requested a review from a team as a code owner January 26, 2022 13:25
@MelvinBot MelvinBot requested review from Julesssss and removed request for a team January 26, 2022 13:25
@parasharrajat
Copy link
Member Author

cc: @Julesssss let me know if you are waiting for the rest of the screenshots. Otherwise it's ready.

@Julesssss
Copy link
Contributor

Oh sorry, I completely missed this one.

@parasharrajat
Copy link
Member Author

cc: @Julesssss This is ready for merge.

@parasharrajat
Copy link
Member Author

@Julesssss I think this can be merged.

@Julesssss Julesssss merged commit 2ee7820 into Expensify:main Feb 8, 2022
@Julesssss
Copy link
Contributor

Yep. Sorry, I lost the issue again.

@OSBotify
Copy link
Contributor

OSBotify commented Feb 8, 2022

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify
Copy link
Contributor

OSBotify commented Feb 9, 2022

🚀 Deployed to staging by @Julesssss in version: 1.1.38-0 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production by @Julesssss in version: 1.1.38-3 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants