[HOLD for payment 2023-04-03] [Hold - Upstream fix Plaid #512][$1000] DEV - console error Warning: Internal React error: Attempted to capture when clicking X button in "Connect to bank account" page

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Go to Settings > workspace > Connect bank account > Connect connect online with Plaid
2. click ❌ button

Expected Result:

should not show any console error

Actual Result:

shows console error on click ❌ button

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• iOS / native

Version Number: v1.2.45-0(main branch)
Reproducible in staging?:
Reproducible in production?:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:

Simulator.Screen.Recording.-.iPhone.13.mini.-.2022-12-30.at.17.06.19.mp4

Expensify/Expensify Issue URL:
Issue reported by: @gadhiyamanan
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1672400428847699

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01090ed9dedf023458
• Upwork Job ID: 1615420052392824832
• Last Price Increase: 2023-02-02

[michaelhaxhiu]

Hmm this is likely indicative of an underlying bug/error in the prod environment. I'm not able to reproduce this one as a non-eng, so I'm going to move it forward to add an engineer and C+ for their input.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0190503effb217223c

[melvin-bot]

Triggered auto assignment to Contributor Plus for review of internal employee PR - @sobitneupane (Internal)

[melvin-bot]

Triggered auto assignment to @luacmartins (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[sobitneupane]

Hmm this is likely indicative of an underlying bug/error in the prod environment. I'm not able to reproduce this one as a non-eng, so I'm going to move it forward to add an engineer and C+ for their input.

I was able to reproduce. Console Warnings appear only on Dev.

[michaelhaxhiu]

Perfect thanks sobit! That works as a proxy check 👍 and I think we are fixing these types of issues too

[michaelhaxhiu]

@luacmartins lmk if you think this is best handled internally or externally

[luacmartins]

We can go external with this

[melvin-bot]

Current assignee @michaelhaxhiu is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Current assignee @sobitneupane is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Current assignee @luacmartins is eligible for the External assigner, not assigning anyone new.

[s77rt]

Proposal

plaid/react-native-plaid-link-sdk#512

RCA

The issue is in react-native-plaid-link-sdk
Please check the PR for more info

[luacmartins]

It seems like the fix is in the external lib. There's an open PR against it, but no movement there yet.

[s77rt]

PR is ready.

---

@luacmartins @michaelhaxhiu Can you please update:

1. Upwork job as current one is expired
2. The issue title (remove the hold)

[luacmartins]

Ah nice! I'll check the PR tomorrow! Thank you!

[MelvinBot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[MelvinBot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.2.89-0 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Updated react-native-plaid-link-sdk to fix unwanted warnings #16361

If no regressions arise, payment will be issued on 2023-04-03. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter - gadhiyamanan - $250
• Contributor that fixed the issue - @s77rt - $1500
• Contributor+ that helped on the issue and/or PR - @sobitneupane - $1500

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[MelvinBot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@s77rt / @sobitneupane / @luacmartins] The PR that introduced the bug has been identified. Link to the PR:
• [@s77rt / @sobitneupane / @luacmartins] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@s77rt / @sobitneupane / @luacmartins] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@michaelhaxhiu] Determine if we should create a regression test for this bug.
• [@s77rt / @sobitneupane] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@michaelhaxhiu] Link the GH issue for creating/updating the regression test once above steps have been agreed upon: https://github.com/Expensify/Expensify/issues/281874

[luacmartins]

@s77rt @sobitneupane could either of you please fill the checklist above?

[s77rt]

• The PR that introduced the bug has been identified: N/A This is a bug upstream
• The offending PR has been commented on: N/A
• A discussion in #expensify-bugs has been started: I think this does not apply here

---

Regression Test Proposal

1. Login to App
2. Go to Settings > Workspaces > any workspace > Connect bank account > Connect connect online with Plaid
3. Click X button
4. Verify that you don't get this error: Internal React error: Attempted to capture a commit phase error inside a detached tree.

Note: Step 4 would ideally be: "4. Verify that you don't get any error" however there are some other errors at the moment that are unrelated to this PR.

[MelvinBot]

@michaelhaxhiu, @s77rt, @luacmartins, @sobitneupane Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[MelvinBot]

@michaelhaxhiu, @s77rt, @luacmartins, @sobitneupane Whoops! This issue is 2 days overdue. Let's get this updated quick!

[s77rt]

I think we are waiting for @michaelhaxhiu to complete the checklist

[MelvinBot]

@michaelhaxhiu, @s77rt, @luacmartins, @sobitneupane Whoops! This issue is 2 days overdue. Let's get this updated quick!

[s77rt]

@michaelhaxhiu @luacmartins Can you please help on processing the payment here? The listed Upwork job is expired

[MelvinBot]

@michaelhaxhiu, @s77rt, @luacmartins, @sobitneupane Whoops! This issue is 2 days overdue. Let's get this updated quick!

[s77rt]

Same ^ cc @michaelhaxhiu @luacmartins

[luacmartins]

@michaelhaxhiu can you help with payment here?

[MelvinBot]

@michaelhaxhiu, @s77rt, @luacmartins, @sobitneupane Whoops! This issue is 2 days overdue. Let's get this updated quick!

[michaelhaxhiu]

Sorry for the delay everyone. Looking now.

[michaelhaxhiu]

Re-posted the job on upwork here:
https://www.upwork.com/jobs/~018c6f2a3bd3e49766

Invited all 3 to the job:
External issue reporter - @gadhiyamanan - $250
Contributor that fixed the issue - @s77rt - $1500
Contributor+ that helped on the issue and/or PR - @sobitneupane - $1500

[michaelhaxhiu]

I think I made a mistake. It should be $1500 for the C and C+. Not $2000. Fixing that.

[michaelhaxhiu]

all paid and correct. Closing