replaced deprecated removeEventListener() with remove() #512
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
same issue on RN 0.70.4 |
Magminder
approved these changes
Jan 18, 2023
youssdevx
approved these changes
Feb 2, 2023
jetaix
approved these changes
Feb 2, 2023
SialB
approved these changes
Feb 2, 2023
6 tasks
dtroupe-plaid
approved these changes
Mar 14, 2023
|
Thank you! @dtroupe-plaid |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
removeEventListeneris deprecated and now it's removed with RN 0.71.Besides it causes a problem on unmounting the component:
Warning: Internal React error: Attempted to capture a commit phase error inside a detached tree.