Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tracking] Make Emojis WhatsAppQuality #14163

Closed
stitesExpensify opened this issue Jan 9, 2023 · 38 comments
Closed

[Tracking] Make Emojis WhatsAppQuality #14163

stitesExpensify opened this issue Jan 9, 2023 · 38 comments
Assignees
Labels
Engineering NewFeature Something to build that is a new item. Weekly KSv2

Comments

@stitesExpensify
Copy link
Contributor

stitesExpensify commented Jan 9, 2023

Old (unreviewed) doc with mock-ups

Outstanding WAQ

Downstream polish

Done

@melvin-bot melvin-bot bot locked and limited conversation to collaborators Jan 9, 2023
@stitesExpensify
Copy link
Contributor Author

New issue in our public repo, Old tracking issue with discussion is here https://github.com/Expensify/Expensify/issues/239104

@stitesExpensify stitesExpensify added Weekly KSv2 Improvement Item broken or needs improvement. Engineering labels Jan 9, 2023
@JmillsExpensify
Copy link

At this point we're officially done with all our unheld WAQ issues, so awesome work so far! The next step we're embarking on it tackling the polish items listed above – starting with #14098 and #12188.

@JmillsExpensify
Copy link

Both of those will be worked on by Margelo. Then I believe that @stitesExpensify is taking on #239100, which add an emoji category picker.

@puneetlath puneetlath removed their assignment Jan 17, 2023
@melvin-bot melvin-bot bot added the Overdue label Jan 19, 2023
@stitesExpensify
Copy link
Contributor Author

This is moving along! Margelo has assigned the 2 smaller issues, and are actively working on the design doc for Reactions!

Also, I created this GitHub Project (internal only unfortunately) for myself for visual tracking if it helps anybody else. I will keep the project status updated both there and in this issue.

@melvin-bot melvin-bot bot removed the Overdue label Jan 19, 2023
@melvin-bot melvin-bot bot added the Overdue label Jan 30, 2023
@stitesExpensify
Copy link
Contributor Author

Still moving forward! The detailed design doc is in progress for Emoji Reactions, and I asked for an update on auto-complete here #12188 (comment)

@melvin-bot melvin-bot bot removed the Overdue label Jan 30, 2023
@melvin-bot melvin-bot bot added the Overdue label Feb 7, 2023
@stitesExpensify
Copy link
Contributor Author

Design doc for Emoji Reactions has released the detailed implementation and is being reviewed
Auto-complete and mobile search are both in review

@melvin-bot melvin-bot bot removed the Overdue label Feb 7, 2023
@melvin-bot melvin-bot bot added the Overdue label Feb 16, 2023
@JmillsExpensify
Copy link

Tons of progress happening in this issue. The category picker hit staging (maybe even production by now). A PR is in place for single emojis being larger, same for emoji code auto-suggestions. At that point, we'll be ready to pick up the remaining items on this list, though there are admittedly not many.

@melvin-bot melvin-bot bot removed the Overdue label Feb 16, 2023
@melvin-bot melvin-bot bot added the Overdue label Feb 24, 2023
@JmillsExpensify
Copy link

Largely the same as above. Lots of progress in the linked issues in the downstream polish section. Check those for the specific details.

@melvin-bot melvin-bot bot removed the Overdue label Feb 27, 2023
@melvin-bot melvin-bot bot added the Overdue label Mar 7, 2023
@stitesExpensify
Copy link
Contributor Author

Mobile Search - Actively being worked on and reviewed in PR
Emoji Autosuggestion - Has an approval, but 1 small bug was found
Stickers - I have not started this yet, not a priority
Efficiently store and search for emojis - Needs a design doc, not a priority
Make emojis larger when alone - In review, currently lots of conflicts
Add tooltip for category picker - Merged!
Add emoji reactions - Final review, should be merged first thing tomorrow morning to get it out for ExpensiconX

@melvin-bot melvin-bot bot removed the Overdue label Mar 7, 2023
@conorpendergrast
Copy link
Contributor

Hey! In the announcement email today, I see this is a known issue:

The hover bar of emojis has the wrong icon (no plus button)

That was also reported in this issue, and I can't see a reference to it here. Is there an existing bug report for it? If there isn't, I'll just use #15812 for that! Thanks!

@melvin-bot melvin-bot bot removed the Overdue label May 19, 2023
@melvin-bot melvin-bot bot added the Overdue label May 29, 2023
@stitesExpensify
Copy link
Contributor Author

The only WAQ issue still open is on hold for an issue on hold for another issue so that will take a while. The rest is just polish

@melvin-bot melvin-bot bot removed the Overdue label May 29, 2023
@melvin-bot melvin-bot bot added the Overdue label Jun 7, 2023
@stitesExpensify
Copy link
Contributor Author

Same update as last week.

@melvin-bot melvin-bot bot removed the Overdue label Jun 7, 2023
@melvin-bot melvin-bot bot added the Overdue label Jun 15, 2023
@JmillsExpensify
Copy link

One issue knocked off the list. The emoji reactions issue shouldn't be far behind.

@melvin-bot melvin-bot bot removed the Overdue label Jun 21, 2023
@melvin-bot melvin-bot bot added the Overdue label Jun 29, 2023
@JmillsExpensify
Copy link

I think we should close this one out as soon as the issue for emoji reactions closes.

@melvin-bot melvin-bot bot removed the Overdue label Jul 5, 2023
@stitesExpensify
Copy link
Contributor Author

Agreed!

@melvin-bot melvin-bot bot added the Overdue label Jul 13, 2023
@JmillsExpensify
Copy link

Still waiting on that one last emoji issue.

@melvin-bot melvin-bot bot removed the Overdue label Jul 19, 2023
@melvin-bot melvin-bot bot added the Overdue label Jul 27, 2023
@stitesExpensify
Copy link
Contributor Author

We are very very close! There are a couple of regressions that popped up from the big migration to the new way of emoji reacting, and then we can close this out!

@melvin-bot melvin-bot bot removed the Overdue label Jul 28, 2023
@melvin-bot melvin-bot bot added the Overdue label Aug 7, 2023
@stitesExpensify
Copy link
Contributor Author

The final regressions are still being taken care of here

@melvin-bot melvin-bot bot removed the Overdue label Aug 8, 2023
@melvin-bot melvin-bot bot added the Overdue label Aug 21, 2023
@stitesExpensify
Copy link
Contributor Author

I'm thinking that it's time we close this out. The only things left are downstream polish, and Reactions is its own project. We have been able to send emojis on all platforms for a long time, and been able to react for months. IMO we don't need to track this as a project anymore. Thoughts @JmillsExpensify ?

@melvin-bot melvin-bot bot removed the Overdue label Aug 23, 2023
@melvin-bot melvin-bot bot added the Overdue label Sep 1, 2023
@JmillsExpensify
Copy link

Agreed, let's close it out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Engineering NewFeature Something to build that is a new item. Weekly KSv2
Projects
None yet
Development

No branches or pull requests

5 participants