[HOLD for payment 2023-02-22] Connect Bank Account - If user clicks disconnect bank account, the background modal goes blank

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Open the New Expensify App or website
2. Sign into a valid account
3. Tap on Profile > Workspace > Connect to bank account > Plaid option
4. Continue the flow until you reach the "One more thing" page.
5. Click on "Disconnect bank account" and observe the background modal

Expected Result:

The user expects that the background image continues to display even though the disconnect popup is shown

Actual Result:

The background modal is shown as a blank screen

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.2.59.1

Reproducible in staging?: Yes

Reproducible in production?: Yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug5911614_Background_disappears.mp4

Bug5911614_Background_also_disappears_on_web_.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

[JmillsExpensify]

Woah apologies this got lost in the shuffle. Triaging now.

[JmillsExpensify]

Alright this flow is hard to test, though I wasn't able to get this to successfully happen. @joekaufmanexpensify You're an expert in this flow. Do you mind going through this as well and seeing if you can reproduce using the steps above?

[trjExpensify]

Following. I've been assigned a very similar issue in the VBA flow today here, which has the same blank screen when launching the modal to "Start over": #14692

[MariaHCD]

The root cause here is the same as #14692 (comment)

Going to fix this as part of the PR for the other issue.

[joekaufmanexpensify]

Sure, happy to try and reproduce!

[joekaufmanexpensify]

Ah, okay, since this has the same root cause as the other issue, seems like we should be all set here. I did test the "start over" behavior though and got the blank screen. So this is def an issue generally:

[JmillsExpensify]

Ok great, closing this one then in favor of #14692

[MelvinBot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[MelvinBot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.2.71-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix blank screen when showing the WorkspaceResetBankAccount modal #14726

If no regressions arise, payment will be issued on 2023-02-22. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[MelvinBot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@MariaHCD] The PR that introduced the bug has been identified. Link to the PR:
• [@MariaHCD] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@MariaHCD] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@MariaHCD] Propose regression test steps to ensure the same bug will not reach production again.
• [@JmillsExpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[MariaHCD]

This issue was closed in favor of #14692 since the root cause of the issue was the same.

Anyhow, the BZ checklist is being completed here: #14692 (comment)