[HOLD for payment 2023-02-13] Messages disappear for a while before re-appearing

[trjExpensify]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Send a message
2. Wait around 30 seconds

Expected Result:

Your recently sent messages never disappear

Actual Result:

Your sent message will disappear for a noticeable amount of time and eventually re-appear

Workaround:

None

Platforms:

Which of our officially supported platforms is this issue occurring on?
All

Version Number: v1.2.63-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:

Screen.Recording.2023-02-01.at.13.47.59.mov

Expensify/Expensify Issue URL:
Issue reported by: @JmillsExpensify
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1675280489536649

View all open jobs on GitHub

[melvin-bot]

Current assignee @iwiznia is eligible for the Engineering assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to @johncschuster (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[iwiznia]

I hate that comment is useless 99% of time, there was no regression here.

[MelvinBot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[MelvinBot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.2.65-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Add a generic error in failureData of AddComment #14736

If no regressions arise, payment will be issued on 2023-02-13. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[MelvinBot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@iwiznia] The PR that introduced the bug has been identified. Link to the PR:
• [@iwiznia] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@iwiznia] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@iwiznia] Propose regression test steps to ensure the same bug will not reach production again.
• [@trjExpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[iwiznia]

I don't think we need to do any of that in this case. Do you agree @trjExpensify ?

[trjExpensify]

• Payments: None to handle, this was a Web-E PR and reviewed/reported internally.
• Regression test: We already have one for adding comments, so this should be caught with that
• Offending PR: do we know where this came from @iwiznia? API refactors? pattern b? sequence numbers etc? It would be good to surface on the PR if we haven't already (or it wasn't patternB and you author'd it.. haha)
• How to avoid it again in the future: I'm open to any ideas here, what's your take?

[iwiznia]

Offending PR: do we know where this came from @iwiznia? API refactors? pattern b? sequence numbers etc? It would be good to surface on the PR if we haven't already (or it wasn't patternB and you author'd it.. haha)

Not sure which exact PR broke this, but it was part of deprecate sequence numbers and was worked on by us, so no deduction from payment is needed. I already cced in the PR the authors of that doc so they are aware of this.

How to avoid it again in the future: I'm open to any ideas here, what's your take?

No take. Bugs are bound to be added when doing big refactors like the sequence numbers project.

[trjExpensify]

Cool, so that works for me if it has been put on their radar. Closing!

[sobitneupane]

@trjExpensify Payment for C+ review is due for reviewing the PR.

[trjExpensify]

Ah, I see. Sent you an offer.

[sobitneupane]

Thanks @trjExpensify. Accepted the offer.

[trjExpensify]

Cool, settled!