Chat - Error message appears when uploaded the PDF file offline

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Launch App or go to staging.new.expensify.com/
2. Login with any account
3. Go to any chat
4. Disable the internet connection in the device
5. Send PDF file to the conversation
6. Wait a few seconds and go back online

Expected Result:

After returning to online, the attachment must be display

Actual Result:

Error message appears when uploaded the PDF file offline

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.2.65.0

Reproducible in staging?: Yes

Reproducible in production?: No

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug5924920_Screen_Recording_20230204_202657_New_Expensify.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @Luke9389 (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[mountiny]

So I am actually wondering if the upload has been working in production, since we added this change #14736 to introduced this generic upload failure message (hence why it cannot be reproduced in production). So maybe this fails in production as well but we just did not handle the failure correctly so this would be error of its own. cc @iwiznia

[iwiznia]

The error message should not be shown unless the request failed, so I don't think that's the issue?

[mountiny]

I was not able to reproduce, asking for help here

[iwiznia]

Can't reproduce either

[aldo-expensify]

In the video we see that they upload first and then disable the connection while the upload has not finished yet. This is slightly different than the step described because the request was sent, maybe that is why you couldn't reproduce.

I don't think we are supposed to handle this case so I agree with closing.