Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deploy Checklist: New Expensify 2023-02-03 #14833

Closed
19 tasks done
OSBotify opened this issue Feb 3, 2023 · 18 comments
Closed
19 tasks done

Deploy Checklist: New Expensify 2023-02-03 #14833

OSBotify opened this issue Feb 3, 2023 · 18 comments
Assignees
Labels
Daily KSv2 🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging StagingDeployCash

Comments

@OSBotify
Copy link
Contributor

OSBotify commented Feb 3, 2023

Release Version: 1.2.65-2
Compare Changes: production...staging

This release contains changes from the following pull requests:

Deploy Blockers:

Deployer verifications:

  • I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
  • I checked Firebase Crashlytics and verified that this release does not introduce any new crashes. More detailed instructions on this verification can be found here.

cc @Expensify/applauseleads

@melvin-bot melvin-bot bot locked and limited conversation to collaborators Feb 3, 2023
@mvtglobally mvtglobally added the 🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging label Feb 4, 2023
@OSBotify
Copy link
Contributor Author

OSBotify commented Feb 4, 2023

🚀 All staging deploys are complete, @Expensify/applauseleads please begin QA on version https://github.com/Expensify/App/releases/tag/1.2.65-0 🚀

@mountiny
Copy link
Contributor

mountiny commented Feb 6, 2023

Checking #14757 off since it was fixed by #14823

@mountiny
Copy link
Contributor

mountiny commented Feb 6, 2023

Checking #14826 off since that was a straight revert of a previous PR.

@mountiny mountiny self-assigned this Feb 6, 2023
@mountiny
Copy link
Contributor

mountiny commented Feb 6, 2023

checking #14780 off since we were not able to reproduce

@mountiny
Copy link
Contributor

mountiny commented Feb 6, 2023

Checking #14837 and #14847 off as we had merged and we are CPing fixed for both of them

@OSBotify
Copy link
Contributor Author

OSBotify commented Feb 6, 2023

👏 Heads up @Expensify/applauseleads 👏
A new pull request has been 🍒 cherry-picked 🍒 to staging, and will be deployed to staging in version 1.2.65-1 🚀

@mountiny mountiny added the Daily KSv2 label Feb 6, 2023
@OSBotify
Copy link
Contributor Author

OSBotify commented Feb 6, 2023

🎉 All set?…You bet! @Expensify/applauseleads https://github.com/Expensify/App/releases/tag/1.2.65-1 has been deployed to staging 🎉

@mvtglobally
Copy link

@mountiny Regression is completed.
We are validating last CP

#14738 is blocked on Native aps due to old KI #11796
Working in Slack to validate #14736

@mountiny
Copy link
Contributor

mountiny commented Feb 6, 2023

We also CPed this PR #14850 to fix one deploy blocker @mvtglobally.

@mvtglobally
Copy link

checking

@mvtglobally
Copy link

checking off #14736

@mvtglobally
Copy link

#14856 - checking off.
Need help with #14850 on Desktop and IOS

@mountiny
Copy link
Contributor

mountiny commented Feb 6, 2023

@mvtglobally Thank you! I will check #14850 off since due to the nature of the change, this should b platform agnostic and if we were able to confirm it works in some platforms it should be fine!

@mvtglobally
Copy link

@mountiny Having issue with Android now. Seem to stuck at account. No t sure though its PR related. Team is doublechecking

Screen_Recording_20230206_125948_New.Expensify.mp4

@mountiny
Copy link
Contributor

mountiny commented Feb 6, 2023

The PR should not be related to this.

@mvtglobally
Copy link

Issue #14875
We are good to go then

@mountiny
Copy link
Contributor

mountiny commented Feb 6, 2023

All cleared going to deploy now!

@mountiny
Copy link
Contributor

mountiny commented Feb 6, 2023

:shipit:

@mountiny mountiny closed this as completed Feb 6, 2023
@Expensify Expensify unlocked this conversation Mar 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Daily KSv2 🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging StagingDeployCash
Projects
None yet
Development

No branches or pull requests

4 participants