App crash on entering test amount on Test transaction page

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Go to any workspace
2. Connect bank manually
3. Select “Manually enter account details” and enter Routing number 011401533 and Account number 1111222233331111
4. Company Info - enter random info but complete all fields. You will fail once and get asked to double check information. Select “Save & Continue” again
5. Personal Info - use any test data. For last 4 SSN use 3333.
6. Beneficial Owners:

• Toggle terms and conditions
• Toggle confirmation that the information provided is true and accurate

7. Enter amount in test transaction page

Expected Result:

App doesn’t crash

Actual Result:

App crash with console error - amount.trim is not a function at ValidationStep.filterInput

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: v1.2.65-0
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:

Screen.Recording.2023-02-04.at.2.21.29.AM.1.mov

Recording.1448.mp4

Expensify/Expensify Issue URL:
Issue reported by: @rushatgabhane
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1675457749071149

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @mateocole (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @robertjchen (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[robertjchen]

I was able to reproduce this- it looks like amount might not always be a String, doing a toString() before trim() did the trick!

[robertjchen]

PR linked, working on tests

[mountiny]

PR merged!

[MelvinBot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[MelvinBot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.2.65-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Make sure amount is string before trimming #14850

If no regressions arise, payment will be issued on 2023-02-13. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[MelvinBot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@robertjchen] The PR that introduced the bug has been identified. Link to the PR:
• [@robertjchen] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@robertjchen] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@robertjchen] Propose regression test steps to ensure the same bug will not reach production again.
• [@mateocole] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[MelvinBot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.2.66-0 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Make sure amount is string before trimming #14850

If no regressions arise, payment will be issued on 2023-02-14. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[MelvinBot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@robertjchen] The PR that introduced the bug has been identified. Link to the PR:
• [@robertjchen] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@robertjchen] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@robertjchen] Propose regression test steps to ensure the same bug will not reach production again.
• [@mateocole] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[robertjchen]

Internal fix, removed above labels ^

[robertjchen]

re: BugZero checklist

This code existed 20 months ago in #3587 so it probably wasn't the cause, the next place to look at would be TextInput, BaseTextInput, and Form (which calls the validation) but nothing really stands out other than some recent styling changes. 🤔

The base react-native component returns a pure string, so somewhere along the line some type inference happens and we get a numeric type.

Either way, we'll probably have to do some git bisects to find the cause- given the limited scope, I don't think we should sink too much time into it beyond this. We can create a dedicated issue to hunt this down if it happens again- going to close this out for now.

[rushatgabhane]

@robertjchen @mateocole can you please re-open the issue for reporting bonus? Thanks

[robertjchen]

Ah, my bad I forgot- re-opened!

[mateocole]

here is a job to apply for https://www.upwork.com/jobs/~018c21815161da68ce

[mateocole]

sry forgot to tag you @rushatgabhane

[robertjchen]

Looks like this is all set!

[rushatgabhane]

@robertjchen @mateocole reporting bonus is left. please reopen

[mateocole]

@rushatgabhane all paid, apologies for the confusion i sent you a separate offer and withdrew it, but paid the contract in the link above!