[No QA] Revert linking to workflow run using upstream feature

[thienlnam]

Details

Fixed Issues

https://expensify.slack.com/archives/C03V9A4TB/p1675375863467309?thread_ts=1675369782.501749&cid=C03V9A4TB

Reverts #13121

Tests

• Verify that no errors appear in the JS console

Offline tests

QA Steps

• Verify that no errors appear in the JS console

PR Author Checklist

• I linked the correct issue in the ### Fixed Issues section above
• I wrote clear testing steps that cover the changes made in this PR
  • I added steps for local testing in the Tests section
  • I added steps for the expected offline behavior in the Offline steps section
  • I added steps for Staging and/or Production testing in the QA steps section
  • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
• I included screenshots or videos for tests on all platforms
• I ran the tests on all platforms & verified they passed on:
  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop
• I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
• I followed proper code patterns (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
  • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • I verified any copy / text that was added to the app is correct English and approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
  • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I followed the guidelines as stated in the Review Guidelines
• I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
• I verified that if a function's arguments changed that all usages have also been updated correctly
• If a new component is created I verified that:
  • A similar component doesn't exist in the codebase
  • All props are defined accurately and each prop has a /** comment above it */
  • The file is named correctly
  • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
  • The only data being stored in the state is data necessary for rendering and nothing else
  • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
  • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
  • All JSX used for rendering exists in the render method
  • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

[melvin-bot]

@stitesExpensify Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

[roryabraham]

Reviewer Checklist

• I have verified the author checklist is complete (all boxes are checked off).
• I verified the correct issue is linked in the ### Fixed Issues section above
• I verified testing steps are clear and they cover the changes made in this PR
  • I verified the steps for local testing are in the Tests section
  • I verified the steps for Staging and/or Production testing are in the QA steps section
  • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
• I checked that screenshots or videos are included for tests on all platforms
• I included screenshots or videos for tests on all platforms
• I verified tests pass on all platforms & I tested again on:
  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop
• If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
• I verified proper code patterns were followed (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • I verified any copy / text that was added to the app is correct English and approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
  • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I verified that this PR follows the guidelines as stated in the Review Guidelines
• I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
• I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
• If a new component is created I verified that:
  • A similar component doesn't exist in the codebase
  • All props are defined accurately and each prop has a /** comment above it */
  • The file is named correctly
  • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
  • The only data being stored in the state is data necessary for rendering and nothing else
  • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
  • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
  • All JSX used for rendering exists in the render method
  • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

[github-actions]

Performance Comparison Report 📊

Significant Changes To Duration

There are no entries

Meaningless Changes To Duration

Show entries

Name	Duration
App start TTI	680.607 ms → 709.823 ms (+29.216 ms, +4.3%)
App start runJsBundle	187.438 ms → 193.677 ms (+6.240 ms, +3.3%)
Open Search Page TTI	607.223 ms → 610.014 ms (+2.791 ms, ±0.0%)
App start regularAppStart	0.014 ms → 0.015 ms (+0.001 ms, +3.8%)
App start nativeLaunch	20.688 ms → 19.633 ms (-1.054 ms, -5.1%)

Show details

Name	Duration
App start TTI	Baseline Mean: 680.607 ms Stdev: 24.179 ms (3.6%) Runs: 640.2266469998285 642.6071939999238 647.8658920000307 650.4138699998148 651.8539450000972 657.473166000098 659.8962500002235 661.5644629998133 663.085607000161 663.4653380000964 664.6445800000802 665.7077239998616 667.5799759998918 668.1898779999465 675.8317430000752 677.7013090001419 684.3196649998426 684.3223109999672 684.9346239999868 687.7805860000663 690.565702999942 693.9109339998104 696.1306480001658 700.8605399997905 703.4074639999308 703.5379309998825 704.4400229998864 706.0915509997867 706.0983790000901 715.2782910000533 723.4381749997847 736.1866179998033 Current Mean: 709.823 ms Stdev: 25.616 ms (3.6%) Runs: 653.0717819998972 678.4775479999371 678.7721230001189 678.7880919999443 679.5087620001286 684.1687940000556 689.2503120000474 691.407155000139 694.3463940001093 695.0052840001881 699.7925840001553 701.5578760001808 703.7765080002137 703.8495049998164 705.7811170001514 707.1719720000401 707.6753179999068 708.236469999887 710.2013469999656 711.1781020001508 716.5946410000324 723.5606669997796 725.3225170001388 729.2445299997926 732.4910180000588 734.9715889999643 744.6040369998664 748.0714949998073 749.1300960001536 754.9517490002327 763.5442449999973
App start runJsBundle	Baseline Mean: 187.438 ms Stdev: 16.229 ms (8.7%) Runs: 147 163 170 171 171 172 172 174 176 177 180 182 182 183 186 187 188 189 190 191 193 195 197 200 200 203 203 205 206 207 207 231 Current Mean: 193.677 ms Stdev: 17.425 ms (9.0%) Runs: 163 169 170 173 174 176 180 184 185 185 186 186 188 190 190 192 193 193 194 194 195 200 205 206 206 207 212 218 226 231 233
Open Search Page TTI	Baseline Mean: 607.223 ms Stdev: 18.648 ms (3.1%) Runs: 575.6649580001831 579.3699139999226 586.48205600027 587.1375330002047 587.3107909997925 589.5578610002995 590.1312259999104 591.3417569999583 591.3529059998691 591.9388430002145 592.4519859999418 593.384237000253 596.0233970000409 603.8297529998235 607.9691570000723 608.5689699999057 609.4082439998165 609.5817060000263 610.5807289998047 611.4924730001949 612.291545000393 615.2240800000727 617.9307859996334 619.3079429999925 619.7732350002043 620.1784679996781 625.0583900003694 625.9142660000362 628.1587319998071 632.635743000079 647.7999669997953 653.2870280002244 Current Mean: 610.014 ms Stdev: 17.824 ms (2.9%) Runs: 582.7260340000503 584.8903409997001 585.809936999809 586.3086760002188 587.2504070000723 587.8254800001159 590.531413000077 592.7045489996672 598.5424399999902 599.3072919999249 601.4965420002118 603.5340179996565 605.2863770001568 605.4360770001076 605.8836670001037 607.434936999809 607.9245210001245 609.1598709998652 609.3265790003352 613.387614000123 615.6305749998428 616.7775880000554 618.0406500003301 619.9673259998672 622.5391040001996 623.0049650003202 627.3481439999305 627.8577069998719 629.8801269996911 631.9280189997517 634.4368900000118 641.7680259998888 656.5052490001544
App start regularAppStart	Baseline Mean: 0.014 ms Stdev: 0.000 ms (3.4%) Runs: 0.013387000188231468 0.0134680001065135 0.013794000260531902 0.0138349998742342 0.014119999948889017 0.014119999948889017 0.014240999706089497 0.014241000171750784 0.014322999864816666 0.014322999864816666 0.014404000248759985 0.014404000248759985 0.014525999780744314 0.014525999780744314 0.014566999860107899 0.014566999860107899 0.014607999939471483 0.014648000244051218 0.014688999857753515 0.014810999855399132 0.014811000321060419 0.014811000321060419 0.014852000400424004 0.014973999932408333 0.015056000091135502 0.015339999925345182 0.015503000002354383 Current Mean: 0.015 ms Stdev: 0.001 ms (5.2%) Runs: 0.013631999958306551 0.0138349998742342 0.013875000178813934 0.014078000094741583 0.0143630001693964 0.014364000409841537 0.014566999860107899 0.014567000325769186 0.01464799977838993 0.014648000244051218 0.014688999857753515 0.014688999857753515 0.0147299999371171 0.014851000159978867 0.014851999934762716 0.014973999932408333 0.01497400039806962 0.015056000091135502 0.015135999768972397 0.0152580002322793 0.01525900000706315 0.01537999976426363 0.015503000002354383 0.015583999920636415 0.015625 0.015746999997645617 0.016316999681293964 0.0165200000628829 0.016561000142246485 0.016642000060528517
App start nativeLaunch	Baseline Mean: 20.688 ms Stdev: 3.087 ms (14.9%) Runs: 17 17 18 18 18 18 18 18 18 18 19 19 19 19 19 19 20 20 21 21 21 21 22 22 23 23 24 24 26 26 27 29 Current Mean: 19.633 ms Stdev: 2.008 ms (10.2%) Runs: 17 17 18 18 18 18 18 18 18 18 19 19 19 19 19 19 19 19 20 20 20 20 21 21 21 22 22 22 24 26

[OSBotify]

🚀 Deployed to staging by https://github.com/roryabraham in version: 1.2.65-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

[OSBotify]

🚀 Deployed to production by https://github.com/mountiny in version: 1.2.65-2 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅