[$1000] Invite new members - Users is highlighted after selecting

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

Users is not highlighted after selecting

Expected Result:

Users is highlighted after selecting

Actual Result:

Unknown

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.2.64.3

Reproducible in staging?: Yes

Reproducible in production?: No

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Screen_Recording_20230202_195512_New.Expensify.mp4

Screen_Recording_20230202_194803_Chrome.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0162271ebdb95d5f22
• Upwork Job ID: 1621583687820718080
• Last Price Increase: 2023-02-03

[kbecciv]

Issue is not reproduced in production

Screen_Recording_20230202_195012_Chrome.mp4

[kbecciv]

Windows/Chrome is broken and has a different behavior. Next user is not highlighted after selecting one.

Recording.2105.mp4

[melvin-bot]

Triggered auto assignment to @jliexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0162271ebdb95d5f22

[melvin-bot]

Current assignee @jliexpensify is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @eVoloshchak (External)

[melvin-bot]

Triggered auto assignment to @deetergp (External), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[deetergp]

@kbecciv Can you please clarify what the problem is here? You've got videos illustrating three different behaviors and it's unclear which is the incorrect behavior and which, if any, is the desired behavior. I just tested Staging & Prod in macOS Chrome and both seem behave the same.

[kbecciv]

@deetergp This is correct behavior posted in here #14781 (comment), but staging is broken

[daraksha-dk]

I think this is the PR which caused the regression. Additionally I noticed the keyboard navigation is also broken now due to this PR. I think it's best to revert the changes since it's a deploy blocker & more regressions might appear due to this.

blocker.mp4

[attaching steps as well since the OP doesn't have it]

Steps to reproduce

1. Open the app
2. Create new group
3. Select 2 or more members
4. You'll notice that all selected the members are highlighted

cc: @deetergp @thienlnam

[melvin-bot]

Looks like something related to react-navigation may have been mentioned in this issue discussion.

As a reminder, please make sure that all proposals are not workarounds and that any and all attempt to fix the issue holistically have been made before proceeding with a solution. Proposals to change our DeprecatedCustomActions.js files should not be accepted.

Feel free to drop a note in #expensify-open-source with any questions.

[thienlnam]

Reverting the PR doesn't seem to fix it, going to remove the blocker on this and we can continue investigating

[thienlnam]

Actually this is resolved now, no longer reproducible after the deploy

[Tushu17]

Hey @thienlnam, I've reported this deploy blocker here :-
https://expensify.slack.com/archives/C049HHMV9SM/p1675358449465149

Is this eligible for reporting bonus?

[mountiny]

Yes @Tushu17

@jliexpensify Would you be able to help us issue payment to @Tushu17 of $250 for reporting this issue?

[rushatgabhane]

hold on, if reverting didn't fix it #14781 (comment)

What PR actually fixed this issue?

[thienlnam]

Honestly, not sure - the order of events was pretty weird

1. Was reproducible on staging
2. Reverted Revert 'fix: Timezone changes to some 1st option in the list while pressing the enter key' #14826 and was not able to reproduce anymore on that branch
3. Before merging the revert, it was no longer reproducible on staging
4. Was able to reproduce in the revert branch
5. Merged the revert
6. Still no longer reproducible in staging / prod

There must have been something CPed to staging at that time after I created my branch but doesn't explain why I couldn't reproduce it when I made my branch the first time (unless I was actually on main or something... was late on a friday). I think the contributor who added the PR I reverted, can re-add the changes and in testing verify that it doesn't create a regression of this

[rushatgabhane]

@thienlnam ohh that must have been confusing.
thank you for the details.

I'll re-add and verify if it creates the two deploy blockers

[jliexpensify]

Invited @Tushu17

[Tushu17]

@jliexpensify Okay, I've applied for the job. Thank you.

[jliexpensify]

Offer sent @Tushu17

[Tushu17]

@jliexpensify Offer accepted, Thanks.

[jliexpensify]

Paid Tushar, @rushatgabhane and @thienlnam do you want to keep this issue open for now?

[thienlnam]

This is no longer reproducible in prod, so we can close.

@rushatgabhane Lets take care of this - in the original issue #14314

[tienifr]

Regression Test Proposal

Bug: Invite new members - Users is highlighted after selecting

Proposed Test Steps:

• Open the app
• Open Workspace and go to the invite member page
• Select some members
• Verify that selected members aren't highlighted

Do we 👍 or 👎

Video (Regression Test):
https://user-images.githubusercontent.com/113963320/217418140-3cb8ccba-cdf6-4c41-b674-cd51628590af.mov