[HOLD for payment 2023-03-06] [$1000] Sign out - There is no cursor in the input field after sign out

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Go to URL https://staging.new.expensify.com/
2. Sign in any account
3. Go to Settings -> Sign out

Expected Result:

The cursor is present in the input field

Actual Result:

There is no cursor in the input field

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.2.65.0

Reproducible in staging?: Yes

Reproducible in production?: Yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug5926619_Recording__3607.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0168efd96a5e7f59ad
• Upwork Job ID: 1623336758522720256
• Last Price Increase: 2023-02-17

[melvin-bot]

Triggered auto assignment to @dylanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[dylanexpensify]

Replicated

[MelvinBot]

Job added to Upwork: https://www.upwork.com/jobs/~0168efd96a5e7f59ad

[MelvinBot]

Current assignee @dylanexpensify is eligible for the External assigner, not assigning anyone new.

[MelvinBot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @Santhosh-Sellavel (External)

[daraksha-dk]

Proposal

Please re-state the problem that we are trying to solve in this issue.

There is no cursor in the input field after we sign out.

What is the root cause of that problem?

This is happening because the input element is not ready for interaction when the .focus() method is being called - just after sign out.

What changes do you think we should make in order to solve the problem?

Instead of using this.input.focus() directly we can make use of InteractionManager
Eg.

        InteractionManager.runAfterInteractions(() => {
            this.input.focus();
        });

What alternative solutions did you explore? (Optional)

We can add some delay using setTimeout like 200ms

   setTimeout(() => {
             this.input.focus();
    }, 200);
    

[MelvinBot]

Triggered auto assignment to @Julesssss (External), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[Julesssss]

The first proposal sounds reasonable, but I'm not sure we should care too much about making this change. What do you think @dylanexpensify? I see your slack comments and while we probably should focus in this case, is it worth an $1000+ plus bounty?

[sayedulkrm]

Can you provide me with the main login page file link?

[hackykitty]

proposal

Dear Client
I’m very excited to assist you in making this project successful – please feel free to contact me directly to discuss this position further.
I can fix simply this issue.

In React Native, TextInput component has autoFocus props.

If true, focuses the input on componentDidMount or useEffect. The default value is false.

So if the autoFocus is set to true, everything will be fine.

I saw a lot of issues you submitted in Upwork.
Perfection and punctuality are my iron rules and I am confident that my hands-on experience, qualifications and proficiencies make me an excellent candidate for your project.
Looking forward your reply for the further discussion in details.
Thank you.

[Santhosh-Sellavel]

@hackykitty Please follow the proposal template in future.

[Santhosh-Sellavel]

The first proposal sounds reasonable, but I'm not sure we should care too much about making this change. What do you think @dylanexpensify? I see your slack comments and while we probably should focus in this case, is it worth an $1000+ plus bounty?

@dylanexpensify @Julesssss should we proceed with this issue or hold?

[ItxAltaf]

I think autoFocus is the best solution for this

[s77rt]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Username field not being focused after signing out

What is the root cause of that problem?

On signing out, the navigation changes and on navigation change we blur the active element. This is a regression from #14048. I'm the author of that PR, giving more context, the linked piece of code is meant to be executed before navigation and not after.

What changes do you think we should make in order to solve the problem?

Move the blur logic to the main navigation method.

What alternative solutions did you explore? (Optional)

None

---

No compensation is required here. I will fix my own bug.

[MelvinBot]

Looks like something related to react-navigation may have been mentioned in this issue discussion.

As a reminder, please make sure that all proposals are not workarounds and that any and all attempt to fix the issue holistically have been made before proceeding with a solution. Proposals to change our DeprecatedCustomActions.js files should not be accepted.

Feel free to drop a note in #expensify-open-source with any questions.

[dylanexpensify]

@Santhosh-Sellavel bump on reviewing! :)

[Julesssss]

@dylanexpensify can you please go ahead and create that regression test please?

[Santhosh-Sellavel]

Thanks again for your assistance on here for checklist @s77rt

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@s77rt / @Santhosh-Sellavel / @Julesssss] The PR that introduced the bug has been identified. Link to the PR: Refactor tooltip #14048
• [@s77rt / @Santhosh-Sellavel / @Julesssss] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: Refactor tooltip #14048 (comment)
• [@s77rt / @Santhosh-Sellavel / @Julesssss] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@s77rt / @Santhosh-Sellavel] Propose regression test steps to ensure the same bug will not reach production again. [HOLD for payment 2023-03-06] [$1000] Sign out - There is no cursor in the input field after sign out #14858 (comment)
• [@dylanexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[Santhosh-Sellavel]

@Julesssss Do we need to start a discussion on slack?

[Julesssss]

I don't think so, this has existed for a long time IIRC.

[dylanexpensify]

@Julesssss yes! Will do!

[dylanexpensify]

Created https://github.com/Expensify/Expensify/issues/267913

[dylanexpensify]

@Santhosh-Sellavel @s77rt can you please apply at job for payment?

[s77rt]

No payment is due for me (#14858 (comment))

[MelvinBot]

Triggered auto assignment to @MitchExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[dylanexpensify]

@MitchExpensify I'm heading OOO! Would you mind tackling this for me? 🙇

[Julesssss]

Bump @MitchExpensify, as long as you're not too busy at ECX.

[MitchExpensify]

@MitchExpensify I'm heading OOO! Would you mind tackling this for me? 🙇

Yep, no problem @dylanexpensify

[MitchExpensify]

Offer sent to @Santhosh-Sellavel for eventual payment

[MitchExpensify]

Payment made, contract ended - Thanks everyone!

[Julesssss]

Thanks @MitchExpensify