[HOLD for payment 2023-03-17] Add new AddEmojiReaction and RemoveEmojiReaction

[hannojg]

Part of #14180

Problem

There is currently no way to add emojis to reportActions.

Why is this important?

We are creating this feature.

Solution

• Add commands to the Report actions module as well as unit tests to verify those actions
• Implementation of UI components to display the reactions to a message
• Change the context menus to have the possibility to add reactions to messages
• Implement to add the same emoji but with different skin tones
• Implement to remove a reaction by pressing on the reaction bubble

Dependencies

For this feature implementation to work as expected the backend commands are needed. Their implementation is tracked here: #15063

Note: No need to make this External or internal. Might not even need to be assigned as no payments will be issued. (External agency working on this)

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~015458d104fa861ac7
• Upwork Job ID: 1633482891204546560
• Last Price Increase: 2023-03-08

[MelvinBot]

📣 @hannojg! 📣
Please report bugs or suggest features in the #expensify-open-source Slack channel, don't directly open issues in this repo!
Instructions here to join the channel 📖

[MelvinBot]

Triggered auto assignment to @laurenreidexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[MelvinBot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[hannojg]

PR is ready for review

• feat: add/remove reaction #15210

[MelvinBot]

@hannojg Eep! 4 days overdue now. Issues have feelings too...

[MelvinBot]

@hannojg Still overdue 6 days?! Let's take care of this!

[MelvinBot]

@hannojg 10 days overdue. I'm getting more depressed than Marvin.

[MelvinBot]

@hannojg 10 days overdue. I'm getting more depressed than Marvin.

[stitesExpensify]

This is officially merged! I'm going to mark this as external so that an upwork job gets created and we can pay out @0xmiroslav who did an excellent job reviewing!

[MelvinBot]

Job added to Upwork: https://www.upwork.com/jobs/~015458d104fa861ac7

[MelvinBot]

Triggered auto assignment to Contributor Plus for review of internal employee PR - @aimane-chnaif (Internal)

[stitesExpensify]

Hi @aimane-chnaif this has already been reviewed by a c+ so I'm un-assigning you :)

[0xmiros]

I think there's a problem with Github automation.
After assigning C+ and then adding Internal label assigns another C+.
I experienced this a few times.
Another examples: #14766 (comment), #14513 (comment)
cc: @mountiny

[MelvinBot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[MelvinBot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.2.81-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• feat: add/remove reaction #15210

If no regressions arise, payment will be issued on 2023-03-17. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[0xmiros]

@stitesExpensify can you please add Bug label to assign BZ member or reassign @laurenreidexpensify for payment?
And I'd appreciate if I can get more compensation since this feature was urgent and important for ECX, which made me took much efforts in PR review.

[MelvinBot]

@hannojg, @stitesExpensify, @0xmiroslav Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[MelvinBot]

@hannojg, @stitesExpensify, @0xmiroslav Eep! 4 days overdue now. Issues have feelings too...

[stitesExpensify]

@laurenreidexpensify can we pay out @0xmiroslav ? As they mentioned, they did act with a lot of urgency to get this out the door on time, so I think that a bonus makes sense!

[laurenreidexpensify]

damn this is so weird, I didn't see this in my K2 dhasboard at all til today. I will prioritise issuing payment for this tomorrow.

[stitesExpensify]

Not your fault at all! I just re-assigned you 2 hours ago 😄 Paying out tomorrow would still be great though :)

[laurenreidexpensify]

@stitesExpensify can you confirm final payment amount on this one?

@0xmiroslav ignore the fee in Upwork for now when you accept the contract, I'll make sure the correct fee is paid once Brandon confirms. thanks!

[stitesExpensify]

Let's go with $2000 for @0xmiroslav's reviews. They were very responsive and helped get it out the door for ECX!

[laurenreidexpensify]

Sweet - @0xmiroslav thanks for your patience, have issued payment in Upwork now

[laurenreidexpensify]

Closing as completed, wasn't a bug was a new feature