Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$1000] [HOLD for payment 2023-05-16] Create a detailed list of reaction senders when long-/right-pressing a reaction #15128

Closed
hannojg opened this issue Feb 14, 2023 · 40 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 External Added to denote the issue can be worked on by a contributor Internal Requires API changes or must be handled by Expensify staff NewFeature Something to build that is a new item.

Comments

@hannojg
Copy link
Contributor

hannojg commented Feb 14, 2023

Part of #14180

Problem

For the reactions feature the user wants to see a detailed list of who reacted with a certain emoji.

Why is this important?

We are creating this feature.

Solution

  • When right-clicking (web/desktop) or long-pressing (mobile) we will show a popover that shows a list of the reaction senders using the <OptionsSelector /> component

Dependencies

Depends on the implementation that will add the mapping of account ID to personal details, here

Note: No need to make this External or internal. Might not even need to be assigned as no payments will be issued. (External agency working on this)

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01fe0f1829520b9bec
  • Upwork Job ID: 1641405732653518848
  • Last Price Increase: 2023-05-19
@hannojg hannojg added Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 labels Feb 14, 2023
@MelvinBot
Copy link

Triggered auto assignment to @dylanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@melvin-bot melvin-bot bot closed this as completed Feb 14, 2023
@MelvinBot
Copy link

📣 @hannojg! 📣
Please report bugs or suggest features in the #expensify-open-source Slack channel, don't directly open issues in this repo!
Instructions here to join the channel 📖

@MelvinBot
Copy link

Bug0 Triage Checklist (Main S/O)

  • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
  • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
    • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
  • This bug is reproducible using the reproduction steps in the OP. S/O
    • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
    • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
  • This issue is filled out as thoroughly and clearly as possible
    • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
  • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

@mountiny mountiny reopened this Feb 14, 2023
@mountiny mountiny assigned hannojg and unassigned dylanexpensify Feb 14, 2023
@stitesExpensify stitesExpensify self-assigned this Feb 14, 2023
@Aaqib925
Copy link

I am React Native Freelancer on Upwork, I can work on this issue. @mountiny

@mountiny
Copy link
Contributor

@Aaqib925 as mentioned in the other issue, please, read and follow the contributing guidelines

@stitesExpensify stitesExpensify changed the title See a detailed list of reaction senders when long-/right-pressing a reaction Create a detailed list of reaction senders when long-/right-pressing a reaction Feb 14, 2023
@marcaaron marcaaron added NewFeature Something to build that is a new item. and removed Bug Something is broken. Auto assigns a BugZero manager. labels Feb 15, 2023
@melvin-bot melvin-bot bot added the Overdue label Feb 16, 2023
@MelvinBot
Copy link

@hannojg, @stitesExpensify Whoops! This issue is 2 days overdue. Let's get this updated quick!

@hannojg
Copy link
Contributor Author

hannojg commented Feb 19, 2023

Still finishing this issue first, which is a precondition to start working on this issue.

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Feb 19, 2023
@MelvinBot
Copy link

@hannojg, @stitesExpensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@MelvinBot
Copy link

@hannojg, @stitesExpensify Huh... This is 4 days overdue. Who can take care of this?

@MelvinBot
Copy link

@hannojg, @stitesExpensify Now this issue is 8 days overdue. Are you sure this should be a Daily? Feel free to change it!

@stitesExpensify
Copy link
Contributor

@hannojg can you post an update here please?

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Feb 28, 2023
@MelvinBot
Copy link

@hannojg, @stitesExpensify Huh... This is 4 days overdue. Who can take care of this?

@MelvinBot
Copy link

@hannojg, @stitesExpensify Eep! 4 days overdue now. Issues have feelings too...

@parasharrajat
Copy link
Member

Review started on the PR.

@MelvinBot
Copy link

@hannojg, @parasharrajat, @stitesExpensify Huh... This is 4 days overdue. Who can take care of this?

@MelvinBot
Copy link

@hannojg, @parasharrajat, @stitesExpensify 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

@stitesExpensify
Copy link
Contributor

This is still being actively reviewed and updated. My goal was to have it merged by the end of this week, but there are still significant changes being made, so that is pretty unlikely at this point

@MelvinBot
Copy link

@hannojg, @parasharrajat, @stitesExpensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@parasharrajat
Copy link
Member

Awaiting an update on the PR which should be the last thing before I can do the final testing.

@MelvinBot
Copy link

@hannojg, @parasharrajat, @stitesExpensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@melvin-bot
Copy link

melvin-bot bot commented May 8, 2023

@hannojg, @parasharrajat, @stitesExpensify 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

@parasharrajat
Copy link
Member

PR is merged.

@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Daily KSv2 labels May 9, 2023
@melvin-bot melvin-bot bot changed the title Create a detailed list of reaction senders when long-/right-pressing a reaction [HOLD for payment 2023-05-16] Create a detailed list of reaction senders when long-/right-pressing a reaction May 9, 2023
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label May 9, 2023
@melvin-bot
Copy link

melvin-bot bot commented May 9, 2023

Reviewing label has been removed, please complete the "BugZero Checklist".

@melvin-bot
Copy link

melvin-bot bot commented May 9, 2023

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.12-0 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2023-05-16. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

  • External issue reporter
  • Contributor that fixed the issue
  • Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

  • Merged PR within 3 business days of assignment - 50% bonus
  • Merged PR more than 9 business days after assignment - 50% penalty

@melvin-bot melvin-bot bot added Daily KSv2 Overdue and removed Weekly KSv2 labels May 15, 2023
@stitesExpensify stitesExpensify added the External Added to denote the issue can be worked on by a contributor label May 19, 2023
@melvin-bot melvin-bot bot changed the title [HOLD for payment 2023-05-16] Create a detailed list of reaction senders when long-/right-pressing a reaction [$1000] [HOLD for payment 2023-05-16] Create a detailed list of reaction senders when long-/right-pressing a reaction May 19, 2023
@melvin-bot
Copy link

melvin-bot bot commented May 19, 2023

Triggered auto assignment to @kadiealexander (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

@melvin-bot
Copy link

melvin-bot bot commented May 19, 2023

Current assignee @parasharrajat is eligible for the External assigner, not assigning anyone new.

@melvin-bot
Copy link

melvin-bot bot commented May 19, 2023

Current assignee @stitesExpensify is eligible for the External assigner, not assigning anyone new.

@stitesExpensify
Copy link
Contributor

Hi @kadiealexander can we pay @parasharrajat out for being c+ on this please? Also, this was at least a $2k issue considering it took 2 months to complete

@melvin-bot melvin-bot bot removed the Overdue label May 19, 2023
@kadiealexander
Copy link
Contributor

Sent you a contract @parasharrajat!

@kadiealexander
Copy link
Contributor

@parasharrajat has been paid $2000.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 External Added to denote the issue can be worked on by a contributor Internal Requires API changes or must be handled by Expensify staff NewFeature Something to build that is a new item.
Projects
None yet
Development

No branches or pull requests

9 participants