-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HOLD for payment 2023-03-23] Create list of users who reacted in the tooltip on emoji reaction hover #15127
Comments
Triggered auto assignment to @MitchExpensify ( |
📣 @hannojg! 📣 |
Bug0 Triage Checklist (Main S/O)
|
@hannojg, @stitesExpensify Whoops! This issue is 2 days overdue. Let's get this updated quick! |
@hannojg, @stitesExpensify Still overdue 6 days?! Let's take care of this! |
Proposal: I can work on this task |
@hannojg, @stitesExpensify Eep! 4 days overdue now. Issues have feelings too... |
@hannojg, @stitesExpensify Still overdue 6 days?! Let's take care of this! |
@hannojg, @stitesExpensify Now this issue is 8 days overdue. Are you sure this should be a Daily? Feel free to change it! |
Will put up a PR until Monday. This feature depends on this PR, so I have to get this PR merged first |
PR is up here: #15671 |
#15795 can be closed as dup |
@hannojg, @stitesExpensify Eep! 4 days overdue now. Issues have feelings too... |
@hannojg @stitesExpensify I think the bubbles margin should not be considered as an execution of the tooltip. Currently hovering above the bubble also shows the tooltip which seems to be incorrect. Screen.Recording.2023-03-16.at.12.52.11.AM.mov |
|
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.2.85-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue: If no regressions arise, payment will be issued on 2023-03-23. 🎊 After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
As a reminder, here are the bonuses/penalties that should be applied for any External issue:
|
Part of #14180
Problem
For the reactions feature the user wants to hover to see who reacted.
Why is this important?
We are creating this feature.
Solution
Dependencies
This will depend on the backend implementation to return the account IDs for the personal details, as well as on the implementation to render any arbitrary content in the
<Tooltip />
component.Note: No need to make this External or internal. Might not even need to be assigned as no payments will be issued. (External agency working on this)
The text was updated successfully, but these errors were encountered: