Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2023-03-23] Create list of users who reacted in the tooltip on emoji reaction hover #15127

Closed
hannojg opened this issue Feb 14, 2023 · 17 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 NewFeature Something to build that is a new item.

Comments

@hannojg
Copy link
Contributor

hannojg commented Feb 14, 2023

Part of #14180

Problem

For the reactions feature the user wants to hover to see who reacted.

Why is this important?

We are creating this feature.

Solution

  • Get the personal details of the senders using the account ID
  • Display a tooltip that shows the emoji and the display names of the senders.

Dependencies

This will depend on the backend implementation to return the account IDs for the personal details, as well as on the implementation to render any arbitrary content in the <Tooltip /> component.

Note: No need to make this External or internal. Might not even need to be assigned as no payments will be issued. (External agency working on this)

@hannojg hannojg added Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 labels Feb 14, 2023
@MelvinBot
Copy link

Triggered auto assignment to @MitchExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@MelvinBot
Copy link

📣 @hannojg! 📣
Please report bugs or suggest features in the #expensify-open-source Slack channel, don't directly open issues in this repo!
Instructions here to join the channel 📖

@melvin-bot melvin-bot bot closed this as completed Feb 14, 2023
@MelvinBot
Copy link

Bug0 Triage Checklist (Main S/O)

  • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
  • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
    • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
  • This bug is reproducible using the reproduction steps in the OP. S/O
    • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
    • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
  • This issue is filled out as thoroughly and clearly as possible
    • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
  • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

@hannojg hannojg changed the title Seeing list of reaction senders in the tooltip Seeing list of reaction senders in the tooltip on hover Feb 14, 2023
@mountiny mountiny reopened this Feb 14, 2023
@mountiny mountiny assigned hannojg and unassigned MitchExpensify Feb 14, 2023
@stitesExpensify stitesExpensify self-assigned this Feb 14, 2023
@Expensify Expensify deleted a comment from Aaqib925 Feb 14, 2023
@stitesExpensify stitesExpensify changed the title Seeing list of reaction senders in the tooltip on hover Create list of users who reacted in the tooltip on emoji reaction hover Feb 14, 2023
@marcaaron marcaaron added NewFeature Something to build that is a new item. and removed Bug Something is broken. Auto assigns a BugZero manager. labels Feb 15, 2023
@melvin-bot melvin-bot bot added the Overdue label Feb 16, 2023
@MelvinBot
Copy link

@hannojg, @stitesExpensify Whoops! This issue is 2 days overdue. Let's get this updated quick!

@MelvinBot
Copy link

@hannojg, @stitesExpensify Still overdue 6 days?! Let's take care of this!

@Aaqib925
Copy link

Proposal:

I can work on this task

@stitesExpensify
Copy link
Contributor

Thank you for the offer @Aaqib925 but @hannojg is already taking this on!

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Feb 22, 2023
@MelvinBot
Copy link

@hannojg, @stitesExpensify Eep! 4 days overdue now. Issues have feelings too...

@MelvinBot
Copy link

@hannojg, @stitesExpensify Still overdue 6 days?! Let's take care of this!

@MelvinBot
Copy link

@hannojg, @stitesExpensify Now this issue is 8 days overdue. Are you sure this should be a Daily? Feel free to change it!

@hannojg
Copy link
Contributor Author

hannojg commented Mar 5, 2023

Will put up a PR until Monday. This feature depends on this PR, so I have to get this PR merged first

@melvin-bot melvin-bot bot removed the Overdue label Mar 5, 2023
@hannojg
Copy link
Contributor Author

hannojg commented Mar 5, 2023

PR is up here: #15671

@melvin-bot melvin-bot bot added the Reviewing Has a PR in review label Mar 5, 2023
@0xmiros
Copy link
Contributor

0xmiros commented Mar 10, 2023

#15795 can be closed as dup
@kbecciv @CortneyOfstad

@MelvinBot
Copy link

@hannojg, @stitesExpensify Eep! 4 days overdue now. Issues have feelings too...

@Pujan92
Copy link
Contributor

Pujan92 commented Mar 15, 2023

@hannojg @stitesExpensify I think the bubbles margin should not be considered as an execution of the tooltip. Currently hovering above the bubble also shows the tooltip which seems to be incorrect.

Screen.Recording.2023-03-16.at.12.52.11.AM.mov

@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Daily KSv2 labels Mar 16, 2023
@melvin-bot melvin-bot bot changed the title Create list of users who reacted in the tooltip on emoji reaction hover [HOLD for payment 2023-03-23] Create list of users who reacted in the tooltip on emoji reaction hover Mar 16, 2023
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Mar 16, 2023
@MelvinBot
Copy link

Reviewing label has been removed, please complete the "BugZero Checklist".

@MelvinBot
Copy link

MelvinBot commented Mar 16, 2023

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.2.85-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2023-03-23. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

  • External issue reporter
  • Contributor that fixed the issue
  • Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

  • Merged PR within 3 business days of assignment - 50% bonus
  • Merged PR more than 9 business days after assignment - 50% penalty

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 NewFeature Something to build that is a new item.
Projects
None yet
Development

No branches or pull requests

9 participants