[HOLD for payment 2023-03-16] Make the tooltip component accept any arbitrarily content

[hannojg]

Part of #14180

Problem

Currently the <Tooltip /> component only accepts string to render. Its an issue when you want to render any other content than text in a tooltip.

Why is this important?

The emoji reactions feature wants to show the emoji and its senders in the tooltip.

Solution

Make the <Tooltip /> component accept a renderContent callback, as outlines here.

Note: No need to make this External or internal. Might not even need to be assigned as no payments will be issued. (External agency working on this)

[MelvinBot]

Triggered auto assignment to @sonialiap (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[MelvinBot]

📣 @hannojg! 📣
Please report bugs or suggest features in the #expensify-open-source Slack channel, don't directly open issues in this repo!
Instructions here to join the channel 📖

[MelvinBot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[MelvinBot]

@hannojg Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[hannojg]

PR is up for review: #15325

[MelvinBot]

@hannojg Whoops! This issue is 2 days overdue. Let's get this updated quick!

[MelvinBot]

@hannojg Eep! 4 days overdue now. Issues have feelings too...

[hannojg]

Currently fixing the PR as suggested by the review comments. Should be good for review on Monday morning 😊

[MelvinBot]

Triggered auto assignment to @dylanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[MelvinBot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[mountiny]

Could we pay @s77rt $1000 for the PR testing and review please?

[MelvinBot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[MelvinBot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.2.80-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [Web] Change tooltip component to accept generic content #15325

If no regressions arise, payment will be issued on 2023-03-16. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[MelvinBot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@s77rt] The PR that introduced the bug has been identified. Link to the PR:
• [@s77rt] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@s77rt] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@dylanexpensify] Determine if we should create a regression test for the bug.
• [@s77rt] If we decide to create a regression test for the bug, please propose the regression test steps to the appropriate location to ensure the same bug will not reach production again.
• [@dylanexpensify] Review the proposed regression test steps and location.
• [@dylanexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[MelvinBot]

Looks like something related to react-navigation may have been mentioned in this issue discussion.

As a reminder, please make sure that all proposals are not workarounds and that any and all attempt to fix the issue holistically have been made before proceeding with a solution. Proposals to change our DeprecatedCustomActions.js files should not be accepted.

Feel free to drop a note in #expensify-open-source with any questions.

[s77rt]

I don't think the checklist applies here since this is a feature request. Let me know if any action is required here.

[mountiny]

Yep sounds good to me, no action required

[MelvinBot]

Triggered auto assignment to @tjferriss (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[dylanexpensify]

@tjferriss I'm heading OOO this week, mind tackling this one for me?? TY! 🙇

[tjferriss]

I've created the UpWorks job to process payment. I want to make sure I have this right:

• External issue reporter @hannojg $250
• Contributor that fixed the issue @hannojg $1000
• Contributor+ that helped on the issue and/or PR @s77rt $1000

Does that look right to everyone? If so, can you please apply here: https://www.upwork.com/ab/applicants/1636137881404239872/job-details

Based on this comment, it sounds like all that remains is to get the payment processed. I tend to agree.

[s77rt]

@tjferriss The upwork job is private

[tjferriss]

Are you sure? It it telling me it's public right now: https://www.upwork.com/jobs/~013dc6542fe5fba104

[s77rt]

@tjferriss That is a different link 😅 I have applied!

[roryabraham]

@tjferriss plz see https://expensify.slack.com/archives/C01SKUP7QR0/p1678973491822359

[tjferriss]

@s77rt I just accepted you in Upworks.

@hannojg sorry for the confusion, it looks like payment is handled through Margelo.

[tjferriss]

Payment processed. Closing.