[HOLD for payment 2023-03-13] [$1000] > throughout the app has color change effect on hover but the arrow in request / send money messages in report does not have the hover effect

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Open the app
2. Open any report
3. Request or send money
4. Hover on message and see the greater then arrow color
5. Open settings
6. Hover on any tab and see greater then arrow color (Throughout the app, check for all the usecase of greater than arrow for hover effect)

Expected Result:

Fill color of arrow should change to '#E7ECE9' for request / send money arrow as it does throughout the app

Actual Result:

Fill color of arrow remains the same i.e. '#8B9C8F' for request / send money

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• MacOS / Chrome / Safari

Version Number: 1.2.75-0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:

hover.consistency.issue.mp4

Recording.1578.mp4

Expensify/Expensify Issue URL:
Issue reported by: @dhanashree-sawant
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1677059641635739

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0120bb72f4393353fc
• Upwork Job ID: 1629058839845679104
• Last Price Increase: 2023-02-24

[MelvinBot]

Triggered auto assignment to @garrettmknight (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[MelvinBot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[ctkochan22]

Not sure if this is a bug, but I think we'd want it to remain consistent.

[ctkochan22]

I have a good lead on this if we do want to update it

[garrettmknight]

Checking on whether this is intentional for any reason with design, but it seems like we'd want to update for consistency.

[ctkochan22]

Looks like based on the Slack convo, we want to make this consistent with the other usages: https://expensify.slack.com/archives/C049HHMV9SM/p1677154726654889?thread_ts=1677059641.635739&cid=C049HHMV9SM

[garrettmknight]

Yep - let's treat this like a bug!

[MelvinBot]

Job added to Upwork: https://www.upwork.com/jobs/~0120bb72f4393353fc

[MelvinBot]

Current assignee @garrettmknight is eligible for the External assigner, not assigning anyone new.

[MelvinBot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @sobitneupane (External)

[MelvinBot]

Current assignee @ctkochan22 is eligible for the External assigner, not assigning anyone new.

[garrettmknight]

@ctkochan22 smacked an External label on it just in case you have other things to work on, but if you wanna take it, go ahead!

[tienifr]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The arrow icon color is not consistent on hover in request / send money arrow.

What is the root cause of that problem?

In request / send money arrow, we're not checking the hover state in order to show the correct hover icon color.

What changes do you think we should make in order to solve the problem?

In here,

App/src/components/ReportActionItem/IOUQuote.js

Line 52 in ffe2996

<Icon src={Expensicons.ArrowRight} fill={props.shouldAllowViewDetails ? themeColors.icon : themeColors.transparent} />

, we need to check if the icon is hovered, if it is then show the hover icon color.

To be more specific, we can use the StyleUtils.getIconFillColor and getButtonState function, similar to in MenuItem, to get the correct icon based on the hovered state:

<Icon src={Expensicons.ArrowRight} fill={props.shouldAllowViewDetails ? StyleUtils.getIconFillColor(getButtonState(props.isHovered)) : themeColors.transparent} />

The hovered state can be passed in from the parent component IOUAction

What alternative solutions did you explore? (Optional)

NA

Result

Working well after the fix:

Screen.Recording.2023-02-24.at.17.31.41.mov

[allroundexperts]

Proposal

Please re-state the problem that we are trying to solve in this issue.

IOUQuote component shows incorrect icon colour when hovered.

What is the root cause of that problem?

The root cause of the issue is here. We are using a static icon colour ir-respective of the fact if the item is hovered or not (themeColors.icon).

What changes do you think we should make in order to solve the problem?

We can add a isHovered property to the IOUQuote component and set this value when this component is called from IOUAction component. Then we can change the color depending on the isHovered property here:

<Icon src={Expensicons.ArrowRight} fill={props.shouldAllowViewDetails ? (props.isHovered ? themeColors.iconHovered: themeColors.icon) : themeColors.transparent} />

In IOUAction component, we can add the following here:

 isHovered={props.isHovered}

What alternative solutions did you explore? (Optional)

None

[sobitneupane]

Thanks for your proposal @tienifr and @allroundexperts.

Both the proposals are almost same. So, I would suggest going with the first proposal from @tienifr.

@tienifr's Proposal looks good to me.

🎀👀🎀 C+ reviewed

cc: @ctkochan22

[ctkochan22]

That is kind of what I was thinking. Lets go with @tienifr proposal!

[garrettmknight]

Sent @tienifr an offer in Upwork.

[tienifr]

@sobitneupane The PR #15551 is ready for review. Thanks

[MelvinBot]

📣 @tienifr You have been assigned to this job by @garrettmknight!
Please apply to this job in Upwork and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[tienifr]

Regression Test Proposal

Bug: > throughout the app has color change effect on hover but the arrow in request / send money messages in report does not have the hover effect

Proposed Test Steps:

1. Open the app
2. Open any report
3. Request or send money
4. Hover on the message
   Verify that the arrow icon color change to '#E7ECE9' color

Do we 👍 or 👎

[MelvinBot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[MelvinBot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.2.78-0 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix hover effect on request or send money messages #15551

If no regressions arise, payment will be issued on 2023-03-13. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[MelvinBot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@sobitneupane / @AndrewGable] The PR that introduced the bug has been identified. Link to the PR:
• [@sobitneupane / @AndrewGable] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@sobitneupane / @AndrewGable] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@tienifr] Propose regression test steps to ensure the same bug will not reach production again.
• [@garrettmknight] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[garrettmknight]

@AndrewGable / @sobitneupane do we know what PR introduced the bug?

[AndrewGable]

I'm not sure it was a regression or if it's always been that way, @sobitneupane - Do you know?

[sobitneupane]

I don't think it'a a regression. As far as I remember, it's always been that way.

[garrettmknight]

Cool, do you think any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner?

[sobitneupane]

@garrettmknight I believe adding regression step should to enough to catch this bug.

[dhanashree-sawant]

Hi @garrettmknight , @AndrewGable , @sobitneupane, For this issue, offer was already sent on upwork. Once the discussion is done, can you also look into approval for the offer?

[AndrewGable]

@garrettmknight is just finishing this one up.

[garrettmknight]

Yep, sorry for the slow movement here - was awaiting completion of the list. Everyone's paid. 50% for C and C+. Contracts closed.