[HOLD for payment 2023-03-13] Empty line appears both in report and in LHN if # is followed by two or more spaces in multiline message

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Go to any chat
2. Send a message like

#  
The above # followed by two or more spaces will be translated to an empty line

3. Notice '# ' in the first line is displayed as a line break instead of text '# ' and message preview in LHN is empty

Expected Result:

The first line of the message and message preview is LHN should be '# '

Actual Result:

The first line of the message is displayed as an empty line and message preview in LHN is empty as well

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.2.75-0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:

Screen.Recording.2023-02-22.at.8.59.05.PM.mov

Recording.1579.mp4

Expensify/Expensify Issue URL:
Issue reported by: @eh2077
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1677074059909059

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0179eff6125b6d2857
• Upwork Job ID: 1628730351044272128
• Last Price Increase: 2023-02-23

[MelvinBot]

Triggered auto assignment to @NicMendonca (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[MelvinBot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[Gonals]

Taking a look

[MelvinBot]

Job added to Upwork: https://www.upwork.com/jobs/~0179eff6125b6d2857

[eh2077]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The first line of a two line message, like

#  
The above # followed by two or more spaces will be translated to an empty HTML heading "<h1> </h1>"

will be displayed as an empty line and the message preview in LHN is empty.

What is the root cause of that problem?

The regex rule

https://github.com/Expensify/expensify-common/blob/a2942d035614bf4bed90ffe2114d6ee828ee96da/lib/ExpensiMark.js#L167-L168

to translate markdown heading to HTML heading matches the last spaces if there're two or more spaces after #

What changes do you think we should make in order to solve the problem?

To fix this issue, we need to positive lookahead any non-whitespace character before the first capturing group. We can improve regex rule https://github.com/Expensify/expensify-common/blob/a2942d035614bf4bed90ffe2114d6ee828ee96da/lib/ExpensiMark.js#L167

from

/^#(?!#) +(.+)$\s*/gm

to

/^#(?!#) +(?=\S)(.+)$\s*/gm

What alternative solutions did you explore? (Optional)

None

[MelvinBot]

Triggered auto assignment to Contributor Plus for review of internal employee PR - @s77rt (Internal)

[Gonals]

I don't think this one will require c+ review :)

[MelvinBot]

@Gonals, @NicMendonca Whoops! This issue is 2 days overdue. Let's get this updated quick!

[NicMendonca]

@Gonals just to confirm - what's the latest on this one?

[MelvinBot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[MelvinBot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.2.78-0 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Update expensify-common #15409

If no regressions arise, payment will be issued on 2023-03-13. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[MelvinBot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@Gonals] The PR that introduced the bug has been identified. Link to the PR: Add h1 markdown expensify-common#468
• [@Gonals] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: Add h1 markdown expensify-common#468 (comment)
• [@Gonals] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: https://expensify.slack.com/archives/C049HHMV9SM/p1678117732122989
• [@Gonals] Propose regression test steps to ensure the same bug will not reach production again.
  I think this was a very specific corner case. No additional steps are really needed.
• [@NicMendonca] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[NicMendonca]

@eh2077 don't forget to apply tot he job for reporting

[eh2077]

Hi @NicMendonca , thanks for reminding! But it looks like I can’t access the job on Upwork

[NicMendonca]

Opps, sorry! I've made it public. @eh2077 can you try again please?

[eh2077]

@NicMendonca I have applied the job, thank you!

[NicMendonca]

@eh2077 paid! 🎉

[eh2077]

Hi @NicMendonca , I just accepted the offer you sent me!

Hmm, it looks like still need your help to make the payment and then end the contract on Upwork. Would you please help with it? Thanks!

[NicMendonca]

@eh2077 sorry! Just re-issued payment and closed out the contract. Can you confirm on your end?