Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore heading markup if the line is just whitespaces #505

Merged
merged 2 commits into from
Feb 24, 2023

Conversation

Gonals
Copy link
Contributor

@Gonals Gonals commented Feb 23, 2023

Fixed Issues

Expensify/App#15372

Tests

  • Follow the steps to get the changes in your App
  • Open Newdot and start a chat
  • Write # Hello. Hello should get formatted as a header
  • Write # Hello (with two spaces). Hello should get formatted as a header
  • Write
#  
Hello

(with two spaces after the #). Hello should NOT get formatted as a header and the # should remain visible

QA

Will be QAed with App counterpart

@Gonals Gonals requested a review from a team as a code owner February 23, 2023 12:20
@Gonals Gonals self-assigned this Feb 23, 2023
@melvin-bot melvin-bot bot requested review from arosiclair and removed request for a team February 23, 2023 12:20
@arosiclair arosiclair merged commit ce6258b into main Feb 24, 2023
@arosiclair arosiclair deleted the alberto-heading branch February 24, 2023 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants