[HOLD for payment 2023-03-17] [$1000] Pay option is not available from chat if send money flow is done after request money

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Open the app and login with user A
2. Open the app in any other device and login with user B
3. From user A device, request for money to user B (any amount)
4. Check if pay option is available in chat of user A from user B device
5. Again from user A device, send money to user B (any amount)
6. Check again in user B device if pay option is available in chat or not

Expected Result:

User B should be able to see Pay option in chat of user A

Actual Result:

User B no longer is able to see Pay option in user A chat.

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.2.76-2
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:

Pay.option.no.longer.available.mp4

Recording.1585.mp4

Expensify/Expensify Issue URL:
Issue reported by: @dhanashree-sawant
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1677142389450799

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01c7eb5c23491fb3ee
• Upwork Job ID: 1629231188354961408
• Last Price Increase: 2023-03-06

[MelvinBot]

Triggered auto assignment to @slafortune (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[MelvinBot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[MelvinBot]

Job added to Upwork: https://www.upwork.com/jobs/~01c7eb5c23491fb3ee

[MelvinBot]

Current assignee @slafortune is eligible for the External assigner, not assigning anyone new.

[MelvinBot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @eVoloshchak (External)

[MelvinBot]

Triggered auto assignment to @ctkochan22 (External), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[allroundexperts]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The pay button disappears from chat for a previous IOU request when you send a new IOU request.

What is the root cause of that problem?

This line in our code hides the IOUPreview if the action is not a most recent IOUAction.

What changes do you think we should make in order to solve the problem?

We can just remove this first condition to fix this. Alternatively, we can also update the condition here to include both pay and create action types.

I'm not sure if this is a bug in reality since this seems more like a feature to me that we intentionally did. @eVoloshchak can you please elaborate on this more?

What alternative solutions did you explore? (Optional)

N/A

[orkunkarakus]

I agree with @allroundexperts for the remove isMostRecentIOUReportAction prop from condition.

If you need a different approach then i will say to make IOUPreview (Big payment detail box) can be shown only where the payment process has not been completed.

[MelvinBot]

📣 @orkunkarakus! 📣

Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

1. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
2. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
3. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.

Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

[orkunkarakus]

Contributor details
Your Expensify account email: ork.karakus@gmail.com
Upwork Profile Link: https://www.upwork.com/freelancers/~01ac7536d2dc94e8d2

[MelvinBot]

✅ Contributor details stored successfully. Thank you for contributing to Expensify!

[ctkochan22]

Haven't had a chance to investigate. I have to unassign. @slafortune could you please re-apply the engineering label and get another engineer assigned?

[eVoloshchak]

@allroundexperts's proposal LGTM.

However you're correct, that's how it was implemented initially in #2112.
I think we may go with the second approach (to include both pay and create action types), but would like to confirm with @slafortune this is indeed bug, not a feature 😄

[allroundexperts]

@slafortune Can you please give an update here?

[MelvinBot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[MelvinBot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.2.81-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix bug where IOUPreview is not show for requests following a send money action #15677

If no regressions arise, payment will be issued on 2023-03-17. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[MelvinBot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@eVoloshchak / @tgolen / @Julesssss] The PR that introduced the bug has been identified. Link to the PR:
• [@eVoloshchak / @tgolen / @Julesssss] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@eVoloshchak / @tgolen / @Julesssss] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@slafortune] Determine if we should create a regression test for the bug.
• [@eVoloshchak] If we decide to create a regression test for the bug, please propose the regression test steps to the appropriate location to ensure the same bug will not reach production again.
• [@slafortune] Review the proposed regression test steps and location.
• [@slafortune] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:https://github.com/Expensify/Expensify/issues/274355

[MelvinBot]

Looks like something related to react-navigation may have been mentioned in this issue discussion.

As a reminder, please make sure that all proposals are not workarounds and that any and all attempt to fix the issue holistically have been made before proceeding with a solution. Proposals to change our DeprecatedCustomActions.js files should not be accepted.

Feel free to drop a note in #expensify-open-source with any questions.

[MelvinBot]

@tgolen, @eVoloshchak, @Julesssss, @slafortune Whoops! This issue is 2 days overdue. Let's get this updated quick!

[slafortune]

@Julesssss - Just to make sure I'm clear - Is this payable to @eVoloshchak for $1000?

[Julesssss]

Hey @slafortune.

Yeah, @eVoloshchak reviewed the PR, and @dhanashree-sawant reported it (so needs the reporter bonus). We still need to complete some of the checklist items too.

This wasn't a regression, but we could probably add these test cases:

---

Verify that IOUPreview components are visible

• Log in with two users: userA and userB
• As user B, make three iou requests from userB
• For both users, the full IOUPreview should be shown only for the most recent request
• As any user, send money to the other
• An IOUPreview should display for both the SendMoney, and most recent IOU request action

Offline tests

• [After running the regular test, go offline
• Send money again, using the PayPal option
• An IOUPreview should display for both of the SendMoney actions, and also the most recent IOU request action

[slafortune]

Sent offers to @eVoloshchak and @dhanashree-sawant

[slafortune]

Paid! I will do the regression test last today or Monday

[MelvinBot]

@tgolen, @eVoloshchak, @Julesssss, @slafortune Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[eVoloshchak]

Not overdue, only a regression test left it seems

[MelvinBot]

@tgolen, @eVoloshchak, @Julesssss, @slafortune Huh... This is 4 days overdue. Who can take care of this?

[Julesssss]

We can close once the regression test is complete, not overdue!

[tgolen]

@slafortune Are you doing the regression test?

[slafortune]

Yep! Sorry -done now.