[HOLD for payment 2023-03-13] Can't edit the last comment if there's another comment deleted in the middle

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Add a comment
2. Add a second comment to the same chat
3. Press up, delete the whole comment and confirm the deletion
4. Wait for the api command to finish
5. Press up, check that it does not open the last comment for editing when it should

Expected Result:

Describe what you think should've happened

Actual Result:

Describe what actually happened

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• MacOS / Chrome / Safari

Version Number: 1.2.76-7
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:

press.up.to.edit.mp4

Expensify/Expensify Issue URL:
Issue reported by: @iwiznia
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1677182500365509

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0125d977a0cd449523
• Upwork Job ID: 1630394541430939648
• Last Price Increase: 2023-02-28

[MelvinBot]

Triggered auto assignment to @michaelhaxhiu (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[MelvinBot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[MelvinBot]

@michaelhaxhiu Whoops! This issue is 2 days overdue. Let's get this updated quick!

[roryabraham]

I fix

[roryabraham]

Actually going to tag you back in @michaelhaxhiu to help with adding regression tests when we're done

[MelvinBot]

Job added to Upwork: https://www.upwork.com/jobs/~0125d977a0cd449523

[MelvinBot]

Triggered auto assignment to Contributor Plus for review of internal employee PR - @rushatgabhane (Internal)

[roryabraham]

Ok, PR is ready for review: #15545

[MelvinBot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[MelvinBot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.2.78-0 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Make canEditReportAction return false for deleted actions #15545

If no regressions arise, payment will be issued on 2023-03-13. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR = $1000

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[MelvinBot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@rushatgabhane / @roryabraham] The PR that introduced the bug has been identified. Link to the PR:
• [@rushatgabhane / @roryabraham] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@rushatgabhane / @roryabraham] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@rushatgabhane] Propose regression test steps to ensure the same bug will not reach production again.
• [@michaelhaxhiu] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[MelvinBot]

@michaelhaxhiu, @rushatgabhane, @roryabraham Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[michaelhaxhiu]

Invited Rushat to the job for $1k payment as C+ PR reviewer

[michaelhaxhiu]

Let's try to get the checklist done as a final step here 🙏

[MelvinBot]

@michaelhaxhiu, @rushatgabhane, @roryabraham Eep! 4 days overdue now. Issues have feelings too...

[rushatgabhane]

yes melvin i get that u have feelings

[roryabraham]

#16435

[rushatgabhane]

@michaelhaxhiu hi, how's it going?
I think we missed settling the upwork job for this :)

[michaelhaxhiu]

Oh no! Looking 👀

[michaelhaxhiu]

You are correct. Just sent you an offer. Can you DM when you accept it, so this doesn't get lost in the mix :)? I'll try to action it today/tomorrow (but I'm OOO till Tuesday as a heads-up)