Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Regression Tests: Editing messages with the ArrowUp key #16435

Closed
roryabraham opened this issue Mar 23, 2023 · 3 comments
Closed

New Regression Tests: Editing messages with the ArrowUp key #16435

roryabraham opened this issue Mar 23, 2023 · 3 comments
Assignees
Labels

Comments

@roryabraham
Copy link
Contributor

Platforms

Web + Desktop only

QA Steps

  1. Log into NewDot into two separate accounts.
  2. As user A, send two messages in a DM to user B.
  3. As user B, send one message in a DM to user A.
  4. As user A, press ArrowUp in the DM.
  5. Verify that the last message user A sent in the chat enters edit mode.
  6. Edit the comment, and save it.
  7. Verify that the message displays with the edits and having an (edited) suffix.
  8. As user A, press ArrowUp in the DM.
  9. Verify that the last message user A sent in the chat enters edit mode.
  10. This time, fully delete the comment.
  11. Verify that the message disappears.
  12. As user A, press ArrowUp in the DM.
  13. Verify that the first message sent in step 1 enters edit mode.
@isagoico
Copy link

Heyo @roryabraham 👋
Added these steps to the regression run here:

image

Did some very minor edits to clean up the steps a little bit.
Please close the issue if you think these are good to go!

@MelvinBot
Copy link

Looks like something related to react-navigation may have been mentioned in this issue discussion.

As a reminder, please make sure that all proposals are not workarounds and that any and all attempt to fix the issue holistically have been made before proceeding with a solution. Proposals to change our DeprecatedCustomActions.js files should not be accepted.

Feel free to drop a note in #expensify-open-source with any questions.

@MelvinBot
Copy link

Be sure to fill out the Contact List!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants