Login - Error message doesn't appear in email page after tap Go back button

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Issue found when executing PR #14854

Action Performed:

1. Attempt to sign in using any email on all devices (note - once you've hit a throttle you'll need to use another device, and possibly another IP address, so you'll need one for each device).
2. Re-request a magic code by tapping "Didn't receive a magic code?" and verify the message changes.
3. "Go back" and keep retrying login and code request until you hit the throttle (should be three times of login + request code)
4. Verify that correct error message shows: You've reached the maximum number of magic codes. Please wait a few minutes and try again.
5. Go back one more time and enter your email again. Verify that the correct error message shows on the email page - You need a magic code to sign in, but you've reached the maximum number of magic codes that can be sent. Please wait a few minutes and try again.

Expected Result:

The correct error message shows on the email page - You need a magic code to sign in, but you've reached the maximum number of magic codes that can be sent. Please wait a few minutes and try again.

Actual Result:

Error message doesn't appear in email page after tap Go back button

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.2.76.7

Reproducible in staging?: Yes

Reproducible in production?: Yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Screen_Recording_20230224_151718_New.Expensify.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

[MelvinBot]

Triggered auto assignment to @NicMendonca (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[MelvinBot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[NicMendonca]

@NikkiWines can you gut check this for me? 🙏 Should the Please wait error message remain when they user clicks "back"? I am thinking it would be hard to know when the "few" minutes is up, so the error message would have to disappear at some point.

[yuwenmemon]

@Beamanator Can you also take a look? Looks like this is related to #14854

[NikkiWines]

Ah, yeah there's a kind of specific flow here. From #14854 (cc: @dangrous)

we're looking for one error message that will show if you hit the throttle when clicking "Didn't receive a magic code?" - which is You've reached the maximum number of magic codes. Please wait a few minutes and try again.

and then ANOTHER error message that will show if you've hit the throttle when on the email entry page - You need a magic code to sign in, but you've reached the maximum number of magic codes that can be sent. Please wait a few minutes and try again.

Looks like the error for the email entry page isn't showing as expected. Going to check locally and see if maybe there's a difference in the throttle limit between the two.

[dangrous]

It's a little hard to tell from the video so wanted to confirm - the error should only show up once "Continue" is clicked on the email page. It won't show up just when you "go back," you have to try to log in again. Was "Continue" clicked here?

[NikkiWines]

@kbecciv can you confirm the behaviro @dangrous mentioned ⬆️

[kbecciv]

@NikkiWines Checking now

[kbecciv]

@dangrous Tester did not tap on Continue button on 1:07 of periods of time.

[dangrous]

Okay cool - can we test again including tapping on Continue and see if the error shows up in that case? I think we should be good if that passes.

[kbecciv]

@dangrous Re-tested by tapping on Continue button and error message is still there.
Please check the video

Screen_Recording_20230302_175440_New.Expensify.mp4

[dangrous]

Okay cool - that's what we want for that page!

However I noticed that the behavior for the second page (steps 2-4) does NOT match what we'd expect - no message change when clicking Didn't receive a magic code?, and no error there either. @NikkiWines any hunches on why?

EDIT: I just tested this locally and it seems to be working fine? But would be good to confirm on prod...

[NikkiWines]

Yeah - again I think this gets a little tricky with the expected flow for two different error messages.

I tested on prod using the following steps and I think this behavior is fine. But @dangrous since you introduced this logic you would know best I think 😅 what do you think about this behavior?

Note: Internal domains have a higher threshold limit so it's probably good not to do this by a specific number of resendValidateCode requests but rather repeat the action until the user sees the error.

Steps:

1. Navigate to newDot and enter the email for a passwordless account and press Continue
2. Click Didn't receive a magic link repeatedly until you see the following view and error message (note: the copy should specifically say You've reached the maximum number of magic codes. Please wait a few minutes and try again)
   
3. Click Go back
4. Press Continue and confirm you see the following view and error message (note: the copy should specifically say You need a magic code to sign in, but you've reached the maximum number of magic codes that can be sent. Please wait a few minutes and try again.)
   

Video: (public domain)

Screen.Recording.2023-03-03.at.11.57.12.mov

Video: (internal domain)

Screen.Recording.2023-03-03.at.11.57.57.mov

[dangrous]

Hm @NikkiWines so the steps you laid out make sense - and get the right results - except from your videos (and my testing) we're not getting the "Magic code sent!" message when you click "Didn't receive a magic code?" ... but that DOES work totally fine on dev. Any idea why that might be the case? Both sides (https://github.com/Expensify/Web-Expensify/pull/36370 and #14854) are on prod now so I don't know why it would be different. I confirmed it is sending the code, too...

[NikkiWines]

Hmm, maybe because @pecanoro's PR here isn't on prod yet? Does it work on staging for you?

[NikkiWines]

Yep, that PR is on prod now and the copy does get updated now.

Video of Magic code sent copy update

Screen.Recording.2023-03-06.at.10.40.14.mov

---

@kbecciv for testing this in the future can we use the following steps?

1. Navigate to newDot and enter the email for a passwordless account and press Continue
2. Click Didn't receive a magic link and confirm the copy updates to Magic code sent!.
3. Refresh the page and click Didn't receive a magic link again.
4. Repeat step 3 until you see the following error message: You've reached the maximum number of magic codes. Please wait a few minutes and try again
   
5. Click Go back and confirm you're directed back to the sign in page to enter a login.
6. Press Continue and confirm you see the following error message: You need a magic code to sign in, but you've reached the maximum number of magic codes that can be sent. Please wait a few minutes and try again.
   

Also as a side note, if you need the test logins unthrottled, please as an internal Expensify employee as we have an internal tool to unthrottle test accounts 🙌

[NikkiWines]

Either way, looks like this is fine and not a bug but just a factor of testing steps being unclear - closing.