[HOLD for payment 2023-04-03] [$1500] ToolTip is not shown over email text in chat

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Open a chat
2. Send a text message with email address eg: abdul@gmail.com
3. Hover over the sent email address

Expected Result:

Tooltip should be shown

Actual Result:

Tooltip is not shown

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• MacOS / Chrome

Version Number: 1.2.78-0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:

Screen.Recording.2023-03-02.at.1.49.10.AM.mov

Expensify/Expensify Issue URL:
Issue reported by: @abdulrahuman5196
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1677702092495209

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~015a1c358b55c49dbb
• Upwork Job ID: 1636420318555254784
• Last Price Increase: 2023-04-05

[MelvinBot]

Triggered auto assignment to @michaelhaxhiu (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[MelvinBot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[MelvinBot]

@michaelhaxhiu Whoops! This issue is 2 days overdue. Let's get this updated quick!

[MelvinBot]

@michaelhaxhiu Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[michaelhaxhiu]

We discussed this a little more here in Slack. I am waiting for 1-2 more opinions.

Right now I am conflicted. I think the question is if we should make anything that ends in .com have a tooltip shown upon hover. Whether it's an email address (e.g. user@email.com) or website (site.com or www.site.com)

[michaelhaxhiu]

[MelvinBot]

@michaelhaxhiu Eep! 4 days overdue now. Issues have feelings too...

[MelvinBot]

@michaelhaxhiu Still overdue 6 days?! Let's take care of this!

[michaelhaxhiu]

We are pretty torn 50/50 on this bug... I think we should do it though, seems easy and gives us more parity.

[MelvinBot]

Job added to Upwork: https://www.upwork.com/jobs/~015a1c358b55c49dbb

[MelvinBot]

Current assignee @michaelhaxhiu is eligible for the External assigner, not assigning anyone new.

[MelvinBot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @thesahindia (External)

[MelvinBot]

Triggered auto assignment to @nkuoch (External), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[daraksha-dk]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The tooltip is not being shown over email text in the chat.

What is the root cause of that problem?

We didn't implement this from the start so it can be considered as an improvement.

What changes do you think we should make in order to solve the problem?

To fix this we just need to update the logic here for showing the anchor's href or displayName

Eg. for a email like "test@gmail.com", we have two options for the tooltip:-

• mailto:test@gmail.com (using href) [preferred as per the intended behaviour]
• test@gmail.com (using displayName)

What alternative solutions did you explore? (Optional)

[MelvinBot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[MelvinBot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.2.89-0 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Use tooltip for email as well #16382

If no regressions arise, payment will be issued on 2023-04-03. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter - @abdulrahuman5196 $250
• Contributor that fixed the issue - @daraksha-dk $1500
• Contributor+ that helped on the issue and/or PR - @thesahindia $1500

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[MelvinBot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@thesahindia / @nkuoch] The PR that introduced the bug has been identified. Link to the PR:
• [@thesahindia / @nkuoch] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@thesahindia / @nkuoch] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@michaelhaxhiu] Determine if we should create a regression test for this bug.
• [@thesahindia] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@michaelhaxhiu] Link the GH issue for creating/updating the regression test once above steps have been agreed upon: https://github.com/Expensify/Expensify/issues/275497

[MelvinBot]

Current assignee @michaelhaxhiu is eligible for the External assigner, not assigning anyone new.

[MelvinBot]

Current assignee @thesahindia is eligible for the External assigner, not assigning anyone new.

[MelvinBot]

Triggered auto assignment to @arosiclair (External), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[michaelhaxhiu]

Making sure we have an internal engineer assigned to this GH since Nath has gone OOO.

She already reviewed the corresponding PR and that's merged to production.

#16382 (comment)

[michaelhaxhiu]

In terms of next steps @abdulrahuman5196 and @thesahindia can you apply for the job? Post a comment here when that's done.

• On March 21 the job was assigned to @daraksha-dk
• On March 23 it was merged by Nath

So there will be a 50% bonus here. Meaning payments will be as follows:

• External issue reporter - @abdulrahuman5196 $250 - paid
• Contributor that fixed the issue - @daraksha-dk $1500 paid
• Contributor+ that helped on the issue and/or PR - @thesahindia $1500 - paid

[MelvinBot]

Upwork job price has been updated to $1500

[thesahindia]

We can skip the first three items in the checklist since it wasn't a regression.

Regression test proposal

1. Go to any chat
2. Send an email address (e.g. xyz@gmail.com)
3. Hover over the sent email address
4. Verify that you see a tooltip

[MelvinBot]

@arosiclair, @michaelhaxhiu, @daraksha-dk, @thesahindia Eep! 4 days overdue now. Issues have feelings too...

[michaelhaxhiu]

Made GH for QA testrail steps (thanks @thesahindia). Just need to pay @thesahindia & @abdulrahuman5196 next, and we can close this.

[michaelhaxhiu]

All paid, and all checkboxes are satisfied. Closing.