[HOLD for payment 2023-04-10] [$1000] Hovering over again to ‘Copy to clipboard’ seems to split the ‘Copy to clipboard’ into two lines in the second click for long emails #15949

kavimuru · 2023-03-14T15:13:39Z

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Action Performed:

Open chrome web > Click on + button > New Chat > Type a Long email and hit enter
Click on the avatar > Hover over the copy to clipboard icon and see that the text ‘Copy to Clipboard’ displays in one line on the tooltip
Next click on the icon and it displays ‘copied’. Again, hover over the icon and see that the ‘Copy to Clipboard’ splits into two lines on the tooltip. It doesn't happens with shorter emails, but only with longer emails.

Expected Result:

Hovering over again to ‘Copy to clipboard’ should not split the ‘Copy to clipboard’ into two lines in the second click for long emails. There should be consistency and it should display in the single line only.

Actual Result:

Hovering over again to ‘Copy to clipboard’ splits the ‘Copy to clipboard’ into two lines in the second click for long emails

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Version Number: 1.2.84-0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:

Recording.1699.mp4

email.2.mp4

Expensify/Expensify Issue URL:
Issue reported by: @avi-shek-jha
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1678781967498269

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~0113ef7945a36f778f
Upwork Job ID: 1638556398300405760
Last Price Increase: 2023-03-29

MelvinBot · 2023-03-14T15:13:47Z

Triggered auto assignment to @michaelhaxhiu (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

MelvinBot · 2023-03-14T15:13:51Z

Bug0 Triage Checklist (Main S/O)

This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
This bug is not a duplicate report (check E/App issues and #expensify-bugs)
- If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
This bug is reproducible using the reproduction steps in the OP. S/O
- If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
- If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
This issue is filled out as thoroughly and clearly as possible
- Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

MelvinBot · 2023-03-17T18:23:29Z

@michaelhaxhiu Whoops! This issue is 2 days overdue. Let's get this updated quick!

MelvinBot · 2023-03-21T18:22:26Z

@michaelhaxhiu Still overdue 6 days?! Let's take care of this!

MelvinBot · 2023-03-22T15:01:06Z

Job added to Upwork: https://www.upwork.com/jobs/~0113ef7945a36f778f

MelvinBot · 2023-03-22T15:01:09Z

Current assignee @michaelhaxhiu is eligible for the External assigner, not assigning anyone new.

MelvinBot · 2023-03-22T15:01:17Z

Triggered auto assignment to Contributor-plus team member for initial proposal review - @eVoloshchak (External)

MelvinBot · 2023-03-22T15:01:24Z

Triggered auto assignment to @flodnv (External), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

michaelhaxhiu · 2023-03-22T15:05:11Z

All good, definitely external eligible. But also a good and easy pick up for an internal engineer who wants to quickly fix

hungvu193 · 2023-03-22T15:14:01Z

@michaelhaxhiu Are external contributors allowed to post Proposal before the Help Wanted label is added? I just wonder.

michaelhaxhiu · 2023-03-22T15:17:43Z

Edit: No changes have been announced yet. We are no longer locking jobs the way we used to, and so yes, it's acceptable to give a solution before the Help Wanted label is applied. But this comes with risk -- we may not choose to go external depending on what's ideal.

michaelhaxhiu · 2023-03-22T15:18:44Z

Let me see if this was formally announced yet.

situchan · 2023-03-22T15:32:00Z

The doc clearly says:

Example C+ review:
#16053 (comment)

hungvu193 · 2023-03-22T15:34:05Z

Thanks for your help @situchan 👍

eVoloshchak · 2023-03-22T15:37:33Z

The doc clearly says:
Example C+ review: #16053 (comment)

Yeah, I was following the contributing guideline. Found the discussion on slack, but can't find the official announcement if there was one.
I think the contributing guidelines need to be updated, first-time contributors won't have access to slack

michaelhaxhiu · 2023-03-22T15:41:13Z

Hm I made a mistake in my explanation above actually. We haven't announced the unlocked behavior yet (and when we do, I think we'll likely adhere to the Help Wanted label being needed before we allow proposals -- this is a correction from what I posted last time).

So for now we should be adhering to the guidance that's public. Which means proposals should only begin after the Help Wanted label is added.

MelvinBot · 2023-04-03T18:21:41Z

Reviewing label has been removed, please complete the "BugZero Checklist".

MelvinBot · 2023-04-03T18:21:43Z

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.2.93-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

Tooltip: Render text freely for measurement #16704

If no regressions arise, payment will be issued on 2023-04-10. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

External issue reporter - @avi-shek-jha $250
Contributor that fixed the issue - @s77rt $1500
Contributor+ that helped on the issue and/or PR - @eVoloshchak $1500

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

Merged PR within 3 business days of assignment - 50% bonus
Merged PR more than 9 business days after assignment - 50% penalty

MelvinBot · 2023-04-03T18:21:46Z

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[@eVoloshchak / @s77rt / @flodnv] The PR that introduced the bug has been identified. Link to the PR: [Web] Change tooltip component to accept generic content #15325
[@eVoloshchak / @s77rt / @flodnv] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: [Web] Change tooltip component to accept generic content #15325 (comment)
[@eVoloshchak / @s77rt / @flodnv] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App
[@michaelhaxhiu] Determine if we should create a regression test for this bug.
[@eVoloshchak / @s77rt] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@michaelhaxhiu] Link the GH issue for creating/updating the regression test once above steps have been agreed upon: https://github.com/Expensify/Expensify/issues/275564

s77rt · 2023-04-03T20:51:44Z

@eVoloshchak Will you take the checklist or should I do it?

eVoloshchak · 2023-04-03T21:04:26Z

@eVoloshchak Will you take the checklist or should I do it?

I'll do it tomorrow

michaelhaxhiu · 2023-04-04T11:07:38Z

Hmm I wonder if we need a regression test for this?

Was the original design (splitting the text) done by design or mistake in the code?

eVoloshchak · 2023-04-04T11:15:24Z

@michaelhaxhiu, It was due to a mistake in the code

eVoloshchak · 2023-04-04T20:20:48Z

The PR that introduced the bug has been identified. Link to the PR: [Web] Change tooltip component to accept generic content #15325

As @s77rt has previously said, this is a wrong calculation bug that has been revealed by this PR

The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: [Web] Change tooltip component to accept generic content #15325 (comment)
A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: this is a visual bug, we already have the following item in the checklist: If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App

avi-shek-jha · 2023-04-12T15:48:34Z

Hi @michaelhaxhiu. I am the external reporter for this bug. Why is the melvin bot asking me to submit a PR?

michaelhaxhiu · 2023-04-12T16:25:07Z

Sorry it's an automated action - it's because I assigned you to the GH. Ignore that please.

michaelhaxhiu · 2023-04-12T16:32:53Z

Helping move this forward. Here's a regression test suggestion:

Start a DM with that user that has a long email address (e.g. 25+ characters)
Click the other user's profile (from the DM)
Click the long email address, (e.g. hover & click the email a few times)
Ensure the Copy to clipboard tooltip text is one line

cc @eVoloshchak & @s77rt lmk if you agree or suggest a tweak

s77rt · 2023-04-12T16:41:53Z

@michaelhaxhiu I don't think that's the correct regression test, we can just use the PR Tests as the regression test.

Regression Test Proposal

Login to App
Click on FAB > New Chat
Create a chat with a user that has a very long email e.g. longlonglongemailaddress@longlonglongdomain.com
Click on user avatar
Hover the copy to clipboard button
Verify the tooltip shows "Copy to clipboard" in one line
Click the copy to clipboard button
Verify the tooltip shows "Copied!" in one line
Wait a few seconds
Verify the tooltip text is changed to "Copy to clipboard" and is still displayed in one line

michaelhaxhiu · 2023-04-12T16:43:21Z

we can just use the PR Tests as the regression test.

oh... duh.

michaelhaxhiu · 2023-04-12T16:43:30Z

cool, works for me

michaelhaxhiu · 2023-04-12T17:40:00Z

Checklist is satisfied. Closing.

MelvinBot · 2023-04-12T17:40:05Z

@flodnv @michaelhaxhiu Be sure to fill out the Contact List!

eVoloshchak · 2023-04-12T21:11:29Z

The payments weren't issued yet, shouldn't this still be open?

eVoloshchak · 2023-04-20T18:56:57Z

@michaelhaxhiu, I think this got closed out without issuing the payments, I still have the job in progress on Upwork

michaelhaxhiu · 2023-04-20T19:01:10Z

For some reason payment didn't go through for you the first time, despite me doing it? Weird. I'll do yours now again.

michaelhaxhiu · 2023-04-20T19:02:43Z

all set, sorry about that @eVoloshchak. I'm blaming Upwork this time because I'm certain I paid all 3 parties last week (yet yours failed).

kavimuru added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Mar 14, 2023

melvin-bot bot assigned michaelhaxhiu Mar 14, 2023

melvin-bot bot locked and limited conversation to collaborators Mar 14, 2023

melvin-bot bot added the Overdue label Mar 17, 2023

Expensify unlocked this conversation Mar 21, 2023

This comment was marked as outdated.

Sign in to view

michaelhaxhiu added the External Added to denote the issue can be worked on by a contributor label Mar 22, 2023

melvin-bot bot assigned eVoloshchak Mar 22, 2023

melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Mar 22, 2023

melvin-bot bot assigned flodnv Mar 22, 2023

melvin-bot bot removed the Overdue label Mar 22, 2023

eVoloshchak mentioned this issue Mar 22, 2023

[HOLD for payment 2023-04-03] [$1000] There is an extra ‘m’ in the edit comment when translated into Spanish #16053

Closed

6 tasks

melvin-bot bot added Daily KSv2 Overdue and removed Weekly KSv2 Daily KSv2 labels Apr 10, 2023

michaelhaxhiu assigned avi-shek-jha Apr 12, 2023

melvin-bot bot removed the Overdue label Apr 12, 2023

Expensify deleted a comment from MelvinBot Apr 12, 2023

michaelhaxhiu closed this as completed Apr 12, 2023

bernhardoj mentioned this issue Apr 29, 2023

Migrate TooltipRenderedOnPageBody and fix tooltip flicker/moving when the content changes #18189

Merged

57 tasks

[HOLD for payment 2023-04-10] [$1000] Hovering over again to ‘Copy to clipboard’ seems to split the ‘Copy to clipboard’ into two lines in the second click for long emails #15949

[HOLD for payment 2023-04-10] [$1000] Hovering over again to ‘Copy to clipboard’ seems to split the ‘Copy to clipboard’ into two lines in the second click for long emails #15949

Comments

kavimuru commented Mar 14, 2023 • edited by melvin-bot bot Loading

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

MelvinBot commented Mar 14, 2023

MelvinBot commented Mar 14, 2023 • edited by michaelhaxhiu Loading

Bug0 Triage Checklist (Main S/O)

MelvinBot commented Mar 17, 2023

MelvinBot commented Mar 21, 2023

This comment was marked as outdated.

MelvinBot commented Mar 22, 2023

MelvinBot commented Mar 22, 2023

MelvinBot commented Mar 22, 2023

MelvinBot commented Mar 22, 2023

michaelhaxhiu commented Mar 22, 2023

hungvu193 commented Mar 22, 2023

michaelhaxhiu commented Mar 22, 2023 • edited Loading

michaelhaxhiu commented Mar 22, 2023

situchan commented Mar 22, 2023

hungvu193 commented Mar 22, 2023

eVoloshchak commented Mar 22, 2023

michaelhaxhiu commented Mar 22, 2023

MelvinBot commented Apr 3, 2023

MelvinBot commented Apr 3, 2023 • edited by michaelhaxhiu Loading

MelvinBot commented Apr 3, 2023 • edited by michaelhaxhiu Loading

s77rt commented Apr 3, 2023

eVoloshchak commented Apr 3, 2023

michaelhaxhiu commented Apr 4, 2023

eVoloshchak commented Apr 4, 2023

eVoloshchak commented Apr 4, 2023

avi-shek-jha commented Apr 12, 2023

michaelhaxhiu commented Apr 12, 2023 • edited Loading

michaelhaxhiu commented Apr 12, 2023 • edited Loading

s77rt commented Apr 12, 2023

michaelhaxhiu commented Apr 12, 2023

michaelhaxhiu commented Apr 12, 2023

michaelhaxhiu commented Apr 12, 2023

MelvinBot commented Apr 12, 2023

eVoloshchak commented Apr 12, 2023

eVoloshchak commented Apr 20, 2023

michaelhaxhiu commented Apr 20, 2023

michaelhaxhiu commented Apr 20, 2023

kavimuru commented Mar 14, 2023 •

edited by melvin-bot bot

Loading

MelvinBot commented Mar 14, 2023 •

edited by michaelhaxhiu

Loading

michaelhaxhiu commented Mar 22, 2023 •

edited

Loading

MelvinBot commented Apr 3, 2023 •

edited by michaelhaxhiu

Loading

MelvinBot commented Apr 3, 2023 •

edited by michaelhaxhiu

Loading

michaelhaxhiu commented Apr 12, 2023 •

edited

Loading

michaelhaxhiu commented Apr 12, 2023 •

edited

Loading