Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2023-06-12] Allow pinning from the chat list #15960

Closed
Gonals opened this issue Mar 14, 2023 · 18 comments
Closed

[HOLD for payment 2023-06-12] Allow pinning from the chat list #15960

Gonals opened this issue Mar 14, 2023 · 18 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 Engineering Internal Requires API changes or must be handled by Expensify staff NewFeature Something to build that is a new item.

Comments

@Gonals
Copy link
Contributor

Gonals commented Mar 14, 2023

Problem: Currently, in order to pin chats in Newdot, you need to open the chat and do it from there. Now that we are using all these rooms in ECX, I’m finding it frustrating. My instinct is to long press the chat on the chat list to pin/unpin it from there.

Solution: Let’s leverage the long press/right click menu we have for report actions for the chats in the chat list. We can add the Pin/Unpin option there and simplify that action for everyone. Bonus: We can also add a “Mark as read” option in there pretty easily.

Slack conversation here. I plan to add the menu and pinning for now. After that, I'll create issues for other options in the menu

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~0162e137607f85a84b
  • Upwork Job ID: 1635722767050407936
  • Last Price Increase: 2023-03-14
@Gonals Gonals added Engineering Weekly KSv2 Internal Requires API changes or must be handled by Expensify staff NewFeature Something to build that is a new item. labels Mar 14, 2023
@Gonals Gonals self-assigned this Mar 14, 2023
@melvin-bot melvin-bot bot locked and limited conversation to collaborators Mar 14, 2023
@MelvinBot
Copy link

Job added to Upwork: https://www.upwork.com/jobs/~0162e137607f85a84b

@MelvinBot
Copy link

Triggered auto assignment to Contributor Plus for review of internal employee PR - @eVoloshchak (Internal)

@melvin-bot melvin-bot bot added the Reviewing Has a PR in review label Mar 18, 2023
@melvin-bot melvin-bot bot unlocked this conversation Mar 18, 2023
@melvin-bot melvin-bot bot added Monthly KSv2 and removed Weekly KSv2 labels Apr 11, 2023
@MelvinBot
Copy link

This issue has not been updated in over 15 days. @eVoloshchak, @Gonals eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Monthly KSv2 labels Jun 5, 2023
@melvin-bot melvin-bot bot changed the title Allow pinning from the chat list [HOLD for payment 2023-06-12] Allow pinning from the chat list Jun 5, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jun 5, 2023

Reviewing label has been removed, please complete the "BugZero Checklist".

@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Jun 5, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jun 5, 2023

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.23-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2023-06-12. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

  • External issue reporter
  • Contributor that fixed the issue
  • Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

  • Merged PR within 3 business days of assignment - 50% bonus
  • Merged PR more than 9 business days after assignment - 50% penalty

@melvin-bot melvin-bot bot added Daily KSv2 Overdue and removed Weekly KSv2 labels Jun 11, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jun 14, 2023

@eVoloshchak, @Gonals Whoops! This issue is 2 days overdue. Let's get this updated quick!

1 similar comment
@melvin-bot
Copy link

melvin-bot bot commented Jun 15, 2023

@eVoloshchak, @Gonals Whoops! This issue is 2 days overdue. Let's get this updated quick!

@melvin-bot
Copy link

melvin-bot bot commented Jun 16, 2023

@eVoloshchak, @Gonals Eep! 4 days overdue now. Issues have feelings too...

@melvin-bot
Copy link

melvin-bot bot commented Jun 20, 2023

@eVoloshchak, @Gonals Now this issue is 8 days overdue. Are you sure this should be a Daily? Feel free to change it!

@0xmiros
Copy link
Contributor

0xmiros commented Jun 20, 2023

@Gonals can you please add BZ member for payment?

@conorpendergrast
Copy link
Contributor

@Gonals Looks like another one for the $1000, correct?

@melvin-bot melvin-bot bot removed the Overdue label Jun 21, 2023
@0xmiros
Copy link
Contributor

0xmiros commented Jun 21, 2023

yes, this is another one.
There are 2 PRs related to LHN menu options.
This is the first implementation - pin/unpin
#20249 is the 2nd implementation - read/unread
Coincidentally, I was auto-assigned on both features 🙂

@conorpendergrast
Copy link
Contributor

Hah, yes, I saw that! I'll get both paid today 👍

@conorpendergrast
Copy link
Contributor

Offer sent here: https://www.upwork.com/nx/wm/pre-hire/c/8577561/offer/25165941

@eVoloshchak You declined it?

@eVoloshchak
Copy link
Contributor

eVoloshchak commented Jun 22, 2023

Yeah, I wasn't C+ for this, I think I got assigned by mistake?

@conorpendergrast
Copy link
Contributor

Yeah I just figured that out - and then confused myself a whole lot because of how similar your and @0xmiroslav 's avatars are. THANK YOU

@conorpendergrast
Copy link
Contributor

Ok, offer sent to the correct person this time: https://www.upwork.com/nx/wm/pre-hire/c/8577561/offer/25166080
Once that's accepted, I'll pay it

@conorpendergrast
Copy link
Contributor

Ok, there we go! @0xmiroslav paid, contract ended. All done, thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 Engineering Internal Requires API changes or must be handled by Expensify staff NewFeature Something to build that is a new item.
Projects
None yet
Development

No branches or pull requests

5 participants