Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2023-06-28] Allow Mark as Read/Unread from LHN #20249

Closed
Gonals opened this issue Jun 6, 2023 · 9 comments
Closed

[HOLD for payment 2023-06-28] Allow Mark as Read/Unread from LHN #20249

Gonals opened this issue Jun 6, 2023 · 9 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 Internal Requires API changes or must be handled by Expensify staff NewFeature Something to build that is a new item.

Comments

@Gonals
Copy link
Contributor

Gonals commented Jun 6, 2023

Problem: In NewDot, as opposed to most chat/messaging apps, in order to mark a conversation as read/unread, users need to actually open the chat. This is not a huge inconvenience on Desktop/web, but it can be on mobile. Our very own
@ted
has expressed a need for this feature so he can keep being a terrible friend on our platform too!

Solution: We now have a long-press menu on the LHN to Pin/Unpin chats! Let’s add another option to mark them as read/unread (the last message would be marked as unread)!

Slack proposal here

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01ad862a284f6e0c5e
  • Upwork Job ID: 1666024301398683648
  • Last Price Increase: 2023-06-06
@Gonals Gonals added Weekly KSv2 NewFeature Something to build that is a new item. labels Jun 6, 2023
@Gonals Gonals self-assigned this Jun 6, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jun 6, 2023

@Gonals Gonals added the Internal Requires API changes or must be handled by Expensify staff label Jun 6, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jun 6, 2023

Job added to Upwork: https://www.upwork.com/jobs/~01ad862a284f6e0c5e

@melvin-bot
Copy link

melvin-bot bot commented Jun 6, 2023

Triggered auto assignment to Contributor Plus for review of internal employee PR - @0xmiroslav (Internal)

@Gonals Gonals assigned conorpendergrast and 0xmiros and unassigned 0xmiros Jun 6, 2023
@melvin-bot melvin-bot bot added the Reviewing Has a PR in review label Jun 6, 2023
@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Jun 21, 2023
@melvin-bot melvin-bot bot changed the title Allow Mark as Read/Unread from LHN [HOLD for payment 2023-06-28] Allow Mark as Read/Unread from LHN Jun 21, 2023
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Jun 21, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jun 21, 2023

Reviewing label has been removed, please complete the "BugZero Checklist".

@melvin-bot
Copy link

melvin-bot bot commented Jun 21, 2023

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.29-11 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2023-06-28. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

  • External issue reporter
  • Contributor that fixed the issue
  • Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

  • Merged PR within 3 business days of assignment - 50% bonus
  • Merged PR more than 9 business days after assignment - 50% penalty

@conorpendergrast
Copy link
Contributor

@Gonals This doesn't have an explicit price on the issue, so unless I hear otherwise I'll pay out @0xmiroslav the default $1000

@Gonals
Copy link
Contributor Author

Gonals commented Jun 21, 2023

@Gonals This doesn't have an explicit price on the issue, so unless I hear otherwise I'll pay out @0xmiroslav the default $1000

That sounds reasonable!

@conorpendergrast
Copy link
Contributor

Offer sent to @0xmiroslav via Upwork: https://www.upwork.com/ab/applicants/1666024301398683648/hired
Once that's accepted, we'll have the wait period until June 28th and then that'll be paid out

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Jun 27, 2023
@conorpendergrast
Copy link
Contributor

Today is the day! Paid @0xmiroslav and ended contract. All done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 Internal Requires API changes or must be handled by Expensify staff NewFeature Something to build that is a new item.
Projects
None yet
Development

No branches or pull requests

3 participants